feat: command - handle argument errors via onUsageError()

Author: oprudkyi

console/cli_helper.go

@@ -292,6 +292,31 @@ func onUsageError(_ context.Context, _ *cli.Command, err error, _ bool) error {
 			return nil
 		}
 	}
+	if errMsg := err.Error(); strings.HasPrefix(errMsg, "invalid value") && strings.Contains(errMsg, "for argument") {
+		var value, argument string
+		if _, parseErr := fmt.Sscanf(errMsg, "invalid value %q for argument %s", &value, &argument); parseErr == nil {
+			var subErrMsg string
+			subErrMsgPos := strings.Index(errMsg, ":")
+			if subErrMsgPos != -1 {
+				subErrMsg = errMsg[subErrMsgPos+2:]
+			}
+			color.Red().Printfln("Invalid value '%s' for argument '%s'. Error: %s", value, strings.TrimSuffix(argument, ":"), subErrMsg)
+			return nil
+		}
+	}
+
+	if errMsg := err.Error(); strings.HasPrefix(errMsg, "sufficient count of arg") && strings.Contains(errMsg, "not provided") {
+		var argument string
+		var given, expected int
+		if _, parseErr := fmt.Sscanf(errMsg, "sufficient count of arg %s not provided, given %d expected %d", &argument, &given, &expected); parseErr == nil {
+			if expected == 1 {
+				color.Red().Printfln("The '%s' argument requires a value.", argument)
+			} else {
+				color.Red().Printfln("The '%s' argument requires at least %d values.", argument, expected)
+			}
+			return nil
+		}
+	}
 
 	return err
 }

console/cli_helper_test.go

@@ -59,7 +59,7 @@ func TestShowCommandHelp_HelpPrinterCustom(t *testing.T) {
    Test command
 
 Usage:
-   test [global options] test:foo [options] <string_arg> [uint16_arg] [string_args...]
+   test [global options] test:foo [options] <string_arg> <two_string_args...> [uint16_arg] [any_count_string_args...]
 
 Global options:
    -h, --help       Show help
@@ -124,6 +124,27 @@ Options:
 				color.Red().Sprint("Invalid value 'not-a-number' for option 'int'."),
 			},
 		},
+		{
+			name: "argument need a value",
+			call: "test:foo --int 0",
+			containsOutput: []string{
+				color.Red().Sprint("The 'string_arg' argument requires a value."),
+			},
+		},
+		{
+			name: "argument need a few values",
+			call: "test:foo --int 0 string_arg",
+			containsOutput: []string{
+				color.Red().Sprint("The 'two_string_args' argument requires at least 2 values."),
+			},
+		},
+		{
+			name: "argument value is not valid",
+			call: "test:foo --int 0 string_arg string_args1 string_args2 not-a-number",
+			containsOutput: []string{
+				color.Red().Sprint("Invalid value 'not-a-number' for argument 'uint16_arg'. Error: strconv.ParseUint: parsing \"not-a-number\": invalid syntax"),
+			},
+		},
 		{
 			name: "no ansi color",
 			call: "--no-ansi",
@@ -192,12 +213,18 @@ func (receiver *TestFooCommand) Extend() command.Extend {
 				Usage:    "string argument",
 				Required: true,
 			},
+			&command.ArgumentStringSlice{
+				Name:  "two_string_args",
+				Usage: "string arguments",
+				Min:   2,
+				Max:   2,
+			},
 			&command.ArgumentUint16{
 				Name:  "uint16_arg",
 				Usage: "uint16 argument",
 			},
 			&command.ArgumentStringSlice{
-				Name:  "string_args",
+				Name:  "any_count_string_args",
 				Usage: "string arguments",
 				Min:   0,
 				Max:   -1,