Use Marketplace.Post view for more efficient querying

Author: EjPlatzer

Gordon360/Models/CCT/Context/CCTContext.cs

@@ -146,6 +146,8 @@ public CCTContext(DbContextOptions<CCTContext> options)
 
     public virtual DbSet<ParticipantView> ParticipantView { get; set; }
 
+    public virtual DbSet<Post> Post { get; set; }
+
     public virtual DbSet<PostImage> PostImage { get; set; }
 
     public virtual DbSet<PostedItem> PostedItem { get; set; }
@@ -670,6 +672,11 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
             entity.Property(e => e.SpecifiedGender).IsFixedLength();
         });
 
+        modelBuilder.Entity<Post>(entity =>
+        {
+            entity.ToView("Post", "Marketplace");
+        });
+
         modelBuilder.Entity<PostImage>(entity =>
         {
             entity.HasOne(d => d.PostedItem).WithMany(p => p.PostImage)

Gordon360/Models/CCT/Context/efpt.CCT.config.json

@@ -418,6 +418,10 @@
          "Name": "[LostAndFound].[MissingItemData]",
          "ObjectType": 3
       },
+      {
+         "Name": "[Marketplace].[Post]",
+         "ObjectType": 3
+      },
       {
          "Name": "[RecIM].[ParticipantView]",
          "ObjectType": 3

Gordon360/Models/CCT/Marketplace/Post.cs

@@ -0,0 +1,60 @@
+// <auto-generated> This file has been auto generated by EF Core Power Tools. </auto-generated>
+#nullable disable
+using System;
+using System.Collections.Generic;
+using System.ComponentModel.DataAnnotations;
+using System.ComponentModel.DataAnnotations.Schema;
+using Microsoft.EntityFrameworkCore;
+
+namespace Gordon360.Models.CCT;
+
+[Keyless]
+public partial class Post
+{
+    public int Id { get; set; }
+
+    public int CategoryId { get; set; }
+
+    [Required]
+    [StringLength(50)]
+    public string CategoryName { get; set; }
+
+    public int ConditionId { get; set; }
+
+    [Required]
+    [StringLength(50)]
+    public string ConditionName { get; set; }
+
+    public DateTime? DeletedAt { get; set; }
+
+    [Required]
+    [StringLength(1000)]
+    public string Detail { get; set; }
+
+    [Required]
+    [StringLength(50)]
+    public string Name { get; set; }
+
+    public int? OriginalPostId { get; set; }
+
+    public DateTime PostedAt { get; set; }
+
+    public int PostedById { get; set; }
+
+    [StringLength(50)]
+    [Unicode(false)]
+    public string PostedByUsername { get; set; }
+
+    [Column(TypeName = "money")]
+    public decimal Price { get; set; }
+
+    public int StatusId { get; set; }
+
+    [Required]
+    [StringLength(50)]
+    public string StatusName { get; set; }
+
+    [StringLength(8000)]
+    [Unicode(false)]
+    public string ImagePaths { get; set; }
+}

Gordon360/Models/ViewModels/MarketplaceListingViewModel.cs

@@ -1,8 +1,7 @@
+using Gordon360.Models.CCT;
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using Gordon360.Models.CCT;
-using Gordon360.Models.CCT.Context;
 
 
 namespace Gordon360.Models.ViewModels
@@ -21,7 +20,7 @@ public class MarketplaceListingViewModel
         public int StatusId { get; set; }
         public string StatusName { get; set; }
         public List<string> ImagePaths { get; set; }
-        public string PosterUsername { get; set;  }
+        public string PosterUsername { get; set; }
 
         public static implicit operator MarketplaceListingViewModel(PostedItem item)
         {
@@ -41,5 +40,26 @@ public static implicit operator MarketplaceListingViewModel(PostedItem item)
                 ImagePaths = item.PostImage?.Select(img => img.ImagePath).ToList() ?? new List<string>(),
             };
         }
+
+
+        public static MarketplaceListingViewModel From(Post post)
+        {
+            return new MarketplaceListingViewModel
+            {
+                Id = post.Id,
+                PostedAt = post.PostedAt,
+                Name = post.Name,
+                Price = post.Price,
+                CategoryId = post.CategoryId,
+                CategoryName = post.CategoryName,
+                Detail = post.Detail,
+                ConditionId = post.ConditionId,
+                ConditionName = post.ConditionName,
+                StatusId = post.StatusId,
+                StatusName = post.StatusName,
+                ImagePaths = post.ImagePaths?.Split(";")?.ToList() ?? [],
+                PosterUsername = post.PostedByUsername
+            };
+        }
     }
 }

Gordon360/Services/MarketplaceService.cs

@@ -26,110 +26,32 @@ IAccountService accountService
         /// </summary>
         public IEnumerable<MarketplaceListingViewModel> GetAllListings()
         {
-            var items = context.PostedItem
-                .Include(x => x.Category)
-                .Include(x => x.Condition)
-                .Include(x => x.Status)
-                .Include(x => x.PostImage)
-                .Where(item => item.StatusId != 3)
-                .OrderByDescending(item => item.PostedAt)
-                .ToList(); // Materialize to memory
-
-            var accountDict = context.ACCOUNT
-                .Where(a => items.Select(i => i.PostedById.ToString()).Distinct().Contains(a.gordon_id))
-                .ToDictionary(a => a.gordon_id, a => a.AD_Username);
-
-            return items.Select(item => new MarketplaceListingViewModel
-            {
-                Id = item.Id,
-                PostedAt = item.PostedAt,
-                Name = item.Name,
-                Price = item.Price,
-                CategoryId = item.CategoryId,
-                CategoryName = item.Category?.CategoryName,
-                Detail = item.Detail,
-                ConditionId = item.ConditionId,
-                ConditionName = item.Condition?.ConditionName,
-                StatusId = item.StatusId,
-                StatusName = item.Status?.StatusName,
-                ImagePaths = item.PostImage?.Select(img => img.ImagePath).ToList() ?? new List<string>(),
-                PosterUsername = accountDict.TryGetValue(item.PostedById.ToString(), out var username) ? username : null
-            }).ToList();
+            return context.Post
+                     .Where(post => post.StatusId != 3)
+                     .OrderByDescending(post => post.PostedAt)
+                     .AsEnumerable()
+                     .Select(post => MarketplaceListingViewModel.From(post));
         }
 
         public IEnumerable<MarketplaceListingViewModel> GetUserListings(string username)
         {
-            var account = accountService.GetAccountByUsername(username);
-            if (account == null) return new List<MarketplaceListingViewModel>();
-
-            int userId = int.Parse(account.GordonID);
-
-            var items = context.PostedItem
-                .Include(x => x.Category)
-                .Include(x => x.Condition)
-                .Include(x => x.Status)
-                .Include(x => x.PostImage)
-                .Where(item => item.PostedById == userId && item.StatusId != 3)
+            return context.Post
+                .Where(item => item.PostedByUsername == username && item.StatusId != 3)
                 .OrderByDescending(item => item.PostedAt)
-                .ToList();
+                .Select(post => MarketplaceListingViewModel.From(post));
 
-            var accountDict = context.ACCOUNT
-                .Where(a => items.Select(i => i.PostedById.ToString()).Distinct().Contains(a.gordon_id))
-                .ToDictionary(a => a.gordon_id, a => a.AD_Username);
-
-            return items.Select(item => new MarketplaceListingViewModel
-            {
-                Id = item.Id,
-                PostedAt = item.PostedAt,
-                Name = item.Name,
-                Price = item.Price,
-                CategoryId = item.CategoryId,
-                CategoryName = item.Category?.CategoryName,
-                Detail = item.Detail,
-                ConditionId = item.ConditionId,
-                ConditionName = item.Condition?.ConditionName,
-                StatusId = item.StatusId,
-                StatusName = item.Status?.StatusName,
-                ImagePaths = item.PostImage?.Select(img => img.ImagePath).ToList() ?? new List<string>(),
-                PosterUsername = accountDict.TryGetValue(item.PostedById.ToString(), out var username) ? username : null
-            }).ToList();
         }
 
         /// <summary>
         /// Get a specific marketplace listing by ID.
         /// </summary>
         public MarketplaceListingViewModel GetListingById(int listingId)
         {
-            var listing = context.PostedItem
-                .Include(x => x.Category)
-                .Include(x => x.Condition)
-                .Include(x => x.Status)
-                .Include(x => x.PostImage)
-                .FirstOrDefault(x => x.Id == listingId);
-
-            if (listing == null)
-            {
-                throw new ResourceNotFoundException { ExceptionMessage = "Listing not found." };
-            }
-
-            var account = context.ACCOUNT.FirstOrDefault(a => a.gordon_id == listing.PostedById.ToString());
+            var listing = context.Post.FirstOrDefault(post => post.Id == listingId);
 
-            return new MarketplaceListingViewModel
-            {
-                Id = listing.Id,
-                PostedAt = listing.PostedAt,
-                Name = listing.Name,
-                Price = listing.Price,
-                CategoryId = listing.CategoryId,
-                CategoryName = listing.Category?.CategoryName,
-                Detail = listing.Detail,
-                ConditionId = listing.ConditionId,
-                ConditionName = listing.Condition?.ConditionName,
-                StatusId = listing.StatusId,
-                StatusName = listing.Status?.StatusName,
-                ImagePaths = listing.PostImage?.Select(img => img.ImagePath).ToList() ?? new List<string>(),
-                PosterUsername = account?.AD_Username
-            };
+            return listing == null
+                ? throw new ResourceNotFoundException { ExceptionMessage = "Listing not found." }
+                : MarketplaceListingViewModel.From(listing);
         }
 
         /// <summary>
@@ -296,11 +218,7 @@ public IEnumerable<MarketplaceListingViewModel> GetFilteredListings(
             string? search, string? sortBy, bool desc = false,
             int page = 1, int pageSize = 20)
         {
-            var query = context.PostedItem
-                .Include(x => x.Category)
-                .Include(x => x.Condition)
-                .Include(x => x.Status)
-                .Include(x => x.PostImage)
+            var query = context.Post
                 .Where(x => x.StatusId != 3);
 
             if (categoryId.HasValue)
@@ -338,28 +256,7 @@ public IEnumerable<MarketplaceListingViewModel> GetFilteredListings(
             // Pagination
             query = query.Skip((page - 1) * pageSize).Take(pageSize);
 
-            var items = query.ToList();
-
-            var accountDict = context.ACCOUNT
-                .Where(a => items.Select(i => i.PostedById.ToString()).Distinct().Contains(a.gordon_id))
-                .ToDictionary(a => a.gordon_id, a => a.AD_Username);
-
-            return items.Select(item => new MarketplaceListingViewModel
-            {
-                Id = item.Id,
-                PostedAt = item.PostedAt,
-                Name = item.Name,
-                Price = item.Price,
-                CategoryId = item.CategoryId,
-                CategoryName = item.Category?.CategoryName,
-                Detail = item.Detail,
-                ConditionId = item.ConditionId,
-                ConditionName = item.Condition?.ConditionName,
-                StatusId = item.StatusId,
-                StatusName = item.Status?.StatusName,
-                ImagePaths = item.PostImage?.Select(img => img.ImagePath).ToList() ?? new List<string>(),
-                PosterUsername = accountDict.TryGetValue(item.PostedById.ToString(), out var username) ? username : null
-            }).ToList();
+            return query.Select(post => MarketplaceListingViewModel.From(post));
         }