diff --git a/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx b/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx index f771d9cad8..1ba1255a29 100644 --- a/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx +++ b/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx @@ -87,11 +87,15 @@ const MyHall = () => { } }, [profile]); + // Refactored to follow the Single Responsibility Principle + const generateRDProfileLink = (email) => { + if (!email) return DEFAULT_PROFILE_URL; + const [firstName, lastName] = rdInfo.RD_Email.split('@')[0].split('.'); + return DEFAULT_PROFILE_URL + `${firstName}.${lastName}`; + }; + useEffect(() => { - if (rdInfo?.RD_Email) { - const [firstName, lastName] = rdInfo.RD_Email.split('@')[0].split('.'); - setRdProfileLink(DEFAULT_PROFILE_URL + `${firstName}.${lastName}`); - } + setRdProfileLink(generateRDProfileLink(rdInfo?.RD_Email)); }, [rdInfo]); // Show loading state if profile is not yet loaded @@ -144,7 +148,13 @@ const MyHall = () => { - My Assigned Rooms: {isRA ? : <>} + {isRA ? ( + + My Assigned Rooms: {' '} + + ) : ( + <> + )}