From d1798d388be8a144b18b255890888a5d742162cd Mon Sep 17 00:00:00 2001
From: Jason Asonye <jasonasonye@gmail.com>
Date: Mon, 31 Mar 2025 14:33:57 -0400
Subject: [PATCH] wmr-SRP example for class and minor UI update on MyHall

---
 .../ResidentView/components/MyHall/index.jsx  | 20 ++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx b/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx
index f771d9cad8..1ba1255a29 100644
--- a/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx
+++ b/src/views/ResLife/components/ResidentView/components/MyHall/index.jsx
@@ -87,11 +87,15 @@ const MyHall = () => {
     }
   }, [profile]);
 
+  // Refactored to follow the Single Responsibility Principle
+  const generateRDProfileLink = (email) => {
+    if (!email) return DEFAULT_PROFILE_URL;
+    const [firstName, lastName] = rdInfo.RD_Email.split('@')[0].split('.');
+    return DEFAULT_PROFILE_URL + `${firstName}.${lastName}`;
+  };
+
   useEffect(() => {
-    if (rdInfo?.RD_Email) {
-      const [firstName, lastName] = rdInfo.RD_Email.split('@')[0].split('.');
-      setRdProfileLink(DEFAULT_PROFILE_URL + `${firstName}.${lastName}`);
-    }
+    setRdProfileLink(generateRDProfileLink(rdInfo?.RD_Email));
   }, [rdInfo]);
 
   // Show loading state if profile is not yet loaded
@@ -144,7 +148,13 @@ const MyHall = () => {
             </Typography>
 
             <Typography variant="body1">
-              <strong>My Assigned Rooms:</strong> {isRA ? <AssignedRooms /> : <></>}
+              {isRA ? (
+                <strong>
+                  My Assigned Rooms: <AssignedRooms />{' '}
+                </strong>
+              ) : (
+                <></>
+              )}
             </Typography>
           </Grid>