Skip to content

Commit 2e98cc7

Browse files
committed
fix: improve deb.arch_variant
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
1 parent 2c03e7d commit 2e98cc7

File tree

3 files changed

+28
-16
lines changed

3 files changed

+28
-16
lines changed

deb/deb.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,14 @@ func ensureValidArch(info *nfpm.Info) *nfpm.Info {
6060
info.Arch = arch
6161
}
6262

63+
switch info.Deb.ArchVariant {
64+
case "", "amd64v1", "amd64v2", "amd64v3", "amd64v4":
65+
// ignore empty, ignore already valid
66+
case "v1", "v2", "v3", "v4":
67+
// prefix 'amd64' to valid versions
68+
info.Deb.ArchVariant = "amd64" + info.Deb.ArchVariant
69+
}
70+
6371
return info
6472
}
6573

deb/deb_test.go

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -529,24 +529,27 @@ func TestDebEpoch(t *testing.T) {
529529

530530
func TestDebRules(t *testing.T) {
531531
var w bytes.Buffer
532-
require.NoError(t, writeControl(&w, controlData{
533-
Info: nfpm.WithDefaults(&nfpm.Info{
534-
Name: "lala",
535-
Arch: "arm64",
536-
Description: "Has rules script",
537-
Priority: "extra",
538-
Epoch: "2",
539-
Version: "1.2.0",
540-
Section: "default",
541-
Maintainer: "maintainer",
542-
Overridables: nfpm.Overridables{
543-
Deb: nfpm.Deb{
544-
Scripts: nfpm.DebScripts{
545-
Rules: "foo.sh",
546-
},
532+
info := nfpm.WithDefaults(&nfpm.Info{
533+
Name: "lala",
534+
Arch: "arm64",
535+
Description: "Has rules script",
536+
Priority: "extra",
537+
Epoch: "2",
538+
Version: "1.2.0",
539+
Section: "default",
540+
Maintainer: "maintainer",
541+
Overridables: nfpm.Overridables{
542+
Deb: nfpm.Deb{
543+
ArchVariant: "v2",
544+
Scripts: nfpm.DebScripts{
545+
Rules: "foo.sh",
547546
},
548547
},
549-
}),
548+
},
549+
})
550+
ensureValidArch(info)
551+
require.NoError(t, writeControl(&w, controlData{
552+
Info: info,
550553
}))
551554
golden := "testdata/rules.golden"
552555
if *update {

deb/testdata/rules.golden

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Version: 2:1.2.0
33
Section: default
44
Priority: extra
55
Architecture: arm64
6+
Architecture-Variant: amd64v2
67
Maintainer: maintainer
78
Installed-Size: 0
89
Description: Has rules script

0 commit comments

Comments
 (0)