code review before 0.9.8.0

Author: gorhill

_locales/de/messages.json

@@ -757,9 +757,9 @@
         "message": "Temporär alles erlauben",
         "description": "English: Temporarily whitelist all"
     },
-    "commandOpenSettings" : {
-        "message": "Einstellungen ...",
-        "description": "English: Settings..."
+    "commandOpenDashboard" : {
+        "message": "Einstellungen",
+        "description": "English: Open dashboard"
     },
 
 

_locales/en/messages.json

@@ -757,9 +757,9 @@
         "message": "Temporarily whitelist all",
         "description": "English: Temporarily whitelist all"
     },
-    "commandOpenSettings" : {
-        "message": "Settings...",
-        "description": "English: Settings..."
+    "commandOpenDashboard" : {
+        "message": "Open dashboard",
+        "description": "English: Open dashboard"
     },
 
 

_locales/fr/messages.json

@@ -757,9 +757,9 @@
         "message": "Permettre temporairement tous les domaines la page",
         "description": "English: Temporarily whitelist all"
     },
-    "commandOpenSettings" : {
-        "message": "Paramètres...",
-        "description": "English: Settings..."
+    "commandOpenDashboard" : {
+        "message": "Paramètres",
+        "description": "English: Open dashboard"
     },
 
 

_locales/ru/messages.json

@@ -757,9 +757,9 @@
         "message": "Temporarily whitelist all",
         "description": "English: Temporarily whitelist all"
     },
-    "commandOpenSettings" : {
-        "message": "Settings...",
-        "description": "English: Settings..."
+    "commandOpenDashboard" : {
+        "message": "Open dashboard",
+        "description": "English: Open dashboard"
     },
 
 

_locales/zh_CN/messages.json

@@ -757,9 +757,9 @@
         "message": "Temporarily whitelist all",
         "description": "English: Temporarily whitelist all"
     },
-    "commandOpenSettings" : {
-        "message": "Settings...",
-        "description": "English: Settings..."
+    "commandOpenDashboard" : {
+        "message": "Open dashboard",
+        "description": "English: Open dashboard"
     },
 
 

js/commands.js

@@ -68,7 +68,7 @@ var onCommand = function(command) {
     case 'whitelist-all':
         chrome.tabs.query({ active: true }, whitelistAll);
         break;
-    case 'open-settings':
+    case 'open-dashboard':
         chrome.runtime.sendMessage({
             what: 'gotoExtensionURL',
             url: 'dashboard.html'

manifest.json

@@ -41,8 +41,8 @@
                 "mac": "Command+Shift+W"
             }
         },
-       "open-settings": {
-            "description": "__MSG_commandOpenSettings__",
+       "open-dashboard": {
+            "description": "__MSG_commandOpenDashboard__",
             "suggested_key": {
                 "default": "Alt+S",
                 "mac": "Command+Shift+S"