fix neoforge new versioning system

Author: blarfoon

daedalus_client/src/common/manifest_merge.rs

@@ -123,12 +123,12 @@ pub fn sort_loaders_by_metadata(version: &mut Version, loader_order: &[String])
     version.loaders.sort_by(|x, y| {
         let x_pos = loader_order
             .iter()
-            .position(|z| &y.id == z)
+            .position(|z| &x.id == z)
             .unwrap_or(usize::MAX);
 
         let y_pos = loader_order
             .iter()
-            .position(|z| &x.id == z)
+            .position(|z| &y.id == z)
             .unwrap_or(usize::MAX);
 
         x_pos.cmp(&y_pos)

daedalus_client/src/neoforge/mod.rs

@@ -15,7 +15,8 @@ use daedalus::modded::{
 };
 use daedalus::get_hash;
 use tracing::{info, warn};
-use semver::Version;
+// Note: Using lenient_semver instead of semver::Version to handle
+// non-standard NeoForge versions like "26.1.0.0-alpha.1+snapshot-1"
 use serde::{Deserialize, Serialize};
 use std::collections::{HashMap, HashSet};
 use std::convert::TryInto;
@@ -73,17 +74,21 @@ pub async fn retrieve_data(
         let mut loaders = Vec::new();
 
         for (loader_version, new_forge) in loader_versions {
-            let version = Version::parse(&loader_version)?;
+            // Validate version format using lenient_semver (handles 4+ component versions like "26.1.0.0-alpha.1")
+            if let Err(e) = lenient_semver::parse(&loader_version) {
+                warn!("Skipping NeoForge version '{}' with invalid format: {}", loader_version, e);
+                continue;
+            }
 
-            loaders.push((loader_version, version, new_forge.to_string()))
+            loaders.push((loader_version, new_forge.to_string()))
         }
 
         if !loaders.is_empty() {
             version_futures.push(async {
                 let mut loaders_versions = Vec::new();
 
                 {
-                    let loaders_futures = loaders.into_iter().map(|(loader_version_full, _, new_forge)| async {
+                    let loaders_futures = loaders.into_iter().map(|(loader_version_full, new_forge)| async {
                         let versions_mutex = Arc::clone(&old_versions);
                         let visited_assets = Arc::clone(&visited_assets);
                         let semaphore = Arc::clone(&semaphore);