Fix GetUserFeedback on ClickHouse with HAVING clause (#1157)

zhenghaoz · web-flow · commit fa81f1eb8543 · 2026-02-01T21:24:09.000+08:00
diff --git a/storage/data/database_test.go b/storage/data/database_test.go
@@ -392,6 +392,12 @@ func (suite *baseTestSuite) TestFeedback() {
 	suite.NoError(err)
 	err = suite.Database.Optimize()
 	suite.NoError(err)
+	// Get feedback by user with value filter
+	ret, err = suite.Database.GetUserFeedback(ctx, "0", lo.ToPtr(time.Now()),
+		expression.FeedbackTypeExpression{FeedbackType: positiveFeedbackType, Value: 50, ExprType: expression.Greater})
+	suite.NoError(err)
+	suite.Equal(1, len(ret))
+	suite.Equal(float64(100), ret[0].Value)
 	ret, err = suite.Database.GetUserFeedback(ctx, "0", lo.ToPtr(time.Now()), expression.MustParseFeedbackTypeExpression(positiveFeedbackType))
 	suite.NoError(err)
 	suite.Equal(1, len(ret))
diff --git a/storage/data/sql.go b/storage/data/sql.go
@@ -972,7 +972,11 @@ func (d *SQLDatabase) GetUserFeedback(ctx context.Context, userId string, endTim
 		for _, feedbackType := range feedbackTypes {
 			db = FeedbackTypeExpressionToSQL(db, feedbackType)
 		}
-		tx.Where(db)
+		if d.driver == ClickHouse {
+			tx.Having(db)
+		} else {
+			tx.Where(db)
+		}
 	}
 	result, err := tx.Rows()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -972,7 +972,11 @@ func (d *SQLDatabase) GetUserFeedback(ctx context.Context, userId string, endTim`
`972`	`972`	`for _, feedbackType := range feedbackTypes {`
`973`	`973`	`db = FeedbackTypeExpressionToSQL(db, feedbackType)`
`974`	`974`	`}`
`975`		`- tx.Where(db)`
	`975`	`+ if d.driver == ClickHouse {`
	`976`	`+ tx.Having(db)`
	`977`	`+ } else {`
	`978`	`+ tx.Where(db)`
	`979`	`+ }`
`976`	`980`	`}`
`977`	`981`	`result, err := tx.Rows()`
`978`	`982`	`if err != nil {`