test: Verify some standard HTML form post behaviour

stroiman · stroiman · commit d65f3bc2b03e · 2026-02-19T07:50:12.000+01:00
diff --git a/html/html_button_element.go b/html/html_button_element.go
@@ -1,6 +1,10 @@
 package html
 
-import "strings"
+import (
+	"strings"
+
+	"github.com/gost-dom/browser/internal/log"
+)
 
 type HTMLButtonElement interface {
 	HTMLElement
@@ -39,7 +43,9 @@ func (e *htmlButtonElement) trySubmitForm() {
 		parent = parent.ParentNode()
 	}
 	if form != nil {
-		form.RequestSubmit(e)
+		if err := form.RequestSubmit(e); err != nil {
+			e.logger().Error("Button click, error submitting form", log.ErrAttr(err))
+		}
 	}
 }
 
diff --git a/html/html_form_element.go b/html/html_form_element.go
@@ -8,6 +8,7 @@ import (
 
 	"github.com/gost-dom/browser/dom"
 	"github.com/gost-dom/browser/dom/event"
+	"github.com/gost-dom/browser/internal/log"
 	"github.com/gost-dom/browser/url"
 )
 
@@ -127,6 +128,8 @@ func (e *htmlFormElement) submitFormData(formData *FormData) error {
 		req.Header.Add("Content-Type", "application/x-www-form-urlencoded")
 	}
 	if err != nil {
+		l := e.logger()
+		l.Error("Error creating request for form", log.ErrAttr(err))
 		return err
 	}
 	return e.htmlDocument.window().fetchRequest(req)
diff --git a/html/html_form_element_submit_test.go b/html/html_form_element_submit_test.go
@@ -1,6 +1,7 @@
 package html_test
 
 import (
+	"log/slog"
 	"net/http"
 	"net/url"
 	"reflect"
@@ -9,13 +10,15 @@ import (
 	"github.com/gost-dom/browser/dom/event"
 	"github.com/gost-dom/browser/html"
 	"github.com/gost-dom/browser/internal/gosthttp"
+	"github.com/gost-dom/browser/internal/testing/browsertest"
 	"github.com/gost-dom/browser/internal/testing/eventtest"
 	"github.com/gost-dom/browser/internal/testing/fixtures"
 	. "github.com/gost-dom/browser/internal/testing/gomega-matchers"
 	"github.com/gost-dom/browser/internal/testing/gosttest"
 	"github.com/gost-dom/browser/internal/testing/htmltest"
 	. "github.com/gost-dom/browser/testing/gomega-matchers"
 	"github.com/gost-dom/fixture"
+	"github.com/stretchr/testify/assert"
 )
 
 type HTTPHandlerFixture struct{ *http.ServeMux }
@@ -296,6 +299,7 @@ func TestHTMLFormElementSubmitInputWithClickResetButton(t *testing.T) {
 }
 
 func TestResubmitFormOn307Redirects(t *testing.T) {
+	assert := assert.New(t)
 	w, setup := fixture.Init(t, &HTMLFormSubmitInputFixture{})
 	w.BaseLocation = "http://example.com/forms"
 	setup.Setup()
@@ -309,6 +313,25 @@ func TestResubmitFormOn307Redirects(t *testing.T) {
 	form.SetAction("/form-destination")
 	form.Submit()
 
-	w.Assert().Equal(1, len(rec.Requests), "Request sent to the redirected location")
-	w.Assert().Equal([]string{"bar"}, rec.Single().PostForm["foo"])
+	assert.Equal(1, len(rec.Requests), "Request sent to the redirected location")
+	assert.Equal([]string{"bar"}, rec.Single().PostForm["foo"])
+}
+
+func TestFormSubmitDisplaysPageOnNewLocation(t *testing.T) {
+	h := gosttest.HttpHandlerMap{
+		"/": gosttest.StaticHTML(`<body>
+			<form method="post" action="/post/action">
+				<input type="submit" id="btn">Submit</input>
+			</form>
+		</body>`),
+		"/post/action": gosttest.StaticHTML(`<body><h1>Target page</h1></body>`),
+	}
+	b := browsertest.InitBrowser(t, h, nil, browsertest.WithMinLogLevel(slog.LevelDebug))
+	win := b.OpenWindow("http://example.com/")
+	t.Log(win.HTMLDocument().DocumentElement().OuterHTML())
+	btn := win.HTMLDocument().GetHTMLElementById("btn")
+	btn.Click()
+	t.Log(win.HTMLDocument().Body().OuterHTML())
+	h1 := win.HTMLDocument().MustQuerySelectorHTML("h1")
+	assert.Equal(t, "Target page", h1.TextContent())
 }
diff --git a/html/window.go b/html/window.go
@@ -367,9 +367,12 @@ func (w *window) get(href string) error {
 func (w *window) fetchRequest(req *http.Request) error {
 	// Create a copy of the client, and set the CheckRedirect to a function that
 	// updates the window location to reflect the new URL.
+	l := w.Logger()
+	l.Info("window.fetchRequest", "method", req.Method, "url", req.URL.String())
 	client := w.httpClient
 	client.CheckRedirect = w.checkRedirect
 	resp, err := client.Do(req)
+	l.Debug("window.fetchRequest done", log.ErrAttr(err), slog.Int("status", resp.StatusCode))
 	if err != nil {
 		return err
 	}
diff --git a/internal/testing/htmltest/helpers.go b/internal/testing/htmltest/helpers.go
@@ -146,6 +146,14 @@ func NewHTMLParentNodeHelper(t testing.TB, n dom.ElementParent) HTMLParentNodeHe
 	return HTMLParentNodeHelper{t, n}
 }
 
+func (h HTMLParentNodeHelper) MustQuerySelectorHTML(pattern string) HTMLElementHelper {
+	res := h.QuerySelectorHTML(pattern)
+	if res.HTMLElement == nil {
+		h.t.Fatalf("QuerySelector returned nil: %s", pattern)
+	}
+	return res
+}
+
 func (h HTMLParentNodeHelper) QuerySelectorHTML(pattern string) (res HTMLElementHelper) {
 	h.t.Helper()
 	e, err := h.ElementParent.QuerySelector(pattern)

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,10 @@`
`1`	`1`	`package html`
`2`	`2`
`3`		`-import "strings"`
	`3`	`+import (`
	`4`	`+ "strings"`
	`5`	`+`
	`6`	`+ "github.com/gost-dom/browser/internal/log"`
	`7`	`+)`
`4`	`8`
`5`	`9`	`type HTMLButtonElement interface {`
`6`	`10`	`HTMLElement`
`@@ -39,7 +43,9 @@ func (e *htmlButtonElement) trySubmitForm() {`
`39`	`43`	`parent = parent.ParentNode()`
`40`	`44`	`}`
`41`	`45`	`if form != nil {`
`42`		`- form.RequestSubmit(e)`
	`46`	`+ if err := form.RequestSubmit(e); err != nil {`
	`47`	`+ e.logger().Error("Button click, error submitting form", log.ErrAttr(err))`
	`48`	`+ }`
`43`	`49`	`}`
`44`	`50`	`}`
`45`	`51`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ import (`
`8`	`8`
`9`	`9`	`"github.com/gost-dom/browser/dom"`
`10`	`10`	`"github.com/gost-dom/browser/dom/event"`
	`11`	`+ "github.com/gost-dom/browser/internal/log"`
`11`	`12`	`"github.com/gost-dom/browser/url"`
`12`	`13`	`)`
`13`	`14`
`@@ -127,6 +128,8 @@ func (e htmlFormElement) submitFormData(formData FormData) error {`
`127`	`128`	`req.Header.Add("Content-Type", "application/x-www-form-urlencoded")`
`128`	`129`	`}`
`129`	`130`	`if err != nil {`
	`131`	`+ l := e.logger()`
	`132`	`+ l.Error("Error creating request for form", log.ErrAttr(err))`
`130`	`133`	`return err`
`131`	`134`	`}`
`132`	`135`	`return e.htmlDocument.window().fetchRequest(req)`