|
| 1 | +--- |
| 2 | +description: Interactive technical design quality review and validation |
| 3 | +allowed-tools: Bash, Glob, Grep, Read, Task, WebFetch, WebSearch |
| 4 | +argument-hint: <feature-name> |
| 5 | +--- |
| 6 | + |
| 7 | +# Technical Design Validation |
| 8 | + |
| 9 | +Interactive design quality review for feature: **$1** |
| 10 | + |
| 11 | +## Context Loading |
| 12 | + |
| 13 | +### Prerequisites Validation |
| 14 | +- Design document must exist: `.kiro/specs/$1/design.md` |
| 15 | +- If not exist, stop with message: "Run `/kiro:spec-design $1` first to generate design document" |
| 16 | + |
| 17 | +### Review Context |
| 18 | +- Spec metadata: @.kiro/specs/$1/spec.json |
| 19 | +- Requirements document: @.kiro/specs/$1/requirements.md |
| 20 | +- Design document: @.kiro/specs/$1/design.md |
| 21 | +- Core steering documents: |
| 22 | + - Architecture: @.kiro/steering/structure.md |
| 23 | + - Technology: @.kiro/steering/tech.md |
| 24 | + - Product context: @.kiro/steering/product.md |
| 25 | +- Custom steering: All additional `.md` files in `.kiro/steering/` directory |
| 26 | + |
| 27 | +## Task: Interactive Design Quality Review |
| 28 | + |
| 29 | +### Review Methodology |
| 30 | + |
| 31 | +**Focus**: Critical issues only - limit to 3 most important concerns |
| 32 | +**Format**: Interactive dialogue with immediate feedback and improvement suggestions |
| 33 | +**Outcome**: GO/NO-GO decision with clear rationale |
| 34 | + |
| 35 | +### Core Review Criteria |
| 36 | + |
| 37 | +#### 1. Existing Architecture Alignment (Critical) |
| 38 | +**Evaluation Points**: |
| 39 | +- Integration with existing system boundaries and layers |
| 40 | +- Consistency with established architectural patterns |
| 41 | +- Proper dependency direction and coupling management |
| 42 | +- Alignment with current module organization and responsibilities |
| 43 | + |
| 44 | +**Review Questions**: |
| 45 | +- Does this design respect existing architectural boundaries? |
| 46 | +- Are new components properly integrated with existing systems? |
| 47 | +- Does the design follow established patterns and conventions? |
| 48 | + |
| 49 | +#### 2. Design Consistency & Standards |
| 50 | +**Evaluation Points**: |
| 51 | +- Adherence to project naming conventions and code standards |
| 52 | +- Consistent error handling and logging strategies |
| 53 | +- Uniform approach to configuration and dependency management |
| 54 | +- Alignment with established data modeling patterns |
| 55 | + |
| 56 | +**Review Questions**: |
| 57 | +- Is the design consistent with existing code standards? |
| 58 | +- Are error handling and configuration approaches unified? |
| 59 | +- Does naming and structure follow project conventions? |
| 60 | + |
| 61 | +#### 3. Extensibility & Maintainability |
| 62 | +**Evaluation Points**: |
| 63 | +- Design flexibility for future requirements changes |
| 64 | +- Clear separation of concerns and single responsibility principle |
| 65 | +- Testability and debugging considerations |
| 66 | +- Documentation and code clarity requirements |
| 67 | + |
| 68 | +**Review Questions**: |
| 69 | +- How well does this design handle future changes? |
| 70 | +- Are responsibilities clearly separated and testable? |
| 71 | +- Is the design complexity appropriate for the requirements? |
| 72 | + |
| 73 | +#### 4. Type Safety & Interface Design |
| 74 | +**Evaluation Points** (for TypeScript projects): |
| 75 | +- Proper type definitions and interface contracts |
| 76 | +- Avoidance of `any` types and unsafe patterns |
| 77 | +- Clear API boundaries and data structure definitions |
| 78 | +- Input validation and error handling coverage |
| 79 | + |
| 80 | +**Review Questions**: |
| 81 | +- Are types properly defined and interfaces clear? |
| 82 | +- Is the API design robust and well-defined? |
| 83 | +- Are edge cases and error conditions handled appropriately? |
| 84 | + |
| 85 | +### Interactive Review Process |
| 86 | + |
| 87 | +#### Step 1: Design Analysis |
| 88 | +Thoroughly analyze the design document against all review criteria, identifying the most critical issues that could impact: |
| 89 | +- System integration and compatibility |
| 90 | +- Long-term maintainability |
| 91 | +- Implementation complexity and risks |
| 92 | +- Requirements fulfillment accuracy |
| 93 | + |
| 94 | +#### Step 2: Critical Issues Identification |
| 95 | +**Limit to 3 most important concerns maximum**. For each critical issue: |
| 96 | + |
| 97 | +**Issue Format**: |
| 98 | +``` |
| 99 | +🔴 **Critical Issue [1-3]**: [Brief title] |
| 100 | +**Concern**: [Specific problem description] |
| 101 | +**Impact**: [Why this matters for the project] |
| 102 | +**Suggestion**: [Concrete improvement recommendation] |
| 103 | +``` |
| 104 | + |
| 105 | +#### Step 3: Design Strengths Recognition |
| 106 | +Acknowledge 1-2 strong aspects of the design to maintain balanced feedback. |
| 107 | + |
| 108 | +#### Step 4: GO/NO-GO Decision |
| 109 | + |
| 110 | +**GO Criteria**: |
| 111 | +- No critical architectural misalignment |
| 112 | +- Requirements adequately addressed |
| 113 | +- Implementation path is clear and reasonable |
| 114 | +- Risks are acceptable and manageable |
| 115 | + |
| 116 | +**NO-GO Criteria**: |
| 117 | +- Fundamental architectural conflicts |
| 118 | +- Critical requirements not addressed |
| 119 | +- Implementation approach has high failure risk |
| 120 | +- Design complexity disproportionate to requirements |
| 121 | + |
| 122 | +### Output Format |
| 123 | + |
| 124 | +Generate review in the language specified in spec.json (check `.kiro/specs/$1/spec.json` for "language" field): |
| 125 | + |
| 126 | +#### Design Review Summary |
| 127 | +Brief overview of the design's overall quality and readiness. |
| 128 | + |
| 129 | +#### Critical Issues (Maximum 3) |
| 130 | +For each issue identified: |
| 131 | +- **Issue**: Clear problem statement |
| 132 | +- **Impact**: Why it matters |
| 133 | +- **Recommendation**: Specific improvement suggestion |
| 134 | + |
| 135 | +#### Design Strengths |
| 136 | +1-2 positive aspects worth highlighting. |
| 137 | + |
| 138 | +#### Final Assessment |
| 139 | +**Decision**: GO / NO-GO |
| 140 | +**Rationale**: Clear reasoning for the decision |
| 141 | +**Next Steps**: What should happen next |
| 142 | + |
| 143 | +#### Interactive Discussion |
| 144 | +Engage in dialogue about: |
| 145 | +- Designer's perspective on identified issues |
| 146 | +- Alternative approaches or trade-offs |
| 147 | +- Clarification of design decisions |
| 148 | +- Agreement on necessary changes (if any) |
| 149 | + |
| 150 | +## Review Guidelines |
| 151 | + |
| 152 | +1. **Critical Focus**: Only flag issues that significantly impact success |
| 153 | +2. **Constructive Tone**: Provide solutions, not just criticism |
| 154 | +3. **Interactive Approach**: Engage in dialogue rather than one-way evaluation |
| 155 | +4. **Balanced Assessment**: Recognize both strengths and weaknesses |
| 156 | +5. **Clear Decision**: Make definitive GO/NO-GO recommendation |
| 157 | +6. **Actionable Feedback**: Ensure all suggestions are implementable |
| 158 | + |
| 159 | +## Instructions |
| 160 | + |
| 161 | +1. **Load all context documents** - Understand full project scope |
| 162 | +2. **Analyze design thoroughly** - Review against all criteria |
| 163 | +3. **Identify critical issues only** - Focus on most important problems |
| 164 | +4. **Engage interactively** - Discuss findings with user |
| 165 | +5. **Make clear decision** - Provide definitive GO/NO-GO |
| 166 | +6. **Guide next steps** - Clear direction for proceeding |
| 167 | + |
| 168 | +**Remember**: This is quality assurance, not perfection seeking. The goal is ensuring the design is solid enough to proceed to implementation with acceptable risk. |
| 169 | + |
| 170 | +--- |
| 171 | + |
| 172 | +## Next Phase: Task Generation |
| 173 | + |
| 174 | +After design validation: |
| 175 | + |
| 176 | +**If design passes validation (GO decision):** |
| 177 | +Run `/kiro:spec-tasks $1` to generate implementation tasks |
| 178 | + |
| 179 | +**Auto-approve and proceed:** |
| 180 | +Run `/kiro:spec-tasks $1 -y` to auto-approve requirements and design, then generate tasks directly |
0 commit comments