CompileString returns error

Author: cpunion

demo/autoderef/autoderef.go

@@ -29,7 +29,11 @@ for i in range(10):
 
 	mod := gp.ImportModule("__main__")
 	gbl := mod.Dict()
-	code := gp.CompileString(pythonCode, "<string>", gp.FileInput)
+	code, err := gp.CompileString(pythonCode, "<string>", gp.FileInput)
+	if err != nil {
+		fmt.Printf("Failed to compile Python code: %v\n", err)
+		return
+	}
 	_ = gp.EvalCode(code, gbl, gp.Nil().AsDict())
 	for i := 0; i < 10; i++ {
 		result := gp.EvalCode(code, gbl, gp.Nil().AsDict())

object_test.go

@@ -82,7 +82,10 @@ class TestClass:
 	globals := MakeDict(nil)
 	globals.Set(MakeStr("__builtins__"), builtins.Object)
 
-	code := CompileString(pyCode, "<string>", FileInput)
+	code, err := CompileString(pyCode, "<string>", FileInput)
+	if err != nil {
+		t.Errorf("CompileString() error = %v", err)
+	}
 
 	EvalCode(code, globals, locals).AsModule()
 	testClass := locals.Get(MakeStr("TestClass")).AsFunc()
@@ -237,7 +240,10 @@ class TestClass:
 	builtins := ImportModule("builtins")
 	globals.Set(MakeStr("__builtins__"), builtins.Object)
 
-	code := CompileString(pyCode, "<string>", FileInput)
+	code, err := CompileString(pyCode, "<string>", FileInput)
+	if err != nil {
+		t.Errorf("CompileString() error = %v", err)
+	}
 	EvalCode(code, globals, locals)
 
 	testClass := locals.Get(MakeStr("TestClass")).AsFunc()
@@ -278,7 +284,10 @@ def make_tuple():
 		builtins := ImportModule("builtins")
 		globals.Set(MakeStr("__builtins__"), builtins.Object)
 
-		code := CompileString(pyCode, "<string>", FileInput)
+		code, err := CompileString(pyCode, "<string>", FileInput)
+		if err != nil {
+			t.Errorf("CompileString() error = %v", err)
+		}
 		EvalCode(code, globals, locals)
 
 		makeTuple := locals.Get(MakeStr("make_tuple")).AsFunc()

python.go

@@ -36,14 +36,21 @@ const (
 	EvalInput   InputType = C.Py_eval_input
 )
 
-func CompileString(code, filename string, start InputType) Object {
+func CompileString(code, filename string, start InputType) (Object, error) {
 	ccode := AllocCStr(code)
 	cfilename := AllocCStr(filename)
 	o := C.Py_CompileString(ccode, cfilename, C.int(start))
 	// TODO: check why double free
 	C.free(unsafe.Pointer(ccode))
 	C.free(unsafe.Pointer(cfilename))
-	return newObject(o)
+	if o == nil {
+		err := FetchError()
+		if err != nil {
+			return Object{}, err
+		}
+		return Object{}, fmt.Errorf("failed to compile code")
+	}
+	return newObject(o), nil
 }
 
 func EvalCode(code Object, globals, locals Dict) Object {
@@ -91,9 +98,9 @@ func RunString(code string) error {
 	dict := main.Dict()
 
 	// Run the code string
-	codeObj := CompileString(code, "<string>", FileInput)
-	if codeObj.Nil() {
-		return fmt.Errorf("failed to compile code")
+	codeObj, err := CompileString(code, "<string>", FileInput)
+	if err != nil {
+		return err
 	}
 
 	ret := EvalCode(codeObj, dict, dict)

python_test.go

@@ -71,7 +71,7 @@ func TestCompileString(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		obj := CompileString(tt.code, tt.filename, tt.start)
+		obj, _ := CompileString(tt.code, tt.filename, tt.start)
 		if obj.Nil() != tt.wantNil {
 			t.Errorf("CompileString() returned nil = %v, want %v", obj.Nil(), tt.wantNil)
 		}