fix(cli): wire up journal field in work add command

lucifer1004 · lucifer1004 · commit e45c3f3879e6 · 2026-02-24T16:10:17.000+08:00
Add missing "journal" match arm in add_to_field() so that
`govctl work add &lt;WI&gt; journal "..."` works instead of returning E0810.

Also fix snapshot test instability: signature hashes embed today's date
via the spec, making them change daily. Normalize sha256 hashes to
`sha256:&lt;HASH&gt;` in test output so snapshots are date-independent.

Add test_work_add_journal integration test covering the new code path.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,11 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [0.5.2] - 2026-02-23
+### Added
+
+- test_work_add_journal integration test (WI-2026-02-24-001)
 
 ### Fixed
 
-- `commit` skill is now correctly bundled
+- work add journal command succeeds (WI-2026-02-24-001)
+- snapshot tests stable across days/machines (WI-2026-02-24-001)
 
 ## [0.5.1] - 2026-02-22
 
diff --git a/gov/releases.toml b/gov/releases.toml
@@ -1,11 +1,3 @@
-[[releases]]
-version = "0.5.2"
-date = "2026-02-23"
-refs = [
-    "WI-2026-02-22-005",
-    "WI-2026-02-22-006",
-]
-
 [[releases]]
 version = "0.5.1"
 date = "2026-02-22"
diff --git a/gov/work/2026-02-22-add-tests-for-render-adr-and-render-work-item-new-fields.toml b/gov/work/2026-02-22-add-tests-for-render-adr-and-render-work-item-new-fields.toml
@@ -8,9 +8,7 @@ started = "2026-02-22"
 completed = "2026-02-22"
 
 [content]
-description = """
-Describe the work to be done.
-What is the goal? What are the acceptance criteria?"""
+description = "Add unit tests for render_adr (pros, cons, rejection_reason) and render_work_item (journal field) to cover new ADR-0027 and ADR-0026 fields."
 
 [[content.acceptance_criteria]]
 text = "Unit tests cover render_adr with pros, cons, rejection_reason"
diff --git a/gov/work/2026-02-22-fix-non-deterministic-output-in-rfc-finalize.toml b/gov/work/2026-02-22-fix-non-deterministic-output-in-rfc-finalize.toml
@@ -8,9 +8,7 @@ started = "2026-02-22"
 completed = "2026-02-22"
 
 [content]
-description = """
-Describe the work to be done.
-What is the goal? What are the acceptance criteria?"""
+description = "Fix non-deterministic output ordering in rfc finalize command to ensure CI test stability."
 
 [[content.acceptance_criteria]]
 text = "CI test passes with deterministic output order"
diff --git a/gov/work/2026-02-24-fix-journal-add-command-for-work-items.toml b/gov/work/2026-02-24-fix-journal-add-command-for-work-items.toml
@@ -0,0 +1,34 @@
+[govctl]
+schema = 1
+id = "WI-2026-02-24-001"
+title = "Fix journal add command for work items"
+status = "done"
+created = "2026-02-24"
+started = "2026-02-24"
+completed = "2026-02-24"
+
+[content]
+description = "Fix govctl work add journal command which returned E0810 (not an array or unsupported). Also fix snapshot test instability caused by date-dependent signature hashes."
+
+[[content.journal]]
+date = "2026-02-24"
+content = "Fixed missing journal arm in add_to_field match statement"
+
+[[content.journal]]
+date = "2026-02-24"
+content = "Added journal arm to add_to_field match in edit.rs. Fixed snapshot instability by normalizing sha256 hashes in test output. Added test_work_add_journal integration test. Updated 14 stale snapshots."
+
+[[content.acceptance_criteria]]
+text = "work add journal command succeeds"
+status = "done"
+category = "fixed"
+
+[[content.acceptance_criteria]]
+text = "snapshot tests stable across days/machines"
+status = "done"
+category = "fixed"
+
+[[content.acceptance_criteria]]
+text = "test_work_add_journal integration test"
+status = "done"
+category = "added"
diff --git a/src/cmd/edit.rs b/src/cmd/edit.rs
@@ -671,6 +671,15 @@ pub fn add_to_field(
                             ));
                     }
                 }
+                "journal" => {
+                    use crate::model::JournalEntry;
+                    use crate::write::today;
+                    entry.spec.content.journal.push(JournalEntry {
+                        date: today(),
+                        scope: None,
+                        content: value.to_string(),
+                    });
+                }
                 "notes" => {
                     if !entry.spec.content.notes.contains(&value.to_string()) {
                         entry.spec.content.notes.push(value.to_string());
diff --git a/tests/common/mod.rs b/tests/common/mod.rs
@@ -33,6 +33,12 @@ pub fn normalize_output(output: &str, dir: &Path, date: &str) -> String {
         .replace_all(&normalized, "ADR-XXXX-")
         .to_string();
 
+    // Replace signature hashes (date-dependent due to embedded dates in specs)
+    let sig_pattern = regex::Regex::new(r"sha256:[0-9a-f]{64}").unwrap();
+    normalized = sig_pattern
+        .replace_all(&normalized, "sha256:<HASH>")
+        .to_string();
+
     normalized
 }
 
diff --git a/tests/snapshots/test_display_paths__render_adr_display_path.snap b/tests/snapshots/test_display_paths__render_adr_display_path.snap
@@ -6,7 +6,7 @@ $ govctl adr render ADR-0001 --dry-run
 Would write: docs/adr/ADR-0001.md
 --- Content preview ---
 <!-- GENERATED: do not edit. Source: ADR-0001 -->
-<!-- SIGNATURE: sha256:1361156622c0cda06e5f42f70800f307a78793d6586e8a7d5b700a9d4326c18c -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # ADR-0001: Test Decision
 
diff --git a/tests/snapshots/test_display_paths__render_rfc_display_path.snap b/tests/snapshots/test_display_paths__render_rfc_display_path.snap
@@ -6,7 +6,7 @@ $ govctl rfc render RFC-0001 --dry-run
 Would write: docs/rfc/RFC-0001.md
 --- Content preview ---
 <!-- GENERATED: do not edit. Source: RFC-0001 -->
-<!-- SIGNATURE: sha256:61ddb76cfb587b6be51e84d202960a419c1c3cdb136f01ccbfff817cd13fee51 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # RFC-0001: Test RFC
 
diff --git a/tests/snapshots/test_display_paths__render_work_display_path.snap b/tests/snapshots/test_display_paths__render_work_display_path.snap
@@ -6,7 +6,7 @@ $ govctl work render WI-<DATE>-001 --dry-run
 Would write: docs/work/WI-<DATE>-001.md
 --- Content preview ---
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:77cba937dcfbc7e5d9125d64e477feb0b5d6d9eee8c65503700a1d1b23ae3dda -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Test Work
 
diff --git a/tests/snapshots/test_edit__adr_set_consequences.snap b/tests/snapshots/test_edit__adr_set_consequences.snap
@@ -12,7 +12,7 @@ exit: 0
 
 $ govctl adr show ADR-0001
 <!-- GENERATED: do not edit. Source: ADR-0001 -->
-<!-- SIGNATURE: sha256:a0fd56dcf7afe7e806f41b34583d385b0096319aa6151361fc93001a2ac0c4ca -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # ADR-0001: Test Decision
 
diff --git a/tests/snapshots/test_edit__adr_set_context.snap b/tests/snapshots/test_edit__adr_set_context.snap
@@ -12,7 +12,7 @@ exit: 0
 
 $ govctl adr show ADR-0001
 <!-- GENERATED: do not edit. Source: ADR-0001 -->
-<!-- SIGNATURE: sha256:cdde59cc41263090ba911686d92e53d573c18ee07b1da911cfe778e8390d2a69 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # ADR-0001: Test Decision
 
diff --git a/tests/snapshots/test_edit__adr_set_decision.snap b/tests/snapshots/test_edit__adr_set_decision.snap
@@ -12,7 +12,7 @@ exit: 0
 
 $ govctl adr show ADR-0001
 <!-- GENERATED: do not edit. Source: ADR-0001 -->
-<!-- SIGNATURE: sha256:a31fca89df91370d6b6a477700d169606f8bc5e47f7f4db66c405fbba0691086 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # ADR-0001: Test Decision
 
diff --git a/tests/snapshots/test_edit__work_add_acceptance_criteria.snap b/tests/snapshots/test_edit__work_add_acceptance_criteria.snap
@@ -17,7 +17,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:ee6f6ae54764d92179425e19043585ac837eeacdb76b441c7b7ab297e32983ee -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Test Task
 
diff --git a/tests/snapshots/test_edit__work_add_journal.snap b/tests/snapshots/test_edit__work_add_journal.snap
@@ -0,0 +1,40 @@
+---
+source: tests/test_edit.rs
+expression: "normalize_output(&output, temp_dir.path(), &date)"
+---
+$ govctl work new Test Task
+Created work item: gov/work/<DATE>-test-task.toml
+  ID: WI-<DATE>-001
+exit: 0
+
+$ govctl work add WI-<DATE>-001 journal First progress update
+Added 'First progress update' to WI-<DATE>-001.journal
+exit: 0
+
+$ govctl work add WI-<DATE>-001 journal Second progress update
+Added 'Second progress update' to WI-<DATE>-001.journal
+exit: 0
+
+$ govctl work show WI-<DATE>-001
+<!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
+<!-- SIGNATURE: sha256:<HASH> -->
+
+# Test Task
+
+> **ID:** WI-<DATE>-001 | **Status:** queue
+
+## Description
+
+Describe the work to be done.
+What is the goal? What are the acceptance criteria?
+
+## Journal
+
+### <DATE>
+
+First progress update
+
+### <DATE>
+
+Second progress update
+exit: 0
diff --git a/tests/snapshots/test_edit__work_remove_acceptance_criteria.snap b/tests/snapshots/test_edit__work_remove_acceptance_criteria.snap
@@ -21,7 +21,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:88cb8a312e909e73958241250127272c4bf223aec18983fa9563723c0be0ec10 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Test Task
 
diff --git a/tests/snapshots/test_edit__work_tick_acceptance_criteria.snap b/tests/snapshots/test_edit__work_tick_acceptance_criteria.snap
@@ -21,7 +21,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:1f3129e2aa6e71dd04dd412b50b376889e2e570e73c2a6bc9260d147fe9696a9 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Test Task
 
diff --git a/tests/snapshots/test_edit__work_tick_cancel_acceptance_criteria.snap b/tests/snapshots/test_edit__work_tick_cancel_acceptance_criteria.snap
@@ -17,7 +17,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:9d6399508d5e012a2395103c3c30ed9aab382b5e74a9a07e108cb6d7b9a9df45 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Test Task
 
diff --git a/tests/snapshots/test_lifecycle__bump_with_change.snap b/tests/snapshots/test_lifecycle__bump_with_change.snap
@@ -17,7 +17,7 @@ exit: 0
 
 $ govctl rfc show RFC-0001
 <!-- GENERATED: do not edit. Source: RFC-0001 -->
-<!-- SIGNATURE: sha256:a7b4066dff5af62ff299770989d3e597d4075e22e2059613163bf6b9c30466d7 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # RFC-0001: Test RFC
 
diff --git a/tests/snapshots/test_move__move_sets_completed_date.snap b/tests/snapshots/test_move__move_sets_completed_date.snap
@@ -8,7 +8,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:a0d1ea75e4aec48eb7def9ef5d9c29cfc4df2c7416f92a6665a61aa2ad4a0594 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Task to complete
 
@@ -30,7 +30,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:e93dd996402d8e0b6af0e19e32ce964d10de4591d5c941cd15092ce49665938f -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Task to complete
 
diff --git a/tests/snapshots/test_move__move_sets_started_date.snap b/tests/snapshots/test_move__move_sets_started_date.snap
@@ -9,7 +9,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:39d2c1974c0af3dba2297d162dd15ecb76b9be4bfe247ba24012cde5aa7e4c22 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Task to start
 
@@ -27,7 +27,7 @@ exit: 0
 
 $ govctl work show WI-<DATE>-001
 <!-- GENERATED: do not edit. Source: WI-<DATE>-001 -->
-<!-- SIGNATURE: sha256:8a936d944c87167edc0000b05b29784c98a87f5f17ce601c492cab30bb2c1d72 -->
+<!-- SIGNATURE: sha256:<HASH> -->
 
 # Task to start
 
diff --git a/tests/test_edit.rs b/tests/test_edit.rs
@@ -480,6 +480,35 @@ fn test_work_tick_cancel_acceptance_criteria() {
     insta::assert_snapshot!(normalize_output(&output, temp_dir.path(), &date));
 }
 
+#[test]
+fn test_work_add_journal() {
+    let temp_dir = init_project();
+    let date = today();
+
+    let output = run_commands(
+        temp_dir.path(),
+        &[
+            &["work", "new", "Test Task"],
+            &[
+                "work",
+                "add",
+                &format!("WI-{}-001", date),
+                "journal",
+                "First progress update",
+            ],
+            &[
+                "work",
+                "add",
+                &format!("WI-{}-001", date),
+                "journal",
+                "Second progress update",
+            ],
+            &["work", "show", &format!("WI-{}-001", date)],
+        ],
+    );
+    insta::assert_snapshot!(normalize_output(&output, temp_dir.path(), &date));
+}
+
 #[test]
 fn test_work_add_ref() {
     let temp_dir = init_project();
