Move mark_pages_section_completed action to PagesController

This action is performed when a post request is made to the /pages
routes, so it makes sense to exist in the PagesController.

Author: stephencdaly

app/controllers/forms_controller.rb

@@ -8,28 +8,4 @@ def show
     @task_status_counts = task_service.task_counts
     render :show, locals: { current_form: }
   end
-
-  def mark_pages_section_completed
-    authorize current_form, :can_view_form?
-    @pages = current_form.pages
-    @mark_complete_input = Forms::MarkPagesSectionCompleteInput.new(mark_complete_input_params)
-
-    if @mark_complete_input.submit
-      success_message = if @mark_complete_input.mark_complete == "true"
-                          t("banner.success.form.pages_saved_and_section_completed")
-                        else
-                          t("banner.success.form.pages_saved")
-                        end
-      redirect_to form_path(current_form.id), success: success_message
-    else
-      @mark_complete_input.mark_complete = "false"
-      render "pages/index", locals: { current_form: }, status: :unprocessable_content
-    end
-  end
-
-private
-
-  def mark_complete_input_params
-    params.require(:forms_mark_pages_section_complete_input).permit(:mark_complete).merge(form: current_form)
-  end
 end

app/controllers/pages_controller.rb

@@ -83,6 +83,23 @@ def move_page
     redirect_to form_pages_path, success: success_message
   end
 
+  def mark_pages_section_completed
+    @pages = current_form.pages
+    @mark_complete_input = Forms::MarkPagesSectionCompleteInput.new(mark_complete_input_params)
+
+    if @mark_complete_input.submit
+      success_message = if @mark_complete_input.mark_complete == "true"
+                          t("banner.success.form.pages_saved_and_section_completed")
+                        else
+                          t("banner.success.form.pages_saved")
+                        end
+      redirect_to form_path(current_form.id), success: success_message
+    else
+      @mark_complete_input.mark_complete = "false"
+      render "pages/index", locals: { current_form: }, status: :unprocessable_content
+    end
+  end
+
 private
 
   def clear_draft_questions_data
@@ -126,6 +143,10 @@ def setup_draft_question_for_existing_page
     edit_draft_question
   end
 
+  def mark_complete_input_params
+    params.require(:forms_mark_pages_section_complete_input).permit(:mark_complete).merge(form: current_form)
+  end
+
   def set_answer_type_logging_attribute
     if @draft_question.present?
       CurrentLoggingAttributes.answer_type = @draft_question.answer_type

config/routes.rb

@@ -85,7 +85,7 @@
 
     scope "/pages" do
       get "/" => "pages#index", as: :form_pages
-      post "/" => "forms#mark_pages_section_completed"
+      post "/" => "pages#mark_pages_section_completed"
       post "/move-page" => "pages#move_page", as: :move_page
       get "/change-order" => "pages/change_order#new", as: :change_order_new
       post "/change-order" => "pages/change_order#create", as: :change_order_create

spec/requests/forms_controller_spec.rb

@@ -70,44 +70,4 @@
       expect(response.status).to eq(404)
     end
   end
-
-  describe "#mark_pages_section_completed" do
-    let(:pages) do
-      [build(:page, id: 99)]
-    end
-
-    let(:form) { create(:form, pages:, question_section_completed: "false") }
-
-    let(:user) do
-      standard_user
-    end
-
-    before do
-      login_as user
-
-      post form_pages_path(form.id), params: { forms_mark_pages_section_complete_input: { mark_complete: "true" } }
-    end
-
-    it "Redirects you to the form overview page" do
-      expect(response).to redirect_to(form_path(form.id))
-    end
-
-    context "when the mark completed form is invalid" do
-      before do
-        post form_pages_path(form.id), params: { forms_mark_pages_section_complete_input: { mark_complete: nil } }
-      end
-
-      it "renders the index page" do
-        expect(response).to render_template("pages/index")
-      end
-
-      it "returns 422 error code" do
-        expect(response.status).to eq(422)
-      end
-
-      it "sets mark_complete to false" do
-        expect(assigns[:mark_complete_input].mark_complete).to eq("false")
-      end
-    end
-  end
 end

spec/requests/pages_controller_spec.rb

@@ -393,4 +393,36 @@
       end
     end
   end
+
+  describe "#mark_pages_section_completed" do
+    let(:form) { create(:form, :with_pages, question_section_completed: "false") }
+
+    before do
+      group.group_forms.create!(form: form)
+
+      post form_pages_path(form.id), params: { forms_mark_pages_section_complete_input: { mark_complete: "true" } }
+    end
+
+    it "Redirects you to the form overview page" do
+      expect(response).to redirect_to(form_path(form.id))
+    end
+
+    context "when the mark completed form is invalid" do
+      before do
+        post form_pages_path(form.id), params: { forms_mark_pages_section_complete_input: { mark_complete: nil } }
+      end
+
+      it "renders the index page" do
+        expect(response).to render_template("pages/index")
+      end
+
+      it "returns 422 error code" do
+        expect(response.status).to eq(422)
+      end
+
+      it "sets mark_complete to false" do
+        expect(assigns[:mark_complete_input].mark_complete).to eq("false")
+      end
+    end
+  end
 end