Merge pull request #2587 from alphagov/dont-copy-made-live-dates-from-form

Do not copy first_made_live_at when copying a form

Author: stephencdaly

app/services/form_copy_service.rb

@@ -1,7 +1,7 @@
 class FormCopyService
   include LoggingHelper
 
-  DONT_COPY = %i[created_at updated_at submission_email].freeze
+  DONT_COPY = %i[created_at updated_at first_made_live_at submission_email].freeze
   TO_EXCLUDE = Form::ATTRIBUTES_NOT_IN_FORM_DOCUMENT + DONT_COPY
 
   def initialize(form, logged_in_user)

spec/services/form_copy_service_spec.rb

@@ -54,6 +54,11 @@
       expect(copied_form.updated_at).not_to eq(source_form.updated_at)
     end
 
+    it "does not copy attributes that we exclude from copying" do
+      expect(copied_form.first_made_live_at).to be_nil
+      expect(copied_form.submission_email).to be_nil
+    end
+
     context "when source form has completed tasks" do
       before do
         source_form.update!(