Add branching_enabled to summary_card_data_presenter

This commit changes the way the summary_card_data_presenter checks if
the branching feature flag is enabled.

The flag can now be set on a group. The value is passed down from the
controller into the views. The tests are updated where needed.

Author: thomasiles

app/controllers/pages/routes_controller.rb

@@ -1,7 +1,7 @@
 class Pages::RoutesController < PagesController
   def show
     back_link_url = form_pages_path(current_form.id)
-    render locals: { current_form:, page:, pages: FormRepository.pages(current_form), back_link_url: }
+    render locals: { current_form:, page:, pages: FormRepository.pages(current_form), back_link_url:, branching_enabled: }
   end
 
   def delete

app/presenters/route_summary_card_data_presenter.rb

@@ -3,18 +3,19 @@ class RouteSummaryCardDataPresenter
   include ActionView::Helpers::UrlHelper
   include GovukRailsCompatibleLinkHelper
 
-  attr_reader :form, :page, :pages
+  attr_reader :form, :page, :pages, :branching_enabled
 
   class << self
     def call(**args)
       new(**args)
     end
   end
 
-  def initialize(form:, page:, pages:)
+  def initialize(form:, page:, pages:, branching_enabled:)
     @page = page
     @pages = pages
     @form = form
+    @branching_enabled = branching_enabled
   end
 
   def summary_card_data
@@ -64,7 +65,7 @@ def conditional_route_card(routing_condition, index)
   def default_route_card(index)
     continue_to_name = page.has_next_page? ? page_name(page.next_page) : end_page_name
 
-    actions = if FeatureService.enabled?(:branch_routing) && all_routes.find(&:secondary_skip?).present?
+    actions = if branching_enabled && all_routes.find(&:secondary_skip?).present?
                 [
                   edit_secondary_skip_link,
                   delete_secondary_skip_link,
@@ -101,7 +102,7 @@ def secondary_skip_rows
     secondary_skip = all_routes.find(&:secondary_skip?)
 
     if secondary_skip.blank?
-      if FeatureService.enabled?(:branch_routing)
+      if branching_enabled
         return [
           {
             key: { text: I18n.t("page_route_card.then") },

app/views/pages/routes/show.html.erb

@@ -16,7 +16,7 @@
           end;
       end %>
 
-      <% RouteSummaryCardDataPresenter.call(form: current_form, page:, pages:).summary_card_data.each do |card| %>
+      <% RouteSummaryCardDataPresenter.call(form: current_form, page:, pages:, branching_enabled: ).summary_card_data.each do |card| %>
           <%= govuk_summary_list(**card) %>
       <% end %>
 

spec/presenters/route_summary_card_data_presenter_spec.rb

@@ -3,7 +3,7 @@
 describe RouteSummaryCardDataPresenter do
   include Capybara::RSpecMatchers
 
-  subject(:service) { described_class.new(form:, page: current_page, pages:) }
+  subject(:service) { described_class.new(form:, page: current_page, pages:, branching_enabled:) }
 
   let(:form) { build :form, id: 99, pages: }
 
@@ -25,9 +25,11 @@
 
   let(:next_page_routing_conditions) { [] }
 
+  let(:branching_enabled) { false }
+
   describe ".call" do
     it "instantiates and returns a new instance" do
-      service = described_class.call(form:, page: current_page, pages:)
+      service = described_class.call(form:, page: current_page, pages:, branching_enabled:)
       expect(service).to be_an_instance_of(described_class)
     end
   end
@@ -50,7 +52,9 @@
         expect(result[1][:rows][0][:value][:text]).to eq("2. Next Question")
       end
 
-      context "with branch_routing enabled", :feature_branch_routing do
+      context "with branch_routing enabled" do
+        let(:branching_enabled) { true }
+
         it "has the link to create a secondary skip" do
           result = service.summary_card_data
           expect(result[1][:rows][1][:value][:text]).to have_link("Set one or more questions to skip later in the form (optional)", href: "/forms/99/pages/1/routes/any-other-answer/questions-to-skip/new")
@@ -106,6 +110,8 @@
       end
 
       context "with branch_routing enabled", :feature_branch_routing do
+        let(:branching_enabled) { true }
+
         it "shows the edit secondary skip link" do
           result = service.summary_card_data
           expect(result[1][:card][:actions].first).to have_link("Edit", href: "/forms/99/pages/1/routes/any-other-answer/questions-to-skip")

spec/views/pages/routes/show.html.erb_spec.rb

@@ -19,7 +19,7 @@
 
   before do
     allow(RouteSummaryCardDataPresenter).to receive(:call).and_return(route_summary_card_data_service)
-    render template: "pages/routes/show", locals: { current_form: form, page:, pages: form.pages, back_link_url: "/back" }
+    render template: "pages/routes/show", locals: { current_form: form, page:, pages: form.pages, back_link_url: "/back", branching_enabled: true }
   end
 
   it "has the correct title" do