Update checking feature_daily_submission_emails_enabled flag in tests

The FeatureService stubbing didn't work with the new feature flag that
had been added, so set the feature flag using RSpec metadata instead.

Author: stephencdaly

spec/requests/forms/daily_submission_batch_controller_spec.rb

@@ -1,15 +1,12 @@
 require "rails_helper"
 
-RSpec.describe Forms::DailySubmissionBatchController, type: :request do
+RSpec.describe Forms::DailySubmissionBatchController, :feature_daily_submission_emails_enabled, type: :request do
   let(:form) { create(:form, :live, send_daily_submission_batch: send_daily_submission_batch_original_value) }
   let(:send_daily_submission_batch_original_value) { false }
   let(:current_user) { standard_user }
   let(:group) { create(:group, organisation: standard_user.organisation) }
-  let(:daily_submission_emails_enabled) { true }
 
   before do
-    allow(FeatureService).to receive(:enabled?).with(:daily_submission_emails_enabled).and_return(daily_submission_emails_enabled)
-
     Membership.create!(group_id: group.id, user: standard_user, added_by: standard_user)
     GroupForm.create!(form_id: form.id, group_id: group.id)
 
@@ -37,9 +34,7 @@
       end
     end
 
-    context "when the feature flag is disabled" do
-      let(:daily_submission_emails_enabled) { false }
-
+    context "when the feature flag is disabled", feature_daily_submission_emails_enabled: false do
       it "returns 404" do
         expect(response).to have_http_status(:not_found)
       end