Merge pull request #2667 from govuk-forms/fix-welsh-deletion

Fix welsh deletion

Author: thomasiles

app/controllers/forms/welsh_translation_controller.rb

@@ -13,7 +13,7 @@ def create
       @welsh_translation_input = WelshTranslationInput.new(welsh_translation_params)
       @table_presenter = Forms::TranslationTablePresenter.new
 
-      if @welsh_translation_input.all_fields_empty?
+      if @welsh_translation_input.blanked?
         # if all fields are empty we delete the welsh translation
         @delete_welsh_translation_input = Forms::DeleteWelshTranslationInput.new(form: current_form)
         if @delete_welsh_translation_input.submit_without_confirm

app/input_objects/forms/welsh_condition_translation_input.rb

@@ -83,4 +83,8 @@ def exit_page_markdown_cy_length_and_tags
   def page
     @page ||= condition.routing_page
   end
+
+  def all_fields_empty?
+    attributes.except!("id").values.all?(&:blank?)
+  end
 end

app/input_objects/forms/welsh_page_translation_input.rb

@@ -261,4 +261,12 @@ def welsh_answer_settings
 
     answer_settings_cloned
   end
+
+  def all_fields_empty?
+    attributes.except!("id").values.all?(&:blank?)
+  end
+
+  def blanked?
+    all_fields_empty? && condition_translations.all?(&:all_fields_empty?) && selection_options_cy.all?(&:all_fields_empty?)
+  end
 end

app/input_objects/forms/welsh_selection_option_translation_input.rb

@@ -42,6 +42,10 @@ def question_number
     page.position
   end
 
+  def all_fields_empty?
+    name_cy.blank?
+  end
+
 private
 
   def name_present?

app/input_objects/forms/welsh_translation_input.rb

@@ -123,6 +123,10 @@ def assign_form_values
     self
   end
 
+  def blanked?
+    all_fields_empty? && page_translations.all?(&:blanked?)
+  end
+
   def all_fields_empty?
     attributes.except!("mark_complete").values.all?(&:blank?)
   end

spec/input_objects/forms/welsh_condition_translation_input_spec.rb

@@ -222,4 +222,20 @@ def create_condition(attributes = {})
       expect(welsh_condition_translation_input.form_field_id(:exit_page_heading_cy)).to eq "forms_welsh_condition_translation_input_#{condition.id}_condition_translations_exit_page_heading_cy"
     end
   end
+
+  describe "#all_fields_empty?" do
+    context "when the welsh condition fields are not empty" do
+      it "returns false" do
+        expect(welsh_condition_translation_input.all_fields_empty?).to be false
+      end
+    end
+
+    context "when the welsh condition fields are all empty" do
+      let(:new_input_data) { { condition:, exit_page_markdown_cy: "", exit_page_heading_cy: "" } }
+
+      it "returns true" do
+        expect(welsh_condition_translation_input.all_fields_empty?).to be true
+      end
+    end
+  end
 end

spec/input_objects/forms/welsh_page_translation_input_spec.rb

@@ -632,4 +632,79 @@ def create_page(attributes = {})
       end
     end
   end
+
+  describe "#all_fields_empty?" do
+    context "when the welsh page fields are not empty" do
+      it "returns false" do
+        expect(welsh_page_translation_input.all_fields_empty?).to be false
+      end
+    end
+
+    context "when the welsh page fields are all empty" do
+      let(:new_input_data) { { page:, question_text_cy: "", hint_text_cy: "", page_heading_cy: "", guidance_markdown_cy: "" } }
+
+      it "returns true" do
+        expect(welsh_page_translation_input.all_fields_empty?).to be true
+      end
+    end
+  end
+
+  describe "#blanked?" do
+    let(:page) do
+      create_page(answer_type: "selection",
+                  answer_settings: { only_one_option: "true", selection_options: [{ name: "Option 1", value: "Option 1" }, { name: "Option 2", value: "Option 2" }] })
+    end
+    let(:new_input_data) do
+      super().merge(
+        question_text_cy: "",
+        hint_text_cy: "",
+        page_heading_cy: "",
+        guidance_markdown_cy: "",
+        condition_translations: [condition_translation],
+        selection_options_cy_attributes: {
+          "0" => { "id" => "0", "name_cy" => "" },
+          "1" => { "id" => "1", "name_cy" => "" },
+        },
+      )
+    end
+    let(:condition_translation) { Forms::WelshConditionTranslationInput.new(condition: condition, exit_page_heading_cy: "", exit_page_markdown_cy: "") }
+    let(:selection_options_cy) { welsh_page_translation_input.selection_options_cy.map(&:as_selection_option) }
+
+    it "returns true when all fields are blank" do
+      expect(welsh_page_translation_input.blanked?).to be true
+    end
+
+    context "when the welsh page fields are not all blank" do
+      let(:new_input_data) { super().merge(question_text_cy: "New question text") }
+
+      it "returns false" do
+        expect(welsh_page_translation_input.blanked?).to be false
+      end
+    end
+
+    context "when the condition is not blank" do
+      let(:condition_translation) { Forms::WelshConditionTranslationInput.new(condition: condition, exit_page_heading_cy: "Heading", exit_page_markdown_cy: "markdown") }
+
+      it "returns false" do
+        expect(welsh_page_translation_input.blanked?).to be false
+      end
+    end
+
+    context "when the selection optiosn are not all blank" do
+      let(:new_input_data) do
+        super().merge(
+          question_text_cy: "New question text",
+          condition_translations: [],
+          selection_options_cy_attributes: {
+            "0" => { "id" => "0", "name_cy" => "welsh option 1" },
+            "1" => { "id" => "1", "name_cy" => "" },
+          },
+        )
+      end
+
+      it "returns false" do
+        expect(welsh_page_translation_input.blanked?).to be false
+      end
+    end
+  end
 end

spec/input_objects/forms/welsh_selection_option_translation_input_spec.rb

@@ -93,4 +93,18 @@
       end
     end
   end
+
+  describe "#all_fields_empty?" do
+    it "returns false when fields are not empty" do
+      expect(welsh_selection_option_translation_input.all_fields_empty?).to be false
+    end
+
+    context "when the welsh selection option fields are all empty" do
+      let(:new_input_data) { { selection_option: selection_option_cy, page:, id: "1", name_cy: "" } }
+
+      it "returns true" do
+        expect(welsh_selection_option_translation_input.all_fields_empty?).to be true
+      end
+    end
+  end
 end

spec/input_objects/forms/welsh_translation_input_spec.rb

@@ -700,4 +700,38 @@ def build_empty_welsh_form
       end
     end
   end
+
+  describe "#blanked?" do
+    let(:page_translation) { Forms::WelshPageTranslationInput.new(page:) }
+    let(:new_input_data) do
+      {
+        form:,
+        mark_complete:,
+        name_cy: "",
+        what_happens_next_markdown_cy: "",
+        declaration_markdown_cy: "",
+        support_email_cy: "",
+        support_phone_cy: "",
+        support_url_cy: "",
+        support_url_text_cy: "",
+        privacy_policy_url_cy: "",
+        payment_url_cy: "",
+        page_translations: [page_translation],
+      }
+    end
+
+    context "when the welsh translation fields are all blank" do
+      it "returns true" do
+        expect(welsh_translation_input.blanked?).to be true
+      end
+    end
+
+    context "when the pages are not all blank" do
+      let(:page_translation) { Forms::WelshPageTranslationInput.new(page:, question_text_cy: "Some question text") }
+
+      it "returns false" do
+        expect(welsh_translation_input.blanked?).to be false
+      end
+    end
+  end
 end

spec/requests/forms/welsh_translation_controller_spec.rb

@@ -95,6 +95,7 @@
     end
 
     context "when 'Yes' is selected and all fields are empty" do
+      let(:condition_translations_attributes) { { "0" => { "id" => condition.id, exit_page_heading_cy: "", exit_page_markdown_cy: "" } } }
       let(:page_translations_attributes) { { "0" => { "id" => form.pages.first.id, question_text_cy: "", condition_translations_attributes: } } }
       let(:params) { { forms_welsh_translation_input: { form:, mark_complete:, name_cy: "", privacy_policy_url_cy: "", page_translations_attributes: } } }