Add spec to check that a group value is passed on update

Author: chao-xian

spec/features/group_form/move_form_spec.rb

@@ -36,6 +36,13 @@
       but_i_do_not_see_the_move_link
       and_i_cannot_visit_the_move_form_page
     end
+
+    scenario "not choosing a form" do
+      given_i_am_logged_in_as_an_organisation_admin
+      and_i_see_the_move_form_page
+      when_i_do_not_choose_a_group
+      then_i_see_an_error_message
+    end
   end
 
   def given_i_am_logged_in_as_an_organisation_admin
@@ -75,6 +82,8 @@ def then_i_see_the_move_form_page
     expect(page).to have_content(another_group.name)
   end
 
+  alias_method :and_i_see_the_move_form_page, :then_i_see_the_move_form_page
+
   def when_i_change_the_group
     choose(another_group.name)
     click_button "Continue"
@@ -92,4 +101,13 @@ def and_the_other_group_has_the_form
 
     expect(page).to have_content(form.name)
   end
+
+  def when_i_do_not_choose_a_group
+    click_button "Continue"
+  end
+
+  def then_i_see_an_error_message
+    expect(page).to have_content("There is a problem")
+    expect(page).to have_content("Select a group")
+  end
 end

spec/requests/group_forms_controller_spec.rb

@@ -72,10 +72,20 @@
     describe "PATCH /update" do
       let(:other_group) { create(:group, organisation: organisation_admin_user.organisation) }
 
-      it "redirects to the group" do
-        patch group_form_url(group, id: form.id), params: { forms_group_select: { group: other_group.id } }
+      context "with valid parameters" do
+        it "redirects to the group" do
+          patch group_form_url(group, id: form.id), params: { forms_group_select: { group: other_group.id } }
 
-        expect(response).to redirect_to(group_url(group))
+          expect(response).to redirect_to(group_url(group))
+        end
+      end
+
+      context "with missing form group parameter" do
+        it "re-renders the form with an error" do
+          patch group_form_url(group, id: form.id), params: { forms_group_select: { group: nil } }
+
+          expect(response).to have_http_status :see_other
+        end
       end
     end
   end