Change Tasklist show live logic

The tasklist should offer the link for making a form live even if the
Welsh hasn't been updated.

This only happens if there is an existing live Welsh form document.

This is to allow us to show a warning message to the user in place of
the make live task.

For the tasklist to show the task correctly, the task must have a status
which isn't :cannot_start. It must have a valid link and active must be
true.

The previous logic for producing the task used status from the TaskStatusService
and form#all_ready_for_live? to determine if the task should be active.

This commit changes the code to just use the TaskStatusService. This
allows us to show the link even if the form cannot be made live yet.

Form#all_ready_for_live? is still used in the controller code to prevent the
form actually being made live if it is not ready.

Author: thomasiles

app/services/form_task_list_service.rb

@@ -195,15 +195,22 @@ def make_form_live_section_tasks
         status: @task_statuses[:share_preview_status],
         active: @form.pages.any?,
       },
-      {
-        task_name: live_task_name,
-        path: live_path,
-        status: @task_statuses[:make_live_status],
-        active: @form.all_ready_for_live?,
-      },
+      make_live_task,
     ]
   end
 
+  def make_live_task
+    status = @task_statuses[:make_live_status]
+    can_make_form_live = status == :not_started
+
+    {
+      task_name: live_task_name,
+      path: can_make_form_live ? make_live_path(@form.id) : "",
+      status: status,
+      active: can_make_form_live,
+    }
+  end
+
   def live_title_name
     return I18n.t("forms.task_list_create.make_form_live_section.title") if @form.is_archived?
 
@@ -220,12 +227,6 @@ def live_task_name
     I18n.t("forms.task_list_#{create_or_edit}.make_form_live_section.make_live")
   end
 
-  def live_path
-    return "" unless @form.all_ready_for_live?
-
-    make_live_path(@form.id)
-  end
-
   def statuses_by_user
     statuses = @task_statuses
 

app/services/task_status_service.rb

@@ -3,8 +3,12 @@ def initialize(form:)
     @form = form
   end
 
-  def mandatory_tasks_completed?
-    incomplete_tasks.empty?
+  def mandatory_tasks_completed?(ignore_missing_welsh: false)
+    if ignore_missing_welsh
+      incomplete_tasks.reject { |task| task == :missing_welsh_translations }.empty?
+    else
+      incomplete_tasks.empty?
+    end
   end
 
   def incomplete_tasks
@@ -130,7 +134,12 @@ def make_live_status
   end
 
   def make_live_status_for_draft
-    mandatory_tasks_completed? ? :not_started : :cannot_start
+    # If the form has a live Welsh version, we ignore missing Welsh translations
+    # and show the make live task and link. In this case, we will show a warning
+    # message on the make live page asking the user to update the Welsh before
+    # the form can be made live.
+    ignore_missing_welsh = @form.live_welsh_form_document.present?
+    mandatory_tasks_completed?(ignore_missing_welsh:) ? :not_started : :cannot_start
   end
 
   def welsh_translations_invalid

spec/services/task_status_service_spec.rb

@@ -376,6 +376,18 @@
         expect(task_status_service.mandatory_tasks_completed?).to be true
       end
     end
+
+    context "when missing_welsh_translations is present" do
+      let(:form) { build(:form, :ready_for_live, :with_welsh_translation, welsh_completed: false) }
+
+      it "when ignore_missing_welsh is true returns true" do
+        expect(task_status_service.mandatory_tasks_completed?(ignore_missing_welsh: true)).to be true
+      end
+
+      it "without ignore_missing_welsh returns false" do
+        expect(task_status_service.mandatory_tasks_completed?).to be false
+      end
+    end
   end
 
   describe "#incomplete_tasks" do
@@ -469,6 +481,36 @@
       }
       expect(task_status_service.task_statuses).to eq expected_hash
     end
+
+    context "when the form has a live Welsh version" do
+      let(:form) { create(:form, :live_with_draft, :with_welsh_translation, welsh_completed: true) }
+
+      context "and an incomplete welsh translation" do
+        before do
+          # Add new content requiring Welsh translation
+          form.update!(declaration_markdown: "I declare this is correct", share_preview_completed: true)
+        end
+
+        it "make live_status is not_started" do
+          expect(task_status_service.task_statuses).to include(make_live_status: :not_started)
+        end
+      end
+    end
+
+    context "when the form does not have a live Welsh version" do
+      let(:form) { create(:form, :with_welsh_translation, welsh_completed: true) }
+
+      context "and an incomplete welsh translation" do
+        before do
+          # Add new content requiring Welsh translation
+          form.update!(declaration_markdown: "I declare this is correct", share_preview_completed: true)
+        end
+
+        it "make live_status is cannot_start" do
+          expect(task_status_service.task_statuses).to include(make_live_status: :cannot_start)
+        end
+      end
+    end
   end
 
   describe "#incomplete_email_tasks" do