Merge pull request #2566 from alphagov/ldeb-increase-selection-options-maximum

Increase maximum number of options for selection question

Author: lfdebrux

app/input_objects/pages/selection/base_options_input.rb

@@ -2,7 +2,7 @@ class Pages::Selection::BaseOptionsInput < BaseInput
   include LoggingHelper
 
   INCLUDE_NONE_OF_THE_ABOVE_OPTIONS = %w[yes yes_with_question no].freeze
-  MAXIMUM_CHOOSE_ONLY_ONE_OPTION = 1000
+  MAXIMUM_CHOOSE_ONLY_ONE_OPTION = 3000
   MAXIMUM_CHOOSE_MORE_THAN_ONE_OPTION = 30
 
   attr_accessor :include_none_of_the_above, :draft_question

app/views/pages/selection/bulk_options.html.erb

@@ -13,7 +13,7 @@
         <% if @bulk_options_input.only_one_option? %>
           <p><%= t("bulk_options.select_one_option") %></p>
           <p><%= t("bulk_options.longer_than_30_options") %></p>
-          <p><%= t("bulk_options.up_to_1000_options") %></p>
+          <p><%= t("bulk_options.up_to_3000_options") %></p>
         <% else %>
           <p><%= t("bulk_options.select_more_than_one_option") %></p>
           <p><%= t("bulk_options.up_to_30_options") %></p>

app/views/pages/selection/options.html.erb

@@ -19,7 +19,7 @@
       <div class="govuk-!-margin-bottom-8">
         <% if @selection_options_input.only_one_option? %>
           <p><%= t("selection_options.select_one_option") %></p>
-          <p><%= t("selection_options.up_to_1000_options") %></p>
+          <p><%= t("selection_options.up_to_3000_options") %></p>
         <% else %>
           <p><%= t("selection_options.select_more_than_one_option") %></p>
           <p><%= t("selection_options.up_to_30_options") %></p>

config/locales/en.yml

@@ -246,7 +246,7 @@ en:
     longer_than_30_options: If your list is longer than 30 options, people will be able to search and find the options by typing into an autocomplete box.
     select_more_than_one_option: People will be able to select one or more options from your list.
     select_one_option: People will be able to select one option from your list.
-    up_to_1000_options: You can have up to 1,000 options.
+    up_to_3000_options: You can have up to 3,000 options.
     up_to_30_options: You can have up to 30 options.
   cancel: Cancel
   contact_details:
@@ -834,7 +834,7 @@ en:
       pages_selection_type_input:
         only_one_option_options:
           'false': Your list can have up to 30 options
-          'true': Your list can have up to 1,000 options
+          'true': Your list can have up to 3,000 options
     label:
       account_name_input:
         name: Enter your full name
@@ -1808,7 +1808,7 @@ en:
     remove_html: Remove <span class="govuk-visually-hidden">option %{option_number}</span>
     select_more_than_one_option: People will be able to select one or more options from your list.
     select_one_option: People will be able to select one option from your list.
-    up_to_1000_options: You can have up to 1,000 options.
+    up_to_3000_options: You can have up to 3,000 options.
     up_to_30_options: You can have up to 30 options.
   selection_type:
     reduce_your_options_warning:

config/locales/input_objects/selection/bulk_options.yml

@@ -7,7 +7,7 @@ en:
           attributes:
             bulk_selection_options:
               maximum_choose_more_than_one_option: You cannot have more than 30 options
-              maximum_choose_only_one_option: You cannot have more than 1,000 options
+              maximum_choose_only_one_option: You cannot have more than 3,000 options
               minimum: Enter at least 2 options
               uniqueness: All your options must be unique. ‘%{duplicate}’ currently appears in your list more than once.
             include_none_of_the_above:

config/locales/input_objects/selection/options.yml

@@ -10,6 +10,6 @@ en:
             selection_options:
               blank: Add text for all of your options
               maximum_choose_more_than_one_option: You cannot have more than 30 options
-              maximum_choose_only_one_option: You cannot have more than 1,000 options
+              maximum_choose_only_one_option: You cannot have more than 3,000 options
               minimum: Enter at least 2 options
               uniqueness: All your options must be unique

spec/input_objects/pages/selection/bulk_options_input_spec.rb

@@ -26,20 +26,20 @@
     context "when only_one_option is true for the draft_question" do
       let(:only_one_option) { "true" }
 
-      it "is valid if there are between 2 and 1000 unique selection values" do
+      it "is valid if there are between 2 and 3000 unique selection values" do
         input.bulk_selection_options = (1..2).to_a.join("\n")
 
         expect(input).to be_valid
         expect(input.errors.full_messages_for(:bulk_selection_options)).to be_empty
 
-        input.bulk_selection_options = (1..1000).to_a.join("\n")
+        input.bulk_selection_options = (1..3000).to_a.join("\n")
 
         expect(input).to be_valid
         expect(input.errors.full_messages_for(:bulk_selection_options)).to be_empty
       end
 
-      it "is invalid if more than 1000 Bulk selection options are provided" do
-        input.bulk_selection_options = (1..1001).to_a.join("\n")
+      it "is invalid if more than 3000 Bulk selection options are provided" do
+        input.bulk_selection_options = (1..3001).to_a.join("\n")
         error_message = I18n.t("activemodel.errors.models.pages/selection/bulk_options_input.attributes.bulk_selection_options.maximum_choose_only_one_option")
         expect(input).not_to be_valid
 

spec/input_objects/pages/selection/options_input_spec.rb

@@ -66,16 +66,16 @@
       end
 
       context "when only_one_option is true for the draft_question" do
-        it "is invalid if more than 1000 selection options are provided" do
-          input.selection_options = (1..1001).to_a.map { |i| OpenStruct.new(name: i.to_s) }
+        it "is invalid if more than 3000 selection options are provided" do
+          input.selection_options = (1..3001).to_a.map { |i| OpenStruct.new(name: i.to_s) }
           error_message = I18n.t("activemodel.errors.models.pages/selection/options_input.attributes.selection_options.maximum_choose_only_one_option")
           expect(input).not_to be_valid
 
           expect(input.errors.full_messages_for(:selection_options)).to include("Selection options #{error_message}")
         end
 
-        it "is valid if there are 1000 unique selection values" do
-          input.selection_options = (1..1000).to_a.map { |i| { name: i.to_s } }
+        it "is valid if there are 3000 unique selection values" do
+          input.selection_options = (1..3000).to_a.map { |i| { name: i.to_s } }
 
           expect(input).to be_valid
         end

spec/support/shared_examples/pages_selection_base_options_input.rb

@@ -23,7 +23,7 @@
     context "when only_one_option is true" do
       let(:only_one_option) { "true" }
 
-      it { expect(input.maximum_options).to eq 1000 }
+      it { expect(input.maximum_options).to eq 3000 }
     end
 
     context "when only_one_option is false" do

spec/views/pages/selection/options.html.erb_spec.rb

@@ -60,27 +60,27 @@
         expect(rendered).not_to have_text("You can add up to")
       end
 
-      context "when there are fewer than 1000 options" do
-        let(:selection_options) { (1..999).to_a.map { |i| OpenStruct.new(name: i.to_s) } }
+      context "when there are fewer than 3000 options" do
+        let(:selection_options) { (1..2999).to_a.map { |i| OpenStruct.new(name: i.to_s) } }
 
         it "has an add another button" do
           expect(rendered).to have_button(I18n.t("selection_options.add_another"))
         end
 
         it "does not have inset text stating you cannot add more options" do
-          expect(rendered).not_to have_css(".govuk-inset-text", text: "You cannot add any more options as you have reached the maximum of 1000 options.")
+          expect(rendered).not_to have_css(".govuk-inset-text", text: "You cannot add any more options as you have reached the maximum of 3000 options.")
         end
       end
 
-      context "when there are 1000 options" do
-        let(:selection_options) { (1..1000).to_a.map { |i| OpenStruct.new(name: i.to_s) } }
+      context "when there are 3000 options" do
+        let(:selection_options) { (1..3000).to_a.map { |i| OpenStruct.new(name: i.to_s) } }
 
         it "does not have an add another button" do
           expect(rendered).not_to have_button(I18n.t("selection_options.add_another"))
         end
 
         it "has inset text stating you cannot add more options" do
-          expect(rendered).to have_css(".govuk-inset-text", text: "You cannot add any more options as you have reached the maximum of 1000 options.")
+          expect(rendered).to have_css(".govuk-inset-text", text: "You cannot add any more options as you have reached the maximum of 3000 options.")
         end
       end
     end