Only send org admin alerts if the feature flag is enabled

Author: stephencdaly

app/services/org_admin_alerts_service.rb

@@ -6,12 +6,15 @@ def initialize(form:, current_user:)
   end
 
   def form_made_live
+    return unless feature_enabled?
+
     @org_admins.each do |org_admin_user|
       form_made_live_email(to_email: org_admin_user.email).deliver_now
     end
   end
 
   def new_draft_form_created
+    return unless feature_enabled?
     return unless @form.group.active?
 
     @org_admins.each do |org_admin_user|
@@ -20,6 +23,8 @@ def new_draft_form_created
   end
 
   def draft_of_existing_form_created
+    return unless feature_enabled?
+
     @org_admins.each do |org_admin_user|
       draft_of_existing_form_created_email(to_email: org_admin_user.email).deliver_now
     end
@@ -74,4 +79,8 @@ def draft_of_existing_form_created_email(to_email:)
   def copied_from_form
     Form.find_by(id: @form.copied_from_id)
   end
+
+  def feature_enabled?
+    FeatureService.enabled?(:org_admin_alerts_enabled)
+  end
 end

spec/requests/forms/copy_controller_spec.rb

@@ -66,7 +66,7 @@
         expect(response).to redirect_to(form_path(Form.last.id))
       end
 
-      it "sends an email to the organisation admins" do
+      it "sends an email to the organisation admins", :feature_org_admin_alerts_enabled do
         post create_copy_form_path(id), params: { forms_copy_input: { name: "Copied Form", tag: "draft" } }
         expect(ActionMailer::Base.deliveries.count).to eq(1)
 

spec/requests/forms/make_live_controller_spec.rb

@@ -78,7 +78,7 @@
         expect(response).to render_template(:confirmation)
       end
 
-      it "sends an email to the organisation admins" do
+      it "sends an email to the organisation admins", :feature_org_admin_alerts_enabled do
         post(make_live_path(form_id: form.id), params: form_params)
         expect(ActionMailer::Base.deliveries.count).to eq(1)
 

spec/requests/forms_controller_spec.rb

@@ -12,7 +12,7 @@
     login_as user
   end
 
-  describe "#send_org_admin_alerts_if_draft_created" do
+  describe "#send_org_admin_alerts_if_draft_created", :feature_org_admin_alerts_enabled do
     before do
       post change_form_name_path(form_id: form.id), params: { forms_name_input: { name: "New name" } }
     end

spec/requests/group_forms_controller_spec.rb

@@ -131,7 +131,7 @@
         expect(response).to redirect_to(form_url(Form.last.id))
       end
 
-      it "sends an email to the organisation admins" do
+      it "sends an email to the organisation admins", :feature_org_admin_alerts_enabled do
         post group_forms_url(group), params: { forms_name_input: valid_attributes }
         expect(ActionMailer::Base.deliveries.count).to eq(1)
 

spec/services/org_admin_alerts_service_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe OrgAdminAlertsService do
+RSpec.describe OrgAdminAlertsService, :feature_org_admin_alerts_enabled do
   subject(:service) { described_class.new(form:, current_user:) }
 
   let(:organisation) { create(:organisation, :with_signed_mou) }
@@ -145,6 +145,15 @@
         expect(ActionMailer::Base.deliveries.size).to eq(0)
       end
     end
+
+    context "when the feature is disabled", feature_org_admin_alerts_enabled: false do
+      let(:previous_state) { :draft }
+
+      it "does not send any emails" do
+        service.form_made_live
+        expect(ActionMailer::Base.deliveries.size).to eq(0)
+      end
+    end
   end
 
   describe "#new_draft_form_created" do
@@ -206,6 +215,13 @@
         expect(ActionMailer::Base.deliveries.size).to eq(0)
       end
     end
+
+    context "when the feature is disabled", feature_org_admin_alerts_enabled: false do
+      it "does not send any emails" do
+        service.new_draft_form_created
+        expect(ActionMailer::Base.deliveries.size).to eq(0)
+      end
+    end
   end
 
   describe "#draft_of_existing_form_created" do
@@ -264,5 +280,14 @@
         expect(ActionMailer::Base.deliveries.size).to eq(0)
       end
     end
+
+    context "when the feature is disabled", feature_org_admin_alerts_enabled: false do
+      let(:form) { create(:form, :live_with_draft) }
+
+      it "does not send any emails" do
+        service.draft_of_existing_form_created
+        expect(ActionMailer::Base.deliveries.size).to eq(0)
+      end
+    end
   end
 end