Change calls to FeatureService with branch_routing

Every call to check if the branch_routing feature is enabled now
includes the current form's group.

This change will allow us to set the feature flag to be enabled per
group rather than for every environment.

Author: thomasiles

app/controllers/pages/secondary_skip_controller.rb

@@ -79,7 +79,7 @@ def delete_secondary_skip_input_params
   end
 
   def ensure_branch_routing_feature_enabled
-    raise ActionController::RoutingError, "branch_routing feature not enabled" unless Settings.features.branch_routing
+    raise ActionController::RoutingError, "branch_routing feature not enabled" unless FeatureService.new(group: current_form.group).enabled?(:branch_routing)
   end
 
   def ensure_page_has_skip_condition

app/presenters/route_summary_card_data_presenter.rb

@@ -64,7 +64,7 @@ def conditional_route_card(routing_condition, index)
   def default_route_card(index)
     continue_to_name = page.has_next_page? ? page_name(page.next_page) : end_page_name
 
-    actions = if FeatureService.enabled?(:branch_routing) && all_routes.find(&:secondary_skip?).present?
+    actions = if FeatureService.new(group: form.group).enabled?(:branch_routing) && all_routes.find(&:secondary_skip?).present?
                 [
                   edit_secondary_skip_link,
                   delete_secondary_skip_link,
@@ -101,7 +101,7 @@ def secondary_skip_rows
     secondary_skip = all_routes.find(&:secondary_skip?)
 
     if secondary_skip.blank?
-      if FeatureService.enabled?(:branch_routing)
+      if FeatureService.new(group: form.group).enabled?(:branch_routing)
         return [
           {
             key: { text: I18n.t("page_route_card.then") },

app/views/pages/conditions/_routing_options.html.erb

@@ -11,7 +11,7 @@
     <%= t("routing_page.body_routing_text") %>
   </p>
 
-  <% if FeatureService.enabled?(:branch_routing) %>
+  <% if FeatureService.new(group: form.group).enabled?(:branch_routing) %>
   <p>
     <%= t("routing_page.body_branching_text") %>
   </p>

app/views/pages/conditions/routing_page.html.erb

@@ -15,7 +15,7 @@
         <%= t("routing_page.body_routing_text") %>
       </p>
 
-      <% if FeatureService.enabled?(:branch_routing) %>
+      <% if FeatureService.new(group: form.group).enabled?(:branch_routing) %>
       <p>
         <%= t("routing_page.body_branching_text") %>
       </p>

spec/presenters/route_summary_card_data_presenter_spec.rb

@@ -25,6 +25,10 @@
 
   let(:next_page_routing_conditions) { [] }
 
+  before do
+    allow(form).to receive(:group).and_return(build(:group))
+  end
+
   describe ".call" do
     it "instantiates and returns a new instance" do
       service = described_class.call(form:, page: current_page, pages:)

spec/views/pages/conditions/routing_page.html.erb_spec.rb

@@ -14,6 +14,7 @@
 
     allow(view).to receive_messages(form_pages_path: "/forms/1/pages", routing_page_path: "/forms/1/new-condition", set_routing_page_path: "/forms/1/new-condition")
     allow(form).to receive_messages(qualifying_route_pages: pages, has_no_remaining_routes_available?: all_routes_created)
+    allow(form).to receive(:group).and_return(build(:group))
 
     render template: "pages/conditions/routing_page", locals: { form:, routing_page_input: }
   end