Merge pull request #1744 from alphagov/ldeb-add-page-conditions-service

Get list of page routes in routes controller show action

Author: lfdebrux

app/controllers/pages/routes_controller.rb

@@ -1,7 +1,9 @@
 class Pages::RoutesController < PagesController
   def show
     back_link_url = form_pages_path(current_form.id)
-    render locals: { current_form:, page:, pages: FormRepository.pages(current_form), back_link_url: }
+    pages = FormRepository.pages(current_form)
+    routes = PageRoutesService.new(form: current_form, pages:, page:).routes
+    render locals: { current_form:, page:, pages:, routes:, back_link_url: }
   end
 
   def delete

app/input_objects/pages/routes/delete_confirmation_input.rb

@@ -18,8 +18,8 @@ def to_partial_path
 private
 
   def delete_routes
-    all_form_routing_conditions = FormRepository.pages(form).flat_map(&:routing_conditions).compact_blank
-    page_routes = all_form_routing_conditions.select { |rc| rc.check_page_id == page.id }
+    pages = FormRepository.pages(form)
+    page_routes = PageRoutesService.new(form:, pages:, page:).routes
     page_routes.each do |rc|
       rc.prefix_options[:form_id] = form.id
       rc.prefix_options[:page_id] = rc.routing_page_id

app/presenters/route_summary_card_data_presenter.rb

@@ -3,36 +3,30 @@ class RouteSummaryCardDataPresenter
   include ActionView::Helpers::UrlHelper
   include GovukRailsCompatibleLinkHelper
 
-  attr_reader :form, :page, :pages
+  attr_reader :form, :pages, :page, :routes
 
-  class << self
-    def call(**args)
-      new(**args)
-    end
-  end
-
-  def initialize(form:, page:, pages:)
-    @page = page
-    @pages = pages
+  def initialize(form:, pages:, page:, routes:)
     @form = form
+    @pages = pages
+    @page = page
+    @routes = routes
   end
 
   def summary_card_data
     conditional_cards = conditional_route_cards
     conditional_cards + [default_route_card(conditional_cards.length + 1)]
   end
 
-  def all_routes
-    all_form_routing_conditions = pages.flat_map(&:routing_conditions).compact_blank
-    all_form_routing_conditions.select { |rc| rc.check_page_id == page.id }
+private
+
+  def secondary_skip
+    @secondary_skip ||= routes.find(&:secondary_skip?)
   end
 
   def conditional_routes
-    all_routes.select { |rc| rc.answer_value.present? }
+    routes.select { |rc| rc.answer_value.present? }
   end
 
-private
-
   def conditional_route_cards
     conditional_routes.map.with_index(1) { |routing_condition, index| conditional_route_card(routing_condition, index) }
   end
@@ -64,7 +58,7 @@ def conditional_route_card(routing_condition, index)
   def default_route_card(index)
     continue_to_name = page.has_next_page? ? page_name(page.next_page) : end_page_name
 
-    actions = if FeatureService.new(group: form.group).enabled?(:branch_routing) && all_routes.find(&:secondary_skip?).present?
+    actions = if FeatureService.new(group: form.group).enabled?(:branch_routing) && secondary_skip
                 [
                   edit_secondary_skip_link,
                   delete_secondary_skip_link,
@@ -98,9 +92,7 @@ def delete_secondary_skip_link
   end
 
   def secondary_skip_rows
-    secondary_skip = all_routes.find(&:secondary_skip?)
-
-    if secondary_skip.blank?
+    unless secondary_skip
       if FeatureService.new(group: form.group).enabled?(:branch_routing)
         return [
           {

app/services/page_conditions_service.rb

@@ -0,0 +1,21 @@
+class PageConditionsService
+  attr_reader :page
+
+  def initialize(form:, pages:, page:)
+    @form = form
+    @pages = pages
+    @page = page
+  end
+
+  def check_conditions
+    form_conditions.select { |condition| condition.check_page_id == page.id }
+  end
+
+  delegate :routing_conditions, to: :page
+
+private
+
+  def form_conditions
+    @form_conditions ||= @pages.flat_map(&:routing_conditions).compact_blank
+  end
+end

app/services/page_routes_service.rb

@@ -0,0 +1,23 @@
+class PageRoutesService
+  attr_reader :page
+
+  def initialize(form:, pages:, page:)
+    @form = form
+    @pages = pages
+    @page = page
+  end
+
+  def routes
+    check_conditions
+  end
+
+private
+
+  def check_conditions
+    page_conditions_service.check_conditions
+  end
+
+  def page_conditions_service
+    @page_conditions_service ||= PageConditionsService.new(form: @form, pages: @pages, page: @page)
+  end
+end

app/views/pages/routes/show.html.erb

@@ -16,7 +16,7 @@
           end;
       end %>
 
-      <% RouteSummaryCardDataPresenter.call(form: current_form, page:, pages:).summary_card_data.each do |card| %>
+      <% RouteSummaryCardDataPresenter.new(form: current_form, page:, pages:, routes:).summary_card_data.each do |card| %>
           <%= govuk_summary_list(**card) %>
       <% end %>
 

spec/presenters/route_summary_card_data_presenter_spec.rb

@@ -3,14 +3,18 @@
 describe RouteSummaryCardDataPresenter do
   include Capybara::RSpecMatchers
 
-  subject(:service) { described_class.new(form:, page: current_page, pages:) }
+  subject(:service) { described_class.new(form:, pages:, page: current_page, routes:) }
 
   let(:form) { build :form, id: 99, pages: }
 
   let(:current_page) do
     build(:page, id: 1, position: 1, question_text: "Current Question", next_page: next_page.id, routing_conditions:)
   end
 
+  let(:routes) do
+    PageRoutesService.new(form:, pages:, page: current_page).routes
+  end
+
   let(:next_page) do
     build(:page, id: 2, position: 2, question_text: "Next Question", routing_conditions: next_page_routing_conditions)
   end
@@ -29,13 +33,6 @@
     allow(form).to receive(:group).and_return(build(:group))
   end
 
-  describe ".call" do
-    it "instantiates and returns a new instance" do
-      service = described_class.call(form:, page: current_page, pages:)
-      expect(service).to be_an_instance_of(described_class)
-    end
-  end
-
   describe "#summary_card_data" do
     context "with conditional routes" do
       it "returns an array of route cards including conditional and default routes" do
@@ -142,36 +139,5 @@
         expect(result[0][:rows][0][:value][:text]).to eq("Check your answers before submitting")
       end
     end
-
-    describe "#all_routes" do
-      context "when no pages have conditions" do
-        let(:routing_conditions) { [] }
-
-        it "is an empty array when there are no matching conditions" do
-          expect(service.all_routes).to be_empty
-        end
-      end
-
-      context "when pages have conditions with matching check_page_ids" do
-        let(:pages) do
-          [
-            build(:page, id: 1, position: 1, question_text: "Current Question", next_page: next_page.id, routing_conditions: [
-              build(:condition, id: 1, routing_page_id: 1, check_page_id: 1, answer_value: "Yes", goto_page_id: 2, skip_to_end: false),
-            ]),
-            build(:page, id: 2, position: 2, question_text: "Next Question", routing_conditions: [
-              build(:condition, id: 1, routing_page_id: 2, check_page_id: 1, answer_value: nil, goto_page_id: nil, skip_to_end: true),
-            ]),
-            build(:page, id: 3, position: 3, question_text: "unrelated question", routing_conditions: [
-              build(:condition, id: 1, routing_page_id: 3, check_page_id: 3, answer_value: "Unrelated", goto_page_id: 5, skip_to_end: false),
-            ]),
-          ]
-        end
-
-        it "returns all condtions which match the check_page_id" do
-          expected_condtions = pages.first.routing_conditions + pages.second.routing_conditions
-          expect(service.all_routes).to match_array(expected_condtions)
-        end
-      end
-    end
   end
 end

spec/services/page_conditions_service_spec.rb

@@ -0,0 +1,57 @@
+require "rails_helper"
+
+RSpec.describe PageConditionsService do
+  subject(:page_conditions_service) do
+    described_class.new(form:, pages:, page:)
+  end
+
+  let(:form) do
+    build(:form)
+  end
+
+  include_context "with pages with routing"
+
+  describe "#check_conditions" do
+    subject(:check_conditions) { page_conditions_service.check_conditions }
+
+    context "when page has no routes" do
+      let(:page) { page_with_no_routes }
+
+      it { is_expected.to eq [] }
+    end
+
+    context "when page has no check conditions" do
+      let(:page) { end_of_a_secondary_skip }
+
+      it { is_expected.to eq [] }
+    end
+
+    context "when page has check conditions" do
+      let(:page) { page_with_skip_and_secondary_skip }
+
+      it { is_expected.to eq(page_with_skip_and_secondary_skip.routing_conditions + start_of_a_secondary_skip.routing_conditions) }
+    end
+  end
+
+  describe "#routing_conditions" do
+    subject(:routing_conditions) { page_conditions_service.routing_conditions }
+
+    context "when page has no routes" do
+      let(:page) { page_with_no_routes }
+
+      it { is_expected.to eq [] }
+    end
+
+    context "when page has no routing conditions" do
+      let(:page) { end_of_a_secondary_skip }
+
+      it { is_expected.to eq [] }
+    end
+
+    context "when page has routing conditions" do
+      let(:page) { page_with_skip_and_secondary_skip }
+
+      it { is_expected.to eq page.routing_conditions }
+    end
+  end
+end

spec/services/page_routes_service_spec.rb

@@ -0,0 +1,41 @@
+require "rails_helper"
+
+RSpec.describe PageRoutesService do
+  subject(:page_routes_service) do
+    described_class.new(form:, pages:, page:)
+  end
+
+  let(:form) do
+    build(:form)
+  end
+
+  include_context "with pages with routing"
+
+  describe "#routes" do
+    subject(:routes) { page_routes_service.routes }
+
+    context "when page has no routes" do
+      let(:page) { page_with_no_routes }
+
+      it { is_expected.to eq [] }
+    end
+
+    context "when page is at the end of a route" do
+      let(:page) { end_of_a_secondary_skip }
+
+      it { is_expected.to eq [] }
+    end
+
+    context "when page has a skip route" do
+      let(:page) { page_with_skip_route }
+
+      it { is_expected.to eq page.routing_conditions }
+    end
+
+    context "when page has a skip and secondary skip" do
+      let(:page) { page_with_skip_and_secondary_skip }
+
+      it { is_expected.to eq(page.routing_conditions + start_of_a_secondary_skip.routing_conditions) }
+    end
+  end
+end