Merge pull request #2586 from alphagov/check-feature-flag-for-daily-csv-content

Only show daily CSV content if the feature flag is enabled

Author: stephencdaly

app/views/forms/_made_live_form.html.erb

@@ -149,11 +149,13 @@
       <p><%= t(".how_you_get_completed_forms.submission_format.email.#{submission_format}_html") %></p>
     <% end %>
 
-    <h4 class="govuk-heading-s"><%= t(".how_you_get_completed_forms.daily_csv.title") %></h4>
-    <% if form_document.send_daily_submission_batch %>
-      <p><%= t(".how_you_get_completed_forms.daily_csv.enabled") %></p>
-    <% else %>
-      <p><%= t(".how_you_get_completed_forms.daily_csv.disabled") %></p>
+    <% if FeatureService.enabled?(:daily_submission_emails_enabled) %>
+      <h4 class="govuk-heading-s"><%= t(".how_you_get_completed_forms.daily_csv.title") %></h4>
+      <% if form_document.send_daily_submission_batch %>
+        <p><%= t(".how_you_get_completed_forms.daily_csv.enabled") %></p>
+      <% else %>
+        <p><%= t(".how_you_get_completed_forms.daily_csv.disabled") %></p>
+      <% end %>
     <% end %>
 
     <% if form_document.has_welsh_translation? %>

spec/views/forms/_made_live_form.html.erb_spec.rb

@@ -189,21 +189,29 @@
     end
   end
 
-  context "when send_daily_submission_batch is true" do
-    let(:send_daily_submission_batch) { true }
+  context "when the daily_submission_emails_enabled feature is enabled", :feature_daily_submission_emails_enabled do
+    context "when send_daily_submission_batch is true" do
+      let(:send_daily_submission_batch) { true }
 
-    it "tells the user they getting a daily CSV" do
-      expect(rendered).to have_css("h4", text: I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.title"))
-      expect(rendered).to include(I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.enabled"))
+      it "tells the user they getting a daily CSV" do
+        expect(rendered).to have_css("h4", text: I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.title"))
+        expect(rendered).to include(I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.enabled"))
+      end
     end
-  end
 
-  context "when send_daily_submission_batch is false" do
-    let(:send_daily_submission_batch) { false }
+    context "when send_daily_submission_batch is false" do
+      let(:send_daily_submission_batch) { false }
+
+      it "tells the user they have not opted to get a daily CSV" do
+        expect(rendered).to have_css("h4", text: I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.title"))
+        expect(rendered).to include(I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.disabled"))
+      end
+    end
+  end
 
-    it "tells the user they have not opted to get a daily CSV" do
-      expect(rendered).to have_css("h4", text: I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.title"))
-      expect(rendered).to include(I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.disabled"))
+  context "when the daily_submission_emails_enabled feature is disabled", feature_daily_submission_emails_enabled: false do
+    it "does not include the daily CSV section" do
+      expect(rendered).not_to have_css("h4", text: I18n.t("forms.made_live_form.how_you_get_completed_forms.daily_csv.title"))
     end
   end