Skip to content

Commit 5d98805

Browse files
committed
Fix review apps action
We unintentionally broke this flow by agreeing to actionlint's suggestions. Since it's mostly a stylistic issue, we can ignore it
1 parent 4d534c8 commit 5d98805

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

.github/workflows/review_apps_on_pr_change.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,11 @@ jobs:
6464
-no-color \
6565
-auto-approve
6666
67-
{
68-
echo "REVIEW_APP_URL=$(terraform output -raw review_app_url)" \
69-
"ADMIN_APP_URL=$(terraform output -raw admin_app_url)" \
70-
"ECS_CLUSTER_ID=$(terraform output -raw review_app_ecs_cluster_id)" \
71-
"ECS_SERVICE_NAME=$(terraform output -raw review_app_ecs_service_name)"
72-
} >> "$GITHUB_OUTPUT"
67+
# shellcheck disable=SC2129 # SC2129 is "mainly a stylistic issue" and it breaks our flow
68+
echo "REVIEW_APP_URL=$(terraform output -raw review_app_url)" >> "$GITHUB_OUTPUT"
69+
echo "ADMIN_APP_URL=$(terraform output -raw admin_app_url)" >> "$GITHUB_OUTPUT"
70+
echo "ECS_CLUSTER_ID=$(terraform output -raw review_app_ecs_cluster_id)" >> "$GITHUB_OUTPUT"
71+
echo "ECS_SERVICE_NAME=$(terraform output -raw review_app_ecs_service_name)" >> "$GITHUB_OUTPUT"
7372
7473
- name: Wait for AWS ECS deployments to finish
7574
run: |

0 commit comments

Comments
 (0)