Rename step#update! method

Bang methods usually indicate that they perform some sort of
"dangerous" operation, such as modifying the object in place or
raising an exception on failure. In this case, the `update!` method
is updating attributes on a question object, but not saving it
anywhere so the bang seems unnecessary and misleading.

The method name `update` didn't make much sense either, as "update"
would indicate that we are saving the object. Rename to
`assign_question_attributes` to better reflect the behaviour.

Author: stephencdaly

app/controllers/forms/page_controller.rb

@@ -17,7 +17,7 @@ def show
 
     def save
       page_params = params.fetch(:question, {}).permit(*@step.params)
-      @step.update!(page_params)
+      @step.assign_question_attributes(page_params)
 
       current_context.clear_submission_details if is_first_page?
 

app/controllers/forms/selection_none_of_the_above_controller.rb

@@ -11,7 +11,7 @@ def show
     def save
       page_params = params.fetch(:question, {}).permit(*@step.params)
       @step.question.with_none_of_the_above_selected
-      @step.update!(page_params)
+      @step.assign_question_attributes(page_params)
 
       if current_context.save_step(@step)
         unless mode.preview?

app/models/step.rb

@@ -48,7 +48,7 @@ def load_from_store(answer_store)
     self
   end
 
-  def update!(params)
+  def assign_question_attributes(params)
     question.assign_attributes(params)
   end
 

spec/lib/flow/context_spec.rb

@@ -42,7 +42,7 @@
         current_step = @context.find_or_create(@context.next_page_slug)
 
         input[:answers].each do |answer|
-          current_step.update!(answer)
+          current_step.assign_question_attributes(answer)
           @context.save_step(current_step)
           next_page_slug = current_step.next_page_slug
           break if next_page_slug.nil?
@@ -84,7 +84,7 @@
       # submit an answer to our page
       context1 = described_class.new(form:, store:)
       current_step = context1.find_or_create("1")
-      current_step.update!({ text: "This is a text answer" })
+      current_step.assign_question_attributes({ text: "This is a text answer" })
       context1.save_step(current_step)
 
       # change the page's answer_type to another value

spec/models/step_spec.rb

@@ -98,11 +98,11 @@
     end
   end
 
-  describe "#update!" do
+  describe "#assign_question_attributes" do
     it "assigns attributes" do
       params = { name: "New Name" }
       expect(question).to receive(:assign_attributes).with(params)
-      step.update!(params)
+      step.assign_question_attributes(params)
     end
   end