Use selection factory in selection_spec

We've defined the answer_settings in the factory to use Struct rather
than OpenStruct for the answer_settings to better mock the behaviour
of ActiveResouce::Base which raises a NoMethodError when trying to
access attributes that don't exist.

Use the factory so we don't need to define this behaviour in multiple
places.

Author: stephencdaly

spec/components/question/selection_component/view_spec.rb

@@ -22,12 +22,12 @@
     end
 
     context "when a 'None of the above' question is defined" do
-      let(:none_of_the_above_question_text_is_optional) { "true" }
+      let(:none_of_the_above_question_is_optional) { "true" }
       let(:question) do
         build(:single_selection_question,
               :with_none_of_the_above_question,
               none_of_the_above_question_text: "Enter another answer",
-              none_of_the_above_question_text_is_optional:)
+              none_of_the_above_question_is_optional:)
       end
 
       it "renders a conditional text field for the 'None of the above' option" do
@@ -41,7 +41,7 @@
       end
 
       context "when the 'None of the above' question is mandatory" do
-        let(:none_of_the_above_question_text_is_optional) { "false" }
+        let(:none_of_the_above_question_is_optional) { "false" }
 
         it "has the question text as the label for the field" do
           expect(page).to have_css("label[for='form-none-of-the-above-answer-field']", text: "Enter another answer")

spec/factories/models/question/selection.rb

@@ -30,12 +30,12 @@
     trait :with_none_of_the_above_question do
       transient do
         none_of_the_above_question_text { Faker::Lorem.question }
-        none_of_the_above_question_text_is_optional { "false" }
+        none_of_the_above_question_is_optional { "false" }
       end
       is_optional { true }
       none_of_the_above_question do
         Struct.new(:question_text, :is_optional)
-              .new(none_of_the_above_question_text, none_of_the_above_question_text_is_optional)
+              .new(none_of_the_above_question_text, none_of_the_above_question_is_optional)
       end
     end
 

spec/models/question/selection_spec.rb

@@ -1,19 +1,11 @@
 require "rails_helper"
 
 RSpec.describe Question::Selection, type: :model do
-  subject(:question) { described_class.new({}, options) }
+  subject(:question) { build :selection, only_one_option:, selection_options:, is_optional:, question_text: }
 
   let(:selection_options) { [OpenStruct.new({ name: "option 1" }), OpenStruct.new({ name: "option 2" })] }
   let(:is_optional) { false }
   let(:only_one_option) { "false" }
-  let(:answer_settings) { Struct.new(:only_one_option, :selection_options).new(only_one_option, selection_options) }
-  let(:options) do
-    {
-      is_optional:,
-      answer_settings:,
-      question_text:,
-    }
-  end
   let(:question_text) { Faker::Lorem.question }
 
   context "when the selection question is a checkbox" do
@@ -309,13 +301,13 @@
   end
 
   context "when there is a none of the above question configured" do
+    subject(:question) do
+      build(:selection, :with_none_of_the_above_question, only_one_option:, selection_options:, is_optional:,
+                                                          none_of_the_above_question_is_optional:)
+    end
+
     let(:is_optional) { true }
     let(:none_of_the_above_question_is_optional) { "true" }
-    let(:none_of_the_above_question) { Struct.new(:question_text, :is_optional).new(Faker::Lorem.sentence, none_of_the_above_question_is_optional) }
-    let(:answer_settings) do
-      Struct.new(:only_one_option, :selection_options, :none_of_the_above_question)
-            .new(only_one_option, selection_options, none_of_the_above_question)
-    end
 
     context "when there fewer than 31 selection options" do
       context "when only_one_option is false" do
@@ -491,12 +483,13 @@
     let(:is_optional) { true }
 
     context "when there is a none of the above question configured" do
-      let(:none_of_the_above_question) { Struct.new(:question_text, :is_optional).new(Faker::Lorem.sentence, "true") }
-      let(:answer_settings) do
-        Struct.new(:only_one_option, :selection_options, :none_of_the_above_question)
-              .new(only_one_option, selection_options, none_of_the_above_question)
+      subject(:question) do
+        build(:selection, :with_none_of_the_above_question, only_one_option:, selection_options:, is_optional:,
+                                                            none_of_the_above_question_is_optional:)
       end
 
+      let(:none_of_the_above_question_is_optional) { "true" }
+
       it "returns true" do
         expect(question.has_none_of_the_above_question?).to be true
       end
@@ -517,9 +510,12 @@
     end
 
     context "when the none_of_the_above_question has no question_text" do
-      let(:answer_settings) do
-        Struct.new(:only_one_option, :selection_options, :none_of_the_above_question)
-              .new(only_one_option, selection_options, Struct.new)
+      subject(:question) do
+        build(:selection,
+              is_optional:,
+              only_one_option:,
+              selection_options:,
+              none_of_the_above_question: Struct.new)
       end
 
       it "returns false" do