Rename GetByIDs() to ListByIDs()

Author: VojtechVitek

table.go

@@ -124,8 +124,8 @@ func (t *Table[T, PT, IDT]) GetByID(ctx context.Context, id IDT) (PT, error) {
 	return t.Get(ctx, sq.Eq{t.IDColumn: id}, []string{t.IDColumn})
 }
 
-// GetByIDs returns records by their IDs.
-func (t *Table[T, PT, IDT]) GetByIDs(ctx context.Context, ids []IDT) ([]PT, error) {
+// ListByIDs returns records by their IDs.
+func (t *Table[T, PT, IDT]) ListByIDs(ctx context.Context, ids []IDT) ([]PT, error) {
 	return t.List(ctx, sq.Eq{t.IDColumn: ids}, nil)
 }
 

tests/table_test.go

@@ -109,13 +109,13 @@ func TestTable(t *testing.T) {
 				require.Equal(t, article.DeletedAt, articleCheck.DeletedAt, "Article DeletedAt should match")
 			}
 
-			// Verify we can load all articles with .GetByIDs()
+			// Verify we can load all articles with .ListByIDs()
 			articleIDs := make([]uint64, len(articles))
 			for _, article := range articles {
 				articleIDs = append(articleIDs, article.ID)
 			}
-			articlesCheck, err := tx.Articles.GetByIDs(ctx, articleIDs)
-			require.NoError(t, err, "GetByIDs failed")
+			articlesCheck, err := tx.Articles.ListByIDs(ctx, articleIDs)
+			require.NoError(t, err, "ListByIDs failed")
 			require.Equal(t, len(articles), len(articlesCheck), "Number of articles should match")
 			for i, _ := range articlesCheck {
 				require.Equal(t, articles[i].ID, articlesCheck[i].ID, "Article ID should match")

tests/tables_test.go

@@ -21,7 +21,7 @@ type reviewsTable struct {
 	*pgkit.Table[Review, *Review, uint64]
 }
 
-func (w *reviewsTable) DequeueForProcessing(ctx context.Context, limit uint64) ([]*Review, error) {
+func (t *reviewsTable) DequeueForProcessing(ctx context.Context, limit uint64) ([]*Review, error) {
 	var dequeued []*Review
 	where := sq.Eq{
 		"status":     ReviewStatusPending,
@@ -31,7 +31,7 @@ func (w *reviewsTable) DequeueForProcessing(ctx context.Context, limit uint64) (
 		"created_at ASC",
 	}
 
-	err := w.LockForUpdates(ctx, where, orderBy, limit, func(reviews []*Review) {
+	err := t.LockForUpdates(ctx, where, orderBy, limit, func(reviews []*Review) {
 		now := time.Now().UTC()
 		for _, review := range reviews {
 			review.Status = ReviewStatusProcessing