Always override hashCode when you override equals

[HelgeStenstrom]

java-google-speech-api/src/main/java/com/goxr3plus/speech/util/Complex.java

Line 116 in 1863c92

public boolean equals(Complex other){

See Effective Java by Josua Bloch, item 11.

This will fail in Junit5, and probably in Junit 4 and TestNG too:
assertEquals(new Complex(1, 0), new Complex(1, 0));

because the expected (left) and actual (right) values have different hash codes.

IntelliJ can make a working hashCode method for you in seconds.

[goxr3plus]

Thank you so much, can you make a pull request in it :). ai am not sure if we need this library, it's for Speech Recognition... let me remember where i am using Complex, maybe for audio recognition from Microphone.

Google has released its own library which is a nightmare....

[HelgeStenstrom]

It's an upstream problem. I will not make a pull request.

[goxr3plus]

what that means :)? It's an upstream problem i don't understand :)

…

On Sun, Apr 28, 2019, 18:41 Helge Stenström ***@***.***> wrote: It's an upstream problem. I will not make a pull request. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3OFQFSDJWS6OMZ2BQDEADPSXARJANCNFSM4HI6FBXQ> .

[HelgeStenstrom]

My mistake; I thought (for some reason that I have forgotten) that this library was a re-packaging of some other library. So it's not an upstream problem.

I have not cloned or forked this project, so I let you do the method override.

In XR3Player, import com.darkprograms.speech.util is found in MicrophoneAnalyzer.java. It's used on line 171.

Which makes me confused again. Is that your library or not? Is it an upstream library for java-google-speech-api? Anyway, it has a Complex class which overrides equals, but not hashCode.

[goxr3plus]

I forked it from another project, now we are continuing completely alone, so whatever happens to the original project i forked we don't care, after all i think they don't support it anymore, that's why i forked it and continuing improving it in the first place.