fix: finding the correct alias declaration

Author: gp-pereira

lib/refactorex/refactor/alias.ex

@@ -74,15 +74,23 @@ defmodule Refactorex.Refactor.Alias do
   defp go_to_declaration(node, used_alias) do
     node
     |> Z.zip()
-    |> Z.find(fn
-      {:alias, _, [_, opts]} ->
-        Enum.any?(opts, &match?({{_, _, [:as]}, {_, _, [^used_alias]}}, &1))
-
-      {:__aliases__, _, aliases} ->
-        List.last(aliases) == used_alias
-
-      _ ->
-        false
+    |> Z.traverse_while(nil, fn
+      %{node: {:alias, _, [_, opts]}} = zipper, nil ->
+        if Enum.any?(opts, &match?({{_, _, [:as]}, {_, _, [^used_alias]}}, &1)),
+          do: {:halt, zipper, zipper},
+          else: {:cont, zipper, nil}
+
+      %{node: {:__aliases__, _, aliases}} = zipper, nil ->
+        if List.last(aliases) == used_alias,
+          do: {:halt, zipper, zipper},
+          else: {:cont, zipper, nil}
+
+      %{node: {:., _, [_, :{}]}} = zipper, nil ->
+        {:skip, zipper, nil}
+
+      zipper, nil ->
+        {:cont, zipper, nil}
     end)
+    |> elem(1)
   end
 end

test/refactor/alias/inline_alias_test.exs

@@ -187,6 +187,40 @@ defmodule Refactorex.Refactor.Alias.InlineAliasTest do
     )
   end
 
+  test "inlines nested namespace alias" do
+    assert_refactored(
+      InlineAlias,
+      """
+      defmodule Shop do
+        alias Shop.{
+          Cart,
+          Inventory.{Item},
+          Inventory
+        }
+
+        def restock(item_id, quantity) do
+        # v
+          Inventory.update_stock(item_id, quantity)
+        #         ^
+        end
+      end
+      """,
+      """
+      defmodule Shop do
+        alias Shop.{
+          Cart,
+          Inventory.{Item},
+          Inventory
+        }
+
+        def restock(item_id, quantity) do
+          Shop.Inventory.update_stock(item_id, quantity)
+        end
+      end
+      """
+    )
+  end
+
   test "ignores alias declaration" do
     assert_ignored(
       InlineAlias,