refactor: inlined update all references

Author: gp-pereira

lib/refactorex/refactor/variable.ex

@@ -21,22 +21,6 @@ defmodule Refactorex.Refactor.Variable do
   def was_declared?(zipper, variable),
     do: not Enum.empty?(find_all_references(zipper, variable))
 
-  def update_all_references(zipper, variable, updater_fn) do
-    references = find_all_references(zipper, variable)
-
-    zipper
-    |> Z.top()
-    |> Z.traverse(fn
-      %{node: {_, _, nil} = node} = zipper ->
-        if Enum.member?(references, node),
-          do: Z.replace(zipper, updater_fn.(node)),
-          else: zipper
-
-      zipper ->
-        zipper
-    end)
-  end
-
   def find_all_references(zipper, {name, _, _} = variable) do
     zipper
     |> Z.topmost_root()

lib/refactorex/refactor/variable/rename_variable.ex

@@ -23,10 +23,18 @@ defmodule Refactorex.Refactor.Variable.RenameVariable do
   end
 
   def refactor(%{node: variable} = zipper, _) do
-    Variable.update_all_references(
-      zipper,
-      variable,
-      fn {_, meta, nil} -> {placeholder(), meta, nil} end
-    )
+    all_references = Variable.find_all_references(zipper, variable)
+
+    zipper
+    |> Z.top()
+    |> Z.traverse(fn %{node: node} = zipper ->
+      if Enum.member?(all_references, node) do
+        Z.update(zipper, fn {_, meta, nil} ->
+          {placeholder(), meta, nil}
+        end)
+      else
+        zipper
+      end
+    end)
   end
 end