Skip to content

Commit 3eea1b5

Browse files
Exceptions should be derived from Exception and not BaseException
"The base class for all built-in exceptions. It is not meant to be directly inherited by user-defined classes (for that, use Exception)." https://docs.python.org/3/library/exceptions.html#BaseException
1 parent 70ddd43 commit 3eea1b5

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
author, email = re.match(r'^(.*) <(.*)>$', metadata['author']).groups()
3434

3535

36-
class MissingFile(BaseException):
36+
class MissingFile(Exception):
3737
pass
3838

3939

src/gpodder/plugins/itunes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
logger = logging.getLogger(__name__)
2929

30-
class ITunesFeedException(BaseException):
30+
class ITunesFeedException(Exception):
3131
pass
3232

3333

src/gpodder/plugins/vimeo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
FILEFORMAT_RANKING = ['mobile', 'sd', 'hd']
3939

4040

41-
class VimeoError(BaseException):
41+
class VimeoError(Exception):
4242
pass
4343

4444

0 commit comments

Comments
 (0)