Skip to content

Commit 697cb20

Browse files
committed
Review pass 1
1 parent 0ff6093 commit 697cb20

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

src/index.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const VOID_ELEMENTS = /^(area|base|br|col|embed|hr|img|input|link|meta|param|sou
1919

2020
const DASHED_ATTRS = /^(acceptC|httpE|(clip|color|fill|font|glyph|marker|stop|stroke|text|vert)[A-Z])/;
2121
const CAMEL_ATTRS = /^(isP|viewB)/;
22-
const COLON_ATTRS = /^(xlink|xml|xmlns)[A-Z]/;
22+
const COLON_ATTRS = /^(xlink|xml|xmlns)([A-Z])/;
2323

2424
const CAPITAL_REGEXP = /([A-Z])/g;
2525

@@ -287,7 +287,7 @@ function _renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
287287
// <textarea value="a&b"> --> <textarea>a&amp;b</textarea>
288288
propChildren = v;
289289
} else if ((v || v === 0 || v === '') && typeof v !== 'function') {
290-
name = getAttributeNameInHtmlCase(name);
290+
name = transformAttributeName(name);
291291

292292
if (v === true || v === '') {
293293
v = name;
@@ -306,7 +306,6 @@ function _renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
306306
s += ` selected`;
307307
}
308308
}
309-
310309
s += ` ${name}="${encodeEntities(v)}"`;
311310
}
312311
}
@@ -436,14 +435,16 @@ function getFallbackComponentName(component) {
436435
return name;
437436
}
438437

439-
function getAttributeNameInHtmlCase(name) {
438+
function transformAttributeName(name) {
440439
if (CAMEL_ATTRS.test(name)) return name;
441440

442-
if (DASHED_ATTRS.test(name))
443-
return name.replace(CAPITAL_REGEXP, (w) => '-' + w.toLowerCase());
441+
if (DASHED_ATTRS.test(name)) {
442+
return name.replace(CAPITAL_REGEXP, '-$1').toLowerCase();
443+
}
444444

445-
if (COLON_ATTRS.test(name))
446-
return name.replace(CAPITAL_REGEXP, (w) => ':' + w.toLowerCase());
445+
if (COLON_ATTRS.test(name)) {
446+
return name.replace(CAPITAL_REGEXP, ':$1').toLowerCase();
447+
}
447448

448449
return name.toLowerCase();
449450
}

0 commit comments

Comments
 (0)