small leaderboard_db improvements

Author: ngc92

src/libkernelbot/leaderboard_db.py

@@ -142,31 +142,21 @@ def update_leaderboard(
     ):
         task = definition.task
         try:
+            lb_id = self.get_leaderboard_id(name)
             self.cursor.execute(
                 """
                 UPDATE leaderboard.leaderboard
                 SET deadline = %s, task = %s, description = %s
-                WHERE name = %s;
+                WHERE id = %s;
                 """,
                 (
                     deadline.astimezone(datetime.timezone.utc),
                     task.to_str(),
                     definition.description,
-                    name,
+                    lb_id,
                 ),
             )
 
-            self.cursor.execute(
-                """
-                SELECT id
-                FROM leaderboard.leaderboard
-                WHERE name = %s
-                """,
-                (name,),
-            )
-
-            lb_id = self.cursor.fetchone()[0]
-
             # replace templates
             self.cursor.execute(
                 """
@@ -237,8 +227,13 @@ def delete_leaderboard(self, leaderboard_name: str, force: bool = False):
             self.name_cache.invalidate()  # Invalidate autocomplete cache
         except psycopg2.Error as e:
             self.connection.rollback()
+            if isinstance(e, psycopg2.errors.ForeignKeyViolation):
+                raise KernelBotError(
+                    f"Could not delete leaderboard `{leaderboard_name}` with existing submissions."
+                ) from e
+
             logger.exception("Could not delete leaderboard %s.", leaderboard_name, exc_info=e)
-            raise KernelBotError(f"Could not delete leaderboard {leaderboard_name}.") from e
+            raise KernelBotError(f"Could not delete leaderboard `{leaderboard_name}`.") from e
 
     def create_submission(
         self,
@@ -428,7 +423,7 @@ def get_leaderboard_names(self, active_only: bool = False) -> list[str]:
     def get_leaderboards(self) -> list["LeaderboardItem"]:
         self.cursor.execute(
             """
-            SELECT id, name, deadline, task, creator_id, forum_id, description
+            SELECT id, name, deadline, task, creator_id, forum_id, description, secret_seed
             FROM leaderboard.leaderboard
             """
         )
@@ -452,6 +447,7 @@ def get_leaderboards(self) -> list["LeaderboardItem"]:
                     creator_id=lb[4],
                     forum_id=lb[5],
                     description=lb[6],
+                    secret_seed=lb[7],
                 )
             )