fix: #378 unit test, showing the issue resolved

fix: Random demo, when webgl or webgl2 not available, use try to keep demo running

Author: robertleeplummerjr

examples/random.html

@@ -14,18 +14,24 @@ <h2>WebGL2 Random</h2>
 </body>
 <script src="../bin/gpu-browser.js"></script>
 <script>
-  const cpu = new GPU({
+  let cpu, webGL, webGL2;
+
+  cpu = new GPU({
     mode: 'cpu',
     canvas: document.getElementById('cpu-random-output')
   });
-  const webGL = new GPU({
-    mode: 'webgl',
-    canvas: document.getElementById('web-gl-random-output')
-  });
-  const webGL2 = new GPU({
-    mode: 'webgl2',
-    canvas: document.getElementById('web-gl2-random-output')
-  });
+  try {
+    webGL = new GPU({
+      mode: 'webgl',
+      canvas: document.getElementById('web-gl-random-output')
+    });
+  } catch (e) {}
+  try {
+    webGL2 = new GPU({
+      mode: 'webgl2',
+      canvas: document.getElementById('web-gl2-random-output')
+    });
+  } catch (e) {}
 
   function drawRandomFunction() {
     this.color(Math.random(), Math.random(), Math.random());
@@ -35,13 +41,17 @@ <h2>WebGL2 Random</h2>
     .setGraphical(true)
     .setOutput([100, 100]);
 
-  const webGLDrawRandom = webGL.createKernel(drawRandomFunction)
-    .setGraphical(true)
-    .setOutput([100, 100]);
+  const webGLDrawRandom = webGL
+    ? webGL.createKernel(drawRandomFunction)
+      .setGraphical(true)
+      .setOutput([100, 100])
+    : () => {};
 
-  const webGL2DrawRandom = webGL2.createKernel(drawRandomFunction)
-    .setGraphical(true)
-    .setOutput([100, 100]);
+  const webGL2DrawRandom = webGL2
+    ? webGL2.createKernel(drawRandomFunction)
+      .setGraphical(true)
+      .setOutput([100, 100])
+    : () => {};
 
   function draw() {
     cpuDrawRandom();

test/all.html

@@ -151,6 +151,7 @@
 <script type="module" src="issues/349-division-by-factors-of-3.js"></script>
 <script type="module" src="issues/357-modulus-issue.js"></script>
 <script type="module" src="issues/359-addfunction-params-wrong.js"></script>
+<script type="module" src="issues/378-only-first-iteration.js"></script>
 <script type="module" src="issues/382-bad-constant.js"></script>
 <script type="module" src="issues/390-thread-assignment.js"></script>
 <script type="module" src="issues/396-combine-kernels-example.js"></script>

test/issues/378-only-first-iteration.js

@@ -0,0 +1,37 @@
+const { assert, skip, test, module: describe, only } = require('qunit');
+const { GPU } = require('../../src');
+
+describe('issue #378');
+
+function testOnlyFirstIterationSafari(mode) {
+  const gpu = new GPU({ mode: mode });
+  const conflictingName = 0.4;
+  const kernel = gpu.createKernel(function(iter) {
+    let sum = 0;
+    for(let i=2; i<iter; i++) {
+      sum = sum + i;
+    }
+    return 2*sum ; //+ this.thread.x;
+  })
+    .setOutput([10])
+    .setConstants({
+      conflictingName: conflictingName
+    });
+
+  const result = kernel(5);
+
+  assert.deepEqual(Array.from(result), [18,18,18,18,18,18,18,18,18,18]);
+  gpu.destroy();
+}
+
+(GPU.isWebGLSupported ? test : skip)('Issue #378 - only first iteration safari webgl', () => {
+  testOnlyFirstIterationSafari('webgl');
+});
+
+(GPU.isWebGL2Supported ? test : skip)('Issue #378 - only first iteration safari webgl2', () => {
+  testOnlyFirstIterationSafari('webgl2');
+});
+
+(GPU.isHeadlessGLSupported ? test : skip)('Issue #378 - only first iteration safari headlessgl', () => {
+  testOnlyFirstIterationSafari('headlessgl');
+});