fix: Don't call kernel.updateTextureArgumentRefs if kernel is mutable

robertleeplummerjr · robertleeplummerjr · commit b1af9b3c4c77 · 2020-03-12T07:40:15.000-04:00
diff --git a/dist/gpu-browser-core.js b/dist/gpu-browser-core.js
@@ -4,8 +4,8 @@
  *
  * GPU Accelerated JavaScript
  *
- * @version 2.8.0
- * @date Wed Mar 11 2020 07:33:36 GMT-0400 (Eastern Daylight Time)
+ * @version 2.8.1
+ * @date Thu Mar 12 2020 07:32:27 GMT-0400 (Eastern Daylight Time)
  *
  * @license MIT
  * The MIT License
@@ -9160,11 +9160,11 @@ class WebGLKernelValueMemoryOptimizedNumberTexture extends WebGLKernelArray {
       return;
     }
     if (this.checkContext && inputTexture.context !== this.context) {
-      throw new Error(`Value ${this.name} (${this.type }) must be from same context`);
+      throw new Error(`Value ${this.name} (${this.type}) must be from same context`);
     }
 
-    const { context: gl, kernel } = this;
-    if (kernel.pipeline) {
+    const { kernel, context: gl } = this;
+    if (kernel.pipeline && kernel.immutable) {
       kernel.updateTextureArgumentRefs(this, inputTexture);
     }
 
@@ -9220,7 +9220,7 @@ class WebGLKernelValueNumberTexture extends WebGLKernelArray {
     }
 
     const { kernel, context: gl } = this;
-    if (kernel.pipeline) {
+    if (kernel.pipeline && kernel.immutable) {
       kernel.updateTextureArgumentRefs(this, inputTexture);
     }
 
@@ -12577,7 +12577,7 @@ class WebGL2Kernel extends WebGLKernel {
     }
   }
   getInternalFormat() {
-    const { context: gl, optimizeFloatMemory, pipeline, precision } = this;
+    const { context: gl } = this;
 
     if (this.precision === 'single') {
       if (this.pipeline) {
diff --git a/dist/gpu-browser-core.min.js b/dist/gpu-browser-core.min.js
diff --git a/dist/gpu-browser.js b/dist/gpu-browser.js
@@ -4,8 +4,8 @@
  *
  * GPU Accelerated JavaScript
  *
- * @version 2.8.0
- * @date Wed Mar 11 2020 07:33:35 GMT-0400 (Eastern Daylight Time)
+ * @version 2.8.1
+ * @date Thu Mar 12 2020 07:32:26 GMT-0400 (Eastern Daylight Time)
  *
  * @license MIT
  * The MIT License
@@ -13613,11 +13613,11 @@ class WebGLKernelValueMemoryOptimizedNumberTexture extends WebGLKernelArray {
       return;
     }
     if (this.checkContext && inputTexture.context !== this.context) {
-      throw new Error(`Value ${this.name} (${this.type }) must be from same context`);
+      throw new Error(`Value ${this.name} (${this.type}) must be from same context`);
     }
 
-    const { context: gl, kernel } = this;
-    if (kernel.pipeline) {
+    const { kernel, context: gl } = this;
+    if (kernel.pipeline && kernel.immutable) {
       kernel.updateTextureArgumentRefs(this, inputTexture);
     }
 
@@ -13673,7 +13673,7 @@ class WebGLKernelValueNumberTexture extends WebGLKernelArray {
     }
 
     const { kernel, context: gl } = this;
-    if (kernel.pipeline) {
+    if (kernel.pipeline && kernel.immutable) {
       kernel.updateTextureArgumentRefs(this, inputTexture);
     }
 
@@ -17030,7 +17030,7 @@ class WebGL2Kernel extends WebGLKernel {
     }
   }
   getInternalFormat() {
-    const { context: gl, optimizeFloatMemory, pipeline, precision } = this;
+    const { context: gl } = this;
 
     if (this.precision === 'single') {
       if (this.pipeline) {
diff --git a/dist/gpu-browser.min.js b/dist/gpu-browser.min.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gpu.js",
-  "version": "2.8.0",
+  "version": "2.8.1",
   "description": "GPU Accelerated JavaScript",
   "engines": {
     "node": ">=8.0.0"
diff --git a/src/backend/web-gl/kernel-value/memory-optimized-number-texture.js b/src/backend/web-gl/kernel-value/memory-optimized-number-texture.js
@@ -37,11 +37,11 @@ class WebGLKernelValueMemoryOptimizedNumberTexture extends WebGLKernelArray {
       return;
     }
     if (this.checkContext && inputTexture.context !== this.context) {
-      throw new Error(`Value ${this.name} (${this.type }) must be from same context`);
+      throw new Error(`Value ${this.name} (${this.type}) must be from same context`);
     }
 
-    const { context: gl, kernel } = this;
-    if (kernel.pipeline) {
+    const { kernel, context: gl } = this;
+    if (kernel.pipeline && kernel.immutable) {
       kernel.updateTextureArgumentRefs(this, inputTexture);
     }
 
diff --git a/src/backend/web-gl/kernel-value/number-texture.js b/src/backend/web-gl/kernel-value/number-texture.js
@@ -44,7 +44,7 @@ class WebGLKernelValueNumberTexture extends WebGLKernelArray {
     }
 
     const { kernel, context: gl } = this;
-    if (kernel.pipeline) {
+    if (kernel.pipeline && kernel.immutable) {
       kernel.updateTextureArgumentRefs(this, inputTexture);
     }
 
diff --git a/src/backend/web-gl2/kernel.js b/src/backend/web-gl2/kernel.js
@@ -251,7 +251,7 @@ class WebGL2Kernel extends WebGLKernel {
     }
   }
   getInternalFormat() {
-    const { context: gl, optimizeFloatMemory, pipeline, precision } = this;
+    const { context: gl } = this;
 
     if (this.precision === 'single') {
       if (this.pipeline) {

Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,8 @@`
`4`	`4`	`*`
`5`	`5`	`* GPU Accelerated JavaScript`
`6`	`6`	`*`
`7`		`- * @version 2.8.0`
`8`		`- * @date Wed Mar 11 2020 07:33:36 GMT-0400 (Eastern Daylight Time)`
	`7`	`+ * @version 2.8.1`
	`8`	`+ * @date Thu Mar 12 2020 07:32:27 GMT-0400 (Eastern Daylight Time)`
`9`	`9`	`*`
`10`	`10`	`* @license MIT`
`11`	`11`	`* The MIT License`
`@@ -9160,11 +9160,11 @@ class WebGLKernelValueMemoryOptimizedNumberTexture extends WebGLKernelArray {`
`9160`	`9160`	`return;`
`9161`	`9161`	`}`
`9162`	`9162`	`if (this.checkContext && inputTexture.context !== this.context) {`
`9163`		- throw new Error(`Value ${this.name} (${this.type }) must be from same context`);
	`9163`	+ throw new Error(`Value ${this.name} (${this.type}) must be from same context`);
`9164`	`9164`	`}`
`9165`	`9165`
`9166`		`- const { context: gl, kernel } = this;`
`9167`		`- if (kernel.pipeline) {`
	`9166`	`+ const { kernel, context: gl } = this;`
	`9167`	`+ if (kernel.pipeline && kernel.immutable) {`
`9168`	`9168`	`kernel.updateTextureArgumentRefs(this, inputTexture);`
`9169`	`9169`	`}`
`9170`	`9170`
`@@ -9220,7 +9220,7 @@ class WebGLKernelValueNumberTexture extends WebGLKernelArray {`
`9220`	`9220`	`}`
`9221`	`9221`
`9222`	`9222`	`const { kernel, context: gl } = this;`
`9223`		`- if (kernel.pipeline) {`
	`9223`	`+ if (kernel.pipeline && kernel.immutable) {`
`9224`	`9224`	`kernel.updateTextureArgumentRefs(this, inputTexture);`
`9225`	`9225`	`}`
`9226`	`9226`
`@@ -12577,7 +12577,7 @@ class WebGL2Kernel extends WebGLKernel {`
`12577`	`12577`	`}`
`12578`	`12578`	`}`
`12579`	`12579`	`getInternalFormat() {`
`12580`		`- const { context: gl, optimizeFloatMemory, pipeline, precision } = this;`
	`12580`	`+ const { context: gl } = this;`
`12581`	`12581`
`12582`	`12582`	`if (this.precision === 'single') {`
`12583`	`12583`	`if (this.pipeline) {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "gpu.js",`
`3`		`- "version": "2.8.0",`
	`3`	`+ "version": "2.8.1",`
`4`	`4`	`"description": "GPU Accelerated JavaScript",`
`5`	`5`	`"engines": {`
`6`	`6`	`"node": ">=8.0.0"`
Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,11 @@ class WebGLKernelValueMemoryOptimizedNumberTexture extends WebGLKernelArray {`
`37`	`37`	`return;`
`38`	`38`	`}`
`39`	`39`	`if (this.checkContext && inputTexture.context !== this.context) {`
`40`		- throw new Error(`Value ${this.name} (${this.type }) must be from same context`);
	`40`	+ throw new Error(`Value ${this.name} (${this.type}) must be from same context`);
`41`	`41`	`}`
`42`	`42`
`43`		`- const { context: gl, kernel } = this;`
`44`		`- if (kernel.pipeline) {`
	`43`	`+ const { kernel, context: gl } = this;`
	`44`	`+ if (kernel.pipeline && kernel.immutable) {`
`45`	`45`	`kernel.updateTextureArgumentRefs(this, inputTexture);`
`46`	`46`	`}`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class WebGLKernelValueNumberTexture extends WebGLKernelArray {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`const { kernel, context: gl } = this;`
`47`		`- if (kernel.pipeline) {`
	`47`	`+ if (kernel.pipeline && kernel.immutable) {`
`48`	`48`	`kernel.updateTextureArgumentRefs(this, inputTexture);`
`49`	`49`	`}`
`50`	`50`
Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ class WebGL2Kernel extends WebGLKernel {`
`251`	`251`	`}`
`252`	`252`	`}`
`253`	`253`	`getInternalFormat() {`
`254`		`- const { context: gl, optimizeFloatMemory, pipeline, precision } = this;`
	`254`	`+ const { context: gl } = this;`
`255`	`255`
`256`	`256`	`if (this.precision === 'single') {`
`257`	`257`	`if (this.pipeline) {`