Skip to content

Commit dd6665a

Browse files
fix: #471, was already fixed, but added unit test anyway
fix: Rename describe for conformity
1 parent 1aadb2f commit dd6665a

File tree

6 files changed

+43
-4
lines changed

6 files changed

+43
-4
lines changed

test/all.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@
163163
<script type="module" src="issues/401-cpu-canvas-check.js"></script>
164164
<script type="module" src="issues/410-if-statement.js"></script>
165165
<script type="module" src="issues/422-warnings.js"></script>
166+
<script type="module" src="issues/471-canvas-issue.js"></script>
166167
<script type="module" src="issues/472-compilation-issue.js"></script>
167168
<script type="module" src="issues/473-4-pixels.js"></script>
168169
</body>

test/issues/396-combine-kernels-example.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const { assert, skip, test, module: describe } = require('qunit');
22
const { GPU } = require('../../src');
33

4-
describe('issues #396 - combine kernels example');
4+
describe('issue #396 - combine kernels example');
55

66
function combineKernelsExample(mode) {
77
const gpu = new GPU({ mode });

test/issues/410-if-statement.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const { assert, skip, test, module: describe } = require('qunit');
22
const { GPU } = require('../../src');
33

4-
describe('issues #410 - if statement when unsigned on NVidia');
4+
describe('issue #410 - if statement when unsigned on NVidia');
55

66
function ifStatement(mode) {
77
const gpu = new GPU({ mode });

test/issues/422-warnings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const { assert, skip, test, module: describe } = require('qunit');
22
const { GPU } = require('../../src');
33

4-
describe('issues #422 - warnings');
4+
describe('issue #422 - warnings');
55

66
function warnings(mode) {
77
const gpu = new GPU({ mode });

test/issues/471-canvas-issue.js

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
const { assert, skip, test, module: describe } = require('qunit');
2+
const { GPU } = require('../../src');
3+
4+
describe('issue #471 - canvas issue');
5+
6+
function testCanvasIssue(mode) {
7+
const gpu = new GPU({mode});
8+
const render = gpu
9+
.createKernel(function () {
10+
this.color(0, 0, 0, 1);
11+
})
12+
.setOutput([200, 200])
13+
.setGraphical(true);
14+
15+
render();
16+
17+
assert.equal(render.canvas.constructor.name, 'HTMLCanvasElement');
18+
}
19+
20+
(GPU.isCanvasSupported ? test : skip)('auto', () => {
21+
testCanvasIssue();
22+
});
23+
24+
(GPU.isCanvasSupported ? test : skip)('gpu', () => {
25+
testCanvasIssue('gpu');
26+
});
27+
28+
(GPU.isWebGLSupported ? test : skip)('webgl', () => {
29+
testCanvasIssue('webgl');
30+
});
31+
32+
(GPU.isWebGL2Supported ? test : skip)('webgl2', () => {
33+
testCanvasIssue('webgl2');
34+
});
35+
36+
(GPU.isCanvasSupported ? test : skip)('cpu', () => {
37+
testCanvasIssue('cpu');
38+
});

test/issues/472-compilation-issue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const { assert, skip, test, module: describe, only } = require('qunit');
22
const { GPU } = require('../../src');
33

4-
describe('issues #472 - compilation issue');
4+
describe('issue #472 - compilation issue');
55

66
function testCompilationIssue(mode) {
77
const gpu = new GPU({ mode });

0 commit comments

Comments
 (0)