Skip to content

Commit 2be423e

Browse files
committed
refactor(amd): safe hsa detection
Signed-off-by: thxCode <[email protected]>
1 parent 30f3e75 commit 2be423e

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

gpustack_runtime/detector/amd.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def detect(self) -> Devices | None:
108108
dev_uuid = f"GPU-{(asic_serial[2:]).lower()}"
109109
else:
110110
dev_uuid = f"GPU-{pyrocmsmi.rsmi_dev_unique_id_get(dev_idx)[2:]}"
111-
dev_hsa_agent = hsa_agents.get(dev_uuid)
111+
dev_hsa_agent = hsa_agents.get(dev_uuid, pyhsa.Agent())
112112

113113
dev_gpu_driver_info = pyamdsmi.amdsmi_get_gpu_driver_info(dev)
114114
dev_driver_ver = dev_gpu_driver_info.get("driver_version")

gpustack_runtime/detector/hygon.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def detect(self) -> Devices | None:
108108
dev_index = dev_idx
109109

110110
dev_uuid = f"GPU-{pyrocmsmi.rsmi_dev_unique_id_get(dev_idx)[2:]}"
111-
dev_hsa_agent = hsa_agents.get(dev_uuid)
111+
dev_hsa_agent = hsa_agents.get(dev_uuid, pyhsa.Agent())
112112

113113
dev_name = dev_hsa_agent.name
114114
if not dev_name:

gpustack_runtime/detector/pyhsa/__init__.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -446,13 +446,13 @@ def has_agent_get_asic_family_id(agent):
446446

447447
@dataclass
448448
class Agent:
449-
device_type: int
450-
device_id: str
451-
uuid: str
452-
name: str
453-
compute_capability: str
454-
compute_units: int
455-
asic_family_id: int | None
449+
device_type: int | None = None
450+
device_id: str | None = None
451+
uuid: str | None = None
452+
name: str | None = None
453+
compute_capability: str | None = None
454+
compute_units: int | None = None
455+
asic_family_id: int | None = None
456456

457457

458458
def get_agents() -> list[Agent]:

0 commit comments

Comments
 (0)