Run batchFinishedCallback on processBatch to catch unhandled rejections by test functions (#3844)

sagudev · web-flow · commit 20425f60bb00 · 2024-07-15T17:56:59.000Z
diff --git a/src/webgpu/shader/execution/expression/expression.ts b/src/webgpu/shader/execution/expression/expression.ts
@@ -413,7 +413,7 @@ export async function run(
     };
     const checkBatch = await submitBatch(t, shaderBuilder, shaderBuilderParams, pipelineCache);
     checkBatch();
-    void t.queue.onSubmittedWorkDone().finally(batchFinishedCallback);
+    await t.queue.onSubmittedWorkDone();
   };
 
   const pendingBatches = [];
@@ -430,7 +430,7 @@ export async function run(
     }
     batchesInFlight += 1;
 
-    pendingBatches.push(processBatch(batchCases));
+    pendingBatches.push(processBatch(batchCases).finally(batchFinishedCallback));
   }
 
   await Promise.all(pendingBatches);

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ export async function run(`
`413`	`413`	`};`
`414`	`414`	`const checkBatch = await submitBatch(t, shaderBuilder, shaderBuilderParams, pipelineCache);`
`415`	`415`	`checkBatch();`
`416`		`- void t.queue.onSubmittedWorkDone().finally(batchFinishedCallback);`
	`416`	`+ await t.queue.onSubmittedWorkDone();`
`417`	`417`	`};`
`418`	`418`
`419`	`419`	`const pendingBatches = [];`
`@@ -430,7 +430,7 @@ export async function run(`
`430`	`430`	`}`
`431`	`431`	`batchesInFlight += 1;`
`432`	`432`
`433`		`- pendingBatches.push(processBatch(batchCases));`
	`433`	`+ pendingBatches.push(processBatch(batchCases).finally(batchFinishedCallback));`
`434`	`434`	`}`
`435`	`435`
`436`	`436`	`await Promise.all(pendingBatches);`