8325189: Enable this-escape javac warning in java.base

Reviewed-by: alanb, erikj, naoto, smarks, ihse, joehw, lancea, weijun

Author: jddarcy

make/modules/java.base/Java.gmk

@@ -23,7 +23,11 @@
 # questions.
 #
 
-DISABLED_WARNINGS_java += this-escape
+# The base module should be built with all warnings enabled. When a
+# new warning is added to javac, it can be temporarily added to the
+# disabled warnings list.
+#
+# DISABLED_WARNINGS_java +=
 
 DOCLINT += -Xdoclint:all/protected \
     '-Xdoclint/package:java.*,javax.*'

src/java.base/share/classes/com/sun/security/ntlm/Server.java

@@ -64,6 +64,7 @@ public abstract class Server extends NTLM {
      * @param domain the domain, must not be null
      * @throws NTLMException if {@code domain} is null.
      */
+    @SuppressWarnings("this-escape")
     public Server(String version, String domain) throws NTLMException {
         super(version);
         if (domain == null) {

src/java.base/share/classes/java/io/FileInputStream.java

@@ -133,6 +133,7 @@ public FileInputStream(String name) throws FileNotFoundException {
      * @see        java.io.File#getPath()
      * @see        java.lang.SecurityManager#checkRead(java.lang.String)
      */
+    @SuppressWarnings("this-escape")
     public FileInputStream(File file) throws FileNotFoundException {
         String name = (file != null ? file.getPath() : null);
         @SuppressWarnings("removal")
@@ -177,6 +178,7 @@ public FileInputStream(File file) throws FileNotFoundException {
      *             file descriptor.
      * @see        SecurityManager#checkRead(java.io.FileDescriptor)
      */
+    @SuppressWarnings("this-escape")
     public FileInputStream(FileDescriptor fdObj) {
         @SuppressWarnings("removal")
         SecurityManager security = System.getSecurityManager();

src/java.base/share/classes/java/io/FileOutputStream.java

@@ -208,6 +208,7 @@ public FileOutputStream(File file) throws FileNotFoundException {
      * @see        java.lang.SecurityManager#checkWrite(java.lang.String)
      * @since 1.4
      */
+    @SuppressWarnings("this-escape")
     public FileOutputStream(File file, boolean append)
         throws FileNotFoundException
     {
@@ -254,6 +255,7 @@ public FileOutputStream(File file, boolean append)
      *               write access to the file descriptor
      * @see        java.lang.SecurityManager#checkWrite(java.io.FileDescriptor)
      */
+    @SuppressWarnings("this-escape")
     public FileOutputStream(FileDescriptor fdObj) {
         @SuppressWarnings("removal")
         SecurityManager security = System.getSecurityManager();

src/java.base/share/classes/java/io/InputStreamReader.java

@@ -84,6 +84,7 @@ private static Object lockFor(InputStreamReader reader) {
      *
      * @see Charset#defaultCharset()
      */
+    @SuppressWarnings("this-escape")
     public InputStreamReader(InputStream in) {
         super(in);
         Charset cs = Charset.defaultCharset();
@@ -102,6 +103,7 @@ public InputStreamReader(InputStream in) {
      * @throws     UnsupportedEncodingException
      *             If the named charset is not supported
      */
+    @SuppressWarnings("this-escape")
     public InputStreamReader(InputStream in, String charsetName)
         throws UnsupportedEncodingException
     {
@@ -119,6 +121,7 @@ public InputStreamReader(InputStream in, String charsetName)
      *
      * @since 1.4
      */
+    @SuppressWarnings("this-escape")
     public InputStreamReader(InputStream in, Charset cs) {
         super(in);
         if (cs == null)
@@ -134,6 +137,7 @@ public InputStreamReader(InputStream in, Charset cs) {
      *
      * @since 1.4
      */
+    @SuppressWarnings("this-escape")
     public InputStreamReader(InputStream in, CharsetDecoder dec) {
         super(in);
         if (dec == null)

src/java.base/share/classes/java/io/ObjectInputStream.java

@@ -390,6 +390,7 @@ private static class Logging {
      * @see     ObjectInputStream#readFields()
      * @see     ObjectOutputStream#ObjectOutputStream(OutputStream)
      */
+    @SuppressWarnings("this-escape")
     public ObjectInputStream(InputStream in) throws IOException {
         verifySubclass();
         bin = new BlockDataInputStream(in);

src/java.base/share/classes/java/io/ObjectOutputStream.java

@@ -246,6 +246,7 @@ protected Boolean computeValue(Class<?> type) {
      * @see     ObjectOutputStream#putFields()
      * @see     ObjectInputStream#ObjectInputStream(InputStream)
      */
+    @SuppressWarnings("this-escape")
     public ObjectOutputStream(OutputStream out) throws IOException {
         verifySubclass();
         bout = new BlockDataOutputStream(out);

src/java.base/share/classes/java/io/OutputStreamWriter.java

@@ -101,6 +101,7 @@ private static Object lockFor(OutputStreamWriter writer) {
      * @throws     UnsupportedEncodingException
      *             If the named encoding is not supported
      */
+    @SuppressWarnings("this-escape")
     public OutputStreamWriter(OutputStream out, String charsetName)
         throws UnsupportedEncodingException
     {
@@ -118,6 +119,7 @@ public OutputStreamWriter(OutputStream out, String charsetName)
      * @param  out  An OutputStream
      * @see Charset#defaultCharset()
      */
+    @SuppressWarnings("this-escape")
     public OutputStreamWriter(OutputStream out) {
         super(out);
         se = StreamEncoder.forOutputStreamWriter(out, lockFor(this),
@@ -135,6 +137,7 @@ public OutputStreamWriter(OutputStream out) {
      *
      * @since 1.4
      */
+    @SuppressWarnings("this-escape")
     public OutputStreamWriter(OutputStream out, Charset cs) {
         super(out);
         if (cs == null)
@@ -153,6 +156,7 @@ public OutputStreamWriter(OutputStream out, Charset cs) {
      *
      * @since 1.4
      */
+    @SuppressWarnings("this-escape")
     public OutputStreamWriter(OutputStream out, CharsetEncoder enc) {
         super(out);
         if (enc == null)

src/java.base/share/classes/java/io/PipedInputStream.java

@@ -122,6 +122,7 @@ public PipedInputStream(PipedOutputStream src) throws IOException {
      * @throws     IllegalArgumentException if {@code pipeSize <= 0}.
      * @since      1.6
      */
+    @SuppressWarnings("this-escape")
     public PipedInputStream(PipedOutputStream src, int pipeSize)
             throws IOException {
          initPipe(pipeSize);

src/java.base/share/classes/java/io/PipedOutputStream.java

@@ -59,6 +59,7 @@ more sophisticated.  Either using thread groups (but what about
      * @param      snk   The piped input stream to connect to.
      * @throws     IOException  if an I/O error occurs.
      */
+    @SuppressWarnings("this-escape")
     public PipedOutputStream(PipedInputStream snk)  throws IOException {
         connect(snk);
     }