Fix review feedback

- Rename `javaNative` -> `jvmNative`
- Rename `nativeAssemble` -> `jvmNativeCompile`
- Rename `nativeTestAssemble` -> `jvmNativeTestCompile`

Author: melix

common/docs/ANNOUNCEMENT.md

@@ -43,10 +43,10 @@ pluginManagement {
 ```
 _(this step will be redundant once this plugin is published to the Gradle Plugin Portal)._
 
-After that, we can configure the image build by using a `javaNative` configuration block:
+After that, we can configure the image build by using a `jvmNative` configuration block:
 
 ```groovy
-javaNative {
+jvmNative {
     images {
         main {
             imageName = "my-app"
@@ -58,7 +58,7 @@ javaNative {
 }
 ```
 
-The plugin then adds `nativeAssemble` and `nativeRun` tasks that respectively creates a native executable and runs the main class (as one might expect ☺). If the reflection configuration is necessary for the Native Image building, this plugin also provides a simple option that activates the `[native-image-agent](https://www.graalvm.org/reference-manual/native-image/BuildConfiguration/#assisted-configuration-of-native-image-builds)` without any additional user setup. More information (and _Kotlin_ configuration syntax) is available in the [documentation](https://github.com/graalvm/native-build-tools/blob/master/native-gradle-plugin/README.md).
+The plugin then adds `jvmNativeCompile` and `nativeRun` tasks that respectively creates a native executable and runs the main class (as one might expect ☺). If the reflection configuration is necessary for the Native Image building, this plugin also provides a simple option that activates the `[native-image-agent](https://www.graalvm.org/reference-manual/native-image/BuildConfiguration/#assisted-configuration-of-native-image-builds)` without any additional user setup. More information (and _Kotlin_ configuration syntax) is available in the [documentation](https://github.com/graalvm/native-build-tools/blob/master/native-gradle-plugin/README.md).
 
 #### Testing in _Gradle_
 

common/junit-platform-native/gradle/native-image-testing.gradle

@@ -127,7 +127,7 @@ tasks.named("test") {
     }
 }
 
-tasks.register("nativeTestAssemble", Exec) {
+tasks.register("jvmNativeTestCompile", Exec) {
     dependsOn(test)
     inputs.files(test.classpath)
     workingDir "${buildDir}"
@@ -141,7 +141,7 @@ tasks.register("nativeTestAssemble", Exec) {
 }
 
 tasks.register("nativeTest", Exec) {
-    dependsOn nativeTestAssemble
+    dependsOn jvmNativeTestCompile
     workingDir = "${buildDir}"
     executable = "${buildDir}/native-image-tests"
 }

docs/src/docs/asciidoc/gradle-plugin.adoc

@@ -131,12 +131,12 @@ This plugin works with the `application` plugin and will register a number of ta
 
 The main tasks that you will want to execute are:
 
-- `nativeAssemble`, which will trigger the generation of a native executable of your application
+- `jvmNativeCompile`, which will trigger the generation of a native executable of your application
 - `nativeRun`, which executes the generated native executable
-- `nativeTestAssemble`, which will build a native image with tests found in the `test` source set
+- `jvmNativeTestCompile`, which will build a native image with tests found in the `test` source set
 - `nativeTest`, which will <<testing,execute tests>> found in the `test` source set in native mode
 
-Those tasks are configured with reasonable defaults using the `javaNative` extension `images` container of type link:javadocs/native-gradle-plugin/org/graalvm/buildtools/gradle/dsl/NativeImageOptions.html[NativeImageOptions].
+Those tasks are configured with reasonable defaults using the `jvmNative` extension `images` container of type link:javadocs/native-gradle-plugin/org/graalvm/buildtools/gradle/dsl/NativeImageOptions.html[NativeImageOptions].
 
 The main executable is configured by the image named `main`, while the test executable is configured via the image named `test`.
 
@@ -152,7 +152,7 @@ If you want to use a different toolchain, for example a GraalVM Enterprise Editi
 .Selecting the GraalVM toolchain
 [role="multi-language-sample"]
 ```groovy
-javaNative {
+jvmNative {
     images {
       main {
           javaLauncher = javaToolchains.launcherFor {
@@ -166,7 +166,7 @@ javaNative {
 
 [role="multi-language-sample"]
 ```kotlin
-javaNative {
+jvmNative {
    images {
     main {
       javaLauncher.set(javaToolchains.launcherFor {
@@ -185,7 +185,7 @@ The following configuration options are available for building images:
 .NativeImageOption configuration
 [role="multi-language-sample"]
 ```groovy
-javaNative {
+jvmNative {
   images {
     main {
       // Main options
@@ -217,7 +217,7 @@ javaNative {
 
 [role="multi-language-sample"]
 ```kotlin
-javaNative {
+jvmNative {
   images {
     main {
       // Main options
@@ -312,7 +312,7 @@ This should be as easy as appending `-Pagent` to `run` and `nativeBuild`, or `te
 
 ```bash
 ./gradlew -Pagent run # Runs on JVM with native-image-agent.
-./gradlew -Pagent nativeAssemble # Builds image using configuration acquired by agent.
+./gradlew -Pagent jvmNativeCompile # Builds image using configuration acquired by agent.
 
 # For testing
 ./gradlew -Pagent test # Runs on JVM with native-image-agent.
@@ -345,7 +345,7 @@ nativeBuild {
 you need to use:
 
 ```groovy
-javaNative {
+jvmNative {
   images {
     main {
       verbose = true
@@ -365,7 +365,7 @@ nativeTest {
 you need to use:
 
 ```groovy
-javaNative {
+jvmNative {
   images {
     test {
       verbose = true
@@ -374,8 +374,8 @@ javaNative {
 }
 ```
 
-- The `nativeBuild` task has been renamed to `nativeAssemble`.
-- The `nativeTestBuild` task has been renamed to `nativeTestAssemble`.
+- The `nativeBuild` task has been renamed to `jvmNativeCompile`.
+- The `nativeTestBuild` task has been renamed to `jvmNativeTestCompile`.
 
 Both `nativeBuild` and `nativeTestBuild` task invocations are still supported but deprecated and will be removed in a future release.
 

native-gradle-plugin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/DeprecatedExtensionFunctionalTest.groovy

@@ -57,15 +57,15 @@ class DeprecatedExtensionFunctionalTest extends AbstractFunctionalTest {
                 jvmArgs('hello', 'world')
             }
             
-            assert javaNative.images.${replacedWith}.verbose.get() == true
-            assert javaNative.images.${replacedWith}.jvmArgs.get() == ['hello', 'world']
+            assert jvmNative.images.${replacedWith}.verbose.get() == true
+            assert jvmNative.images.${replacedWith}.jvmArgs.get() == ['hello', 'world']
         """
 
         when:
         run 'help'
 
         then:
-        outputContains "The $extensionName extension is deprecated and will be removed. Please use the 'javaNative.images.$replacedWith' extension to configure the native image instead."
+        outputContains "The $extensionName extension is deprecated and will be removed. Please use the 'jvmNative.images.$replacedWith' extension to configure the native image instead."
 
         where:
         extensionName | replacedWith
@@ -84,12 +84,12 @@ class DeprecatedExtensionFunctionalTest extends AbstractFunctionalTest {
 
         then:
         tasks {
-            succeeded ':nativeAssemble'
+            succeeded ':jvmNativeCompile'
             succeeded ':nativeBuild'
         }
 
         and:
-        outputContains 'Task nativeBuild is deprecated. Use nativeAssemble instead.'
+        outputContains 'Task nativeBuild is deprecated. Use jvmNativeCompile instead.'
 
         where:
         version << TESTED_GRADLE_VERSIONS

native-gradle-plugin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/JavaApplicationFunctionalTest.groovy

@@ -46,7 +46,7 @@ import org.graalvm.buildtools.gradle.fixtures.AbstractFunctionalTest
 class JavaApplicationFunctionalTest extends AbstractFunctionalTest {
     def "can build a native image for a simple application"() {
         gradleVersion = version
-        def nativeApp = file("build/native/nativeAssemble/java-application")
+        def nativeApp = file("build/native/jvmNativeCompile/java-application")
         debug  = true
 
         given:
@@ -59,11 +59,11 @@ class JavaApplicationFunctionalTest extends AbstractFunctionalTest {
         """.stripIndent()
 
         when:
-        run 'nativeAssemble'
+        run 'jvmNativeCompile'
 
         then:
         tasks {
-            succeeded ':jar', ':nativeAssemble'
+            succeeded ':jar', ':jvmNativeCompile'
             doesNotContain ':build', ':run'
         }
 

native-gradle-plugin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/JavaApplicationWithResourcesFunctionalTest.groovy

@@ -47,7 +47,7 @@ class JavaApplicationWithResourcesFunctionalTest extends AbstractFunctionalTest
     @Unroll("can build an application which uses resources using #pattern on Gradle #version with JUnit Platform #junitVersion")
     def "can build an application which uses resources"() {
         gradleVersion = version
-        def nativeApp = file("build/native/nativeAssemble/java-application")
+        def nativeApp = file("build/native/jvmNativeCompile/java-application")
         debug = true
         given:
         withSample("java-application-with-resources")
@@ -60,11 +60,11 @@ class JavaApplicationWithResourcesFunctionalTest extends AbstractFunctionalTest
         """
 
         when:
-        run 'nativeAssemble'
+        run 'jvmNativeCompile'
 
         then:
         tasks {
-            succeeded ':jar', ':nativeAssemble'
+            succeeded ':jar', ':jvmNativeCompile'
             doesNotContain ':build', ':run'
         }
 
@@ -92,7 +92,7 @@ class JavaApplicationWithResourcesFunctionalTest extends AbstractFunctionalTest
         junitVersion = System.getProperty('versions.junit')
         [version, [pattern, config]] << [TESTED_GRADLE_VERSIONS,
                                          [["explicit resource declaration", """
-javaNative {
+jvmNative {
     images {
         main {
             resources {
@@ -103,7 +103,7 @@ javaNative {
 }
 """],
                                          ["detected", """
-javaNative {
+jvmNative {
     images {
         main {
             resources {
@@ -119,7 +119,7 @@ javaNative {
 """
                                          ],
                                           ["project local detection only", """
-javaNative {
+jvmNative {
     images {
         main {
             resources {
@@ -171,7 +171,7 @@ javaNative {
         junitVersion = System.getProperty('versions.junit')
         [version, [pattern, config]] << [TESTED_GRADLE_VERSIONS,
                                          [["explicit resource declaration", """
-javaNative {
+jvmNative {
     images {
         test {
             resources {
@@ -183,7 +183,7 @@ javaNative {
 }
 """],
                                          ["detected", """
-javaNative {
+jvmNative {
     images {
         test {
             resources {

native-gradle-plugin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/JavaApplicationWithTestsFunctionalTest.groovy

@@ -49,17 +49,17 @@ class JavaApplicationWithTestsFunctionalTest extends AbstractFunctionalTest {
     @Unroll("can execute tests in a native image on Gradle #version with JUnit Platform #junitVersion")
     def "can build a native image and run it"() {
         gradleVersion = version
-        def nativeTestsApp = file("build/native/nativeTestAssemble/java-application-tests")
+        def nativeTestsApp = file("build/native/jvmNativeTestCompile/java-application-tests")
 
         given:
         withSample("java-application-with-tests")
 
         when:
-        run 'nativeTestAssemble'
+        run 'jvmNativeTestCompile'
 
         then:
         tasks {
-            succeeded ':testClasses', ':nativeTestAssemble'
+            succeeded ':testClasses', ':jvmNativeTestCompile'
             // doesNotContain ':build'
         }
         outputDoesNotContain "Running in 'test discovery' mode. Note that this is a fallback mode."
@@ -105,7 +105,7 @@ class JavaApplicationWithTestsFunctionalTest extends AbstractFunctionalTest {
         then:
         tasks {
             succeeded ':testClasses',
-                    ':nativeTestAssemble',
+                    ':jvmNativeTestCompile',
                     ':test', // there should probably not be a dependency here
                     ':nativeTest'
             doesNotContain ':build'

native-gradle-plugin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/JavaLibraryFunctionalTest.groovy

@@ -57,18 +57,18 @@ class JavaLibraryFunctionalTest extends AbstractFunctionalTest {
             libExt = ".dylib"
         }
 
-        def library = file("build/native/nativeAssemble/java-library" + libExt)
+        def library = file("build/native/jvmNativeCompile/java-library" + libExt)
         debug  = true
 
         given:
         withSample("java-library")
 
         when:
-        run 'nativeAssemble'
+        run 'jvmNativeCompile'
 
         then:
         tasks {
-            succeeded ':jar', ':nativeAssemble'
+            succeeded ':jar', ':jvmNativeCompile'
             doesNotContain ':build'
         }
 

native-gradle-plugin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/KotlinApplicationWithTestsFunctionalTest.groovy

@@ -60,7 +60,7 @@ class KotlinApplicationWithTestsFunctionalTest extends AbstractFunctionalTest {
         then:
         tasks {
             succeeded ':compileTestKotlin',
-                    ':nativeTestAssemble',
+                    ':jvmNativeTestCompile',
                     ':test',
                     ':nativeTest'
             doesNotContain ':build'

native-gradle-plugin/src/functionalTest/groovy/org/graalvm/buildtools/gradle/MultiProjectJavaApplicationWithTestsFunctionalTest.groovy

@@ -59,7 +59,7 @@ class MultiProjectJavaApplicationWithTestsFunctionalTest extends AbstractFunctio
         tasks {
             succeeded ':utils:jar',
                     ':core:testClasses',
-                    ':core:nativeTestAssemble',
+                    ':core:jvmNativeTestCompile',
                     ':core:nativeTest'
             doesNotContain ':core:build'
         }