Move test for recursive class definitions

Author: marcphilipp

common/junit-platform-native/src/test/java/org/graalvm/junit/jupiter/AbstractParentClassTests.java

@@ -43,7 +43,6 @@
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
@@ -53,32 +52,6 @@
 
 public class AbstractParentClassTests {
 
-    public static class OuterClass {
-        @Test
-        protected void test() {
-            Assertions.assertTrue(true, "Just a dummy test that should be executed in outer class");
-        }
-
-        /* Since at org.graalvm.junit.platform.JUnitPlatformFeature#registerTestClassForReflection we register all
-         * declared classes and superclass of the test class, and we do so recursively, we want to avoid infinite loop.
-         * This inheritance shows that we won't call registration of these classes indefinitely (call registration of
-         * all declared classes of AbstractParentClassTests, then recursively call superclass of InfiniteLoopTest and
-         * repeat the process indefinitely) */
-        private class InfiniteLoopTest extends OuterClass {
-            @Test
-            protected void test() {
-                Assertions.assertTrue(true, "Just a dummy test that should be executed in inner class");
-            }
-        }
-
-        /* Since enum here is declared class of AbstractParentClassTests, we want to avoid registrations of
-         * enum's internal superclasses and sub-classes at org.graalvm.junit.platform.JUnitPlatformFeature#registerTestClassForReflection */
-        private enum EnumTest {
-            SOME_VALUE,
-            OTHER_VALUE
-        }
-    }
-
     public abstract static class MathPowerTests {
         protected static BiFunction<Integer, Integer, Integer> powFunction;
 

common/junit-platform-native/src/test/java/org/graalvm/junit/platform/TestClassRegistrarTests.java

@@ -0,0 +1,92 @@
+/*
+ * Copyright (c) 2020, 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * The Universal Permissive License (UPL), Version 1.0
+ *
+ * Subject to the condition set forth below, permission is hereby granted to any
+ * person obtaining a copy of this software, associated documentation and/or
+ * data (collectively the "Software"), free of charge and under any and all
+ * copyright rights in the Software, and any and all patent rights owned or
+ * freely licensable by each licensor hereunder covering either (i) the
+ * unmodified Software as contributed to or provided by such licensor, or (ii)
+ * the Larger Works (as defined below), to deal in both
+ *
+ * (a) the Software, and
+ *
+ * (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
+ * one is included with the Software each a "Larger Work" to which the Software
+ * is contributed by such licensors),
+ *
+ * without restriction, including without limitation the rights to copy, create
+ * derivative works of, display, perform, and distribute the Software and make,
+ * use, sell, offer for sale, import, export, have made, and have sold the
+ * Software and the Larger Work(s), and to sublicense the foregoing rights on
+ * either these or other terms.
+ *
+ * This license is subject to the following condition:
+ *
+ * The above copyright notice and either this complete permission notice or at a
+ * minimum a reference to the UPL must be included in all copies or substantial
+ * portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package org.graalvm.junit.platform;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class TestClassRegistrarTests {
+
+    @Test
+    void avoidsInfiniteLoopsWhenClassDefinitionsAreRecursive() {
+        List<Class<?>> registeredClasses = new ArrayList<>();
+        var registrar = new TestClassRegistrar(registeredClasses::add);
+
+        registrar.registerTestClassForReflection(OuterClass.class);
+
+        assertEquals(List.of(OuterClass.class, OuterClass.InfiniteLoop.class), registeredClasses);
+    }
+
+    @Test
+    void avoidsRegistrationOfJavaInternalTypes() {
+        List<Class<?>> registeredClasses = new ArrayList<>();
+        var registrar = new TestClassRegistrar(registeredClasses::add);
+
+        registrar.registerTestClassForReflection(EnumTest.class);
+
+        assertEquals(List.of(EnumTest.class), registeredClasses);
+    }
+
+    public static class OuterClass {
+
+        /* Since TestClassRegistrar registers all declared classes and superclass of the test class, and we do so
+         * recursively, we want to avoid infinite loop.
+         * This inheritance shows that we won't call registration of these classes indefinitely (call registration of
+         * all declared classes of AbstractParentClassTests, then recursively call superclass of InfiniteLoopTest and
+         * repeat the process indefinitely) */
+        @SuppressWarnings({"unused", "InnerClassMayBeStatic"})
+        class InfiniteLoop extends OuterClass {
+        }
+    }
+
+    /* Since enum here is declared class of AbstractParentClassTests, we want to avoid registrations of
+     * enum's internal superclasses and sub-classes */
+    @SuppressWarnings("unused")
+    enum EnumTest {
+        SOME_VALUE,
+        OTHER_VALUE
+    }
+}