Formatting request parameters and log information

The excluded parameters will be marked [FILTERED] in the log.

Author: rainboyan

grace-bootstrap/src/main/groovy/org/grails/exceptions/reporting/DefaultStackTraceFilterer.java

@@ -72,17 +72,20 @@ public DefaultStackTraceFilterer(boolean shouldFilter) {
         this.packagesToFilter.addAll(Arrays.asList(DEFAULT_INTERNAL_PACKAGES));
     }
 
+    @Override
     public void addInternalPackage(String name) {
         if (name == null) {
             throw new IllegalArgumentException("Package name cannot be null");
         }
         this.packagesToFilter.add(name);
     }
 
+    @Override
     public void setCutOffPackage(String cutOffPackage) {
         this.cutOffPackage = cutOffPackage;
     }
 
+    @Override
     public Throwable filter(Throwable source, boolean recursive) {
         if (recursive) {
             Throwable current = source;
@@ -95,6 +98,7 @@ public Throwable filter(Throwable source, boolean recursive) {
         return filter(source);
     }
 
+    @Override
     public Throwable filter(Throwable source) {
         if (this.shouldFilter) {
             StackTraceElement[] trace = source.getStackTrace();
@@ -153,8 +157,14 @@ protected boolean isApplicationClass(String className) {
         return true;
     }
 
+    @Override
     public void setShouldFilter(boolean shouldFilter) {
         this.shouldFilter = shouldFilter;
     }
 
+    @Override
+    public boolean isShouldFilter() {
+        return this.shouldFilter;
+    }
+
 }

grace-bootstrap/src/main/groovy/org/grails/exceptions/reporting/StackTraceFilterer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2011-2022 the original author or authors.
+ * Copyright 2011-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,8 +18,9 @@
 /**
  * Improves the output of stack traces produced by exceptions in a Grails application.
  *
- * @since 2.0
  * @author Graeme Rocher
+ * @author Michaael Yan
+ * @since 2.0
  */
 public interface StackTraceFilterer {
 
@@ -62,4 +63,9 @@ public interface StackTraceFilterer {
      */
     void setShouldFilter(boolean shouldFilter);
 
+    /**
+     * @return boolean Whether to filter stack traces or not
+     */
+    boolean isShouldFilter();
+
 }

grace-web-mvc/src/main/groovy/org/grails/web/errors/GrailsExceptionResolver.java

@@ -57,6 +57,7 @@
  * Wraps any runtime exceptions with a GrailsWrappedException instance.
  *
  * @author Graeme Rocher
+ * @author Michael Yan
  */
 @SuppressWarnings({ "rawtypes", "unchecked" })
 public class GrailsExceptionResolver extends SimpleMappingExceptionResolver implements ServletContextAware, GrailsApplicationAware {
@@ -263,7 +264,8 @@ protected String getRequestLogMessage(String exceptionName, HttpServletRequest r
 
         sb.append(exceptionName)
                 .append(" occurred when processing request: ")
-                .append("[").append(request.getMethod().toUpperCase()).append("] ");
+                .append(LINE_SEPARATOR);
+        sb.append("URI: ");
 
         if (request.getAttribute(WebUtils.FORWARD_REQUEST_URI_ATTRIBUTE) != null) {
             sb.append(request.getAttribute(WebUtils.FORWARD_REQUEST_URI_ATTRIBUTE));
@@ -272,6 +274,13 @@ protected String getRequestLogMessage(String exceptionName, HttpServletRequest r
             sb.append(request.getRequestURI());
         }
 
+        sb.append(LINE_SEPARATOR);
+        sb.append("Method: ").append(request.getMethod().toUpperCase()).append(LINE_SEPARATOR);
+
+        if (message != null) {
+            sb.append("Message: ").append(message).append(LINE_SEPARATOR);
+        }
+
         Config config = this.grailsApplication != null ? this.grailsApplication.getConfig() : null;
         boolean shouldLogRequestParameters = config != null ? config.getProperty(Settings.SETTING_LOG_REQUEST_PARAMETERS,
                 Boolean.class, Environment.getCurrent() == Environment.DEVELOPMENT) : false;
@@ -282,9 +291,8 @@ protected String getRequestLogMessage(String exceptionName, HttpServletRequest r
             if (params.hasMoreElements()) {
                 String param;
                 String[] values;
-                int i;
 
-                sb.append(" - parameters:");
+                sb.append("Parameters:");
 
                 List<String> blackList = (config.getProperty(Settings.SETTING_EXCEPTION_RESOLVER_PARAM_EXCLUDES,
                         List.class, Collections.emptyList()));
@@ -296,28 +304,33 @@ protected String getRequestLogMessage(String exceptionName, HttpServletRequest r
                     param = params.nextElement();
                     values = request.getParameterValues(param);
 
-                    if (values != null) {
-                        for (i = 0; i < values.length; i++) {
-                            sb.append(LINE_SEPARATOR).append(param).append(": ");
+                    String paramName = param;
+                    if (paramName.endsWith("[]")) {
+                        paramName = paramName.substring(0, paramName.length() - 2);
+                    }
 
-                            if (blackList.contains(param)) {
-                                sb.append("***");
-                            }
-                            else {
-                                sb.append(values[i]);
-                            }
+                    sb.append(LINE_SEPARATOR).append("  - ").append(paramName).append(": ");
+                    if (values != null && values.length > 0) {
+                        if (blackList.contains(paramName)) {
+                            sb.append("[FILTERED]");
+                        }
+                        else {
+                            sb.append(String.join(", ", values));
                         }
                     }
                 }
+
+                sb.append(LINE_SEPARATOR);
             }
         }
 
         sb.append(LINE_SEPARATOR);
-        if (message != null) {
-            sb.append(message).append(". ");
+        if (this.stackFilterer.isShouldFilter()) {
+            sb.append("Filtered stacktrace:");
+        }
+        else {
+            sb.append("Full stacktrace:");
         }
-        sb.append(LINE_SEPARATOR);
-        sb.append("Stacktrace follows:");
 
         return sb.toString();
     }