Generate metadata file independent of Maven version (#44)

Author: jjohannes

src/main/java/org/gradlex/maven/gmm/GradleModuleMetadataMojo.java

@@ -16,7 +16,6 @@
 
 package org.gradlex.maven.gmm;
 
-import org.apache.maven.Maven;
 import org.apache.maven.model.Dependency;
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -30,10 +29,8 @@
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
-import java.io.InputStream;
 import java.nio.file.Files;
 import java.util.List;
-import java.util.Properties;
 
 /**
  * Goal that generates Gradle Module Metadata.
@@ -83,7 +80,7 @@ public void execute() throws MojoExecutionException {
 
         try (FileWriter fileWriter = new FileWriter(moduleFile)) {
             GradleModuleMetadataWriter.generateTo(
-                    project, getMavenVersion(),
+                    project,
                     platformDependencies,
                     capabilities,
                     removedDependencies,
@@ -109,21 +106,4 @@ private void addMarkerToPomIfNotPresent() {
             throw new RuntimeException(e);
         }
     }
-
-    private static String getMavenVersion() throws MojoExecutionException {
-        try (InputStream resource = Maven.class.getClassLoader().getResourceAsStream("org/apache/maven/messages/build.properties")) {
-            if (resource == null) {
-                throw new MojoExecutionException("Unable to determine Maven version.");
-            }
-            Properties properties = new Properties();
-            properties.load(resource);
-            String version = properties.getProperty("version");
-            if (version == null) {
-                throw new MojoExecutionException("Unable to determine Maven version.");
-            }
-            return version;
-        } catch (IOException e) {
-            throw new MojoExecutionException("Unable to determine Maven version.", e);
-        }
-    }
 }

src/main/java/org/gradlex/maven/gmm/GradleModuleMetadataWriter.java

@@ -54,15 +54,15 @@ private enum Variant {
         }
     }
 
-    public static void generateTo(MavenProject project, String mavenVersion,
+    public static void generateTo(MavenProject project,
                                   List<Dependency> platformDependencies, List<Capability> capabilities,
                                   List<Dependency> removedDependencies,
                                   List<Dependency> compileOnlyApiDependencies,
                                   Writer writer) throws IOException {
         JsonWriter jsonWriter = new JsonWriter(writer);
         jsonWriter.setHtmlSafe(false);
         jsonWriter.setIndent("  ");
-        writeComponentWithVariants(project, mavenVersion, platformDependencies, capabilities, removedDependencies, compileOnlyApiDependencies, jsonWriter);
+        writeComponentWithVariants(project, platformDependencies, capabilities, removedDependencies, compileOnlyApiDependencies, jsonWriter);
         jsonWriter.flush();
         writer.append('\n');
     }
@@ -89,7 +89,7 @@ private static Map<String, String> variantAttributes(Variant variant) {
         return attributes;
     }
 
-    private static void writeComponentWithVariants(MavenProject project, String mavenVersion,
+    private static void writeComponentWithVariants(MavenProject project,
                                                    List<Dependency> platformDependencies,
                                                    List<Capability> capabilities,
                                                    List<Dependency> removedDependencies,
@@ -98,7 +98,6 @@ private static void writeComponentWithVariants(MavenProject project, String mave
         jsonWriter.beginObject();
         writeFormat(jsonWriter);
         writeIdentity(project, jsonWriter);
-        writeCreator(mavenVersion, jsonWriter);
         writeVariants(project, platformDependencies, capabilities, removedDependencies, compileOnlyApiDependencies, jsonWriter);
         jsonWriter.endObject();
     }
@@ -132,17 +131,6 @@ private static void writeVariants(MavenProject project,
         jsonWriter.endArray();
     }
 
-    private static void writeCreator(String mavenVersion, JsonWriter jsonWriter) throws IOException {
-        jsonWriter.name("createdBy");
-        jsonWriter.beginObject();
-        jsonWriter.name("maven");
-        jsonWriter.beginObject();
-        jsonWriter.name("version");
-        jsonWriter.value(mavenVersion);
-        jsonWriter.endObject();
-        jsonWriter.endObject();
-    }
-
     private static void writeFormat(JsonWriter jsonWriter) throws IOException {
         jsonWriter.name("formatVersion");
         jsonWriter.value(FORMAT_VERSION);

src/test/resources/capabilities/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "release"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",

src/test/resources/combine-with-shade-plugin/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "release"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",

src/test/resources/combined-features/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "release"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",

src/test/resources/compile-only-api-dependencies/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "release"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",

src/test/resources/optional-dependencies/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "release"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",

src/test/resources/parent-dependencies/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "release"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",

src/test/resources/platform-dependencies/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "release"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",

src/test/resources/snapshot-status-attribute/expected-module.json

@@ -8,11 +8,6 @@
       "org.gradle.status": "integration"
     }
   },
-  "createdBy": {
-    "maven": {
-      "version": "3.9.10"
-    }
-  },
   "variants": [
     {
       "name": "apiElements",