Port dependency constraints for checkstyle from build-parameters plugin #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of our plugin have multiple GitHub security alerts reported due to vulnerable transitive dependencies on the build classpath. There are two sources for these: 1. transitive dependencies of the checkstyle plugin 2. transitive dependencies of exemplar Since we apply and configure checkstyle in this convention plugin, it makes sense to fix CVEs here as well by upgrading the affected dependencies. So this commit basically ports the configuration from https://github.com/gradlex-org/build-parameters/blob/0315507362b027bab91c797ad2bdbfc4debf165b/build.gradle.kts#L16-L21 to this plugin which will resolve security alerts such as https://github.com/gradlex-org/maven-plugin-development/security/dependabot/23.
Member
Author
|
We still need to discuss how to deal with alerts caused by transitives of exemplar, since we don't manage that here. Currently the configuration for documentation tests is duplicated across repositories. Maybe this is a good time to consolidate that and also add code to fix vulnerabilities across all projects. |
Member
|
Obsolete due to #60 - will have to check the Depenabot reports in the other repos again, once they use the new convention setup consistently. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our plugin have multiple GitHub security alerts reported due to
vulnerable transitive dependencies on the build classpath. There are two
sources for these:
Since we apply and configure checkstyle in this convention plugin, it
makes sense to fix CVEs here as well by upgrading the affected
dependencies.
So this commit basically ports the configuration from
https://github.com/gradlex-org/build-parameters/blob/0315507362b027bab91c797ad2bdbfc4debf165b/build.gradle.kts#L16-L21
to this plugin which will resolve security alerts such as
https://github.com/gradlex-org/maven-plugin-development/security/dependabot/23.