Skip to content

Commit 8df6303

Browse files
committed
Improve error messages
1 parent 0e21763 commit 8df6303

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/main/java/org/gradlex/javamodule/dependencies/JavaModuleDependenciesExtension.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ public Provider<Dependency> create(String moduleName, SourceSet sourceSetWithMod
264264
return dependency;
265265
} else {
266266
getProject().getLogger().lifecycle(
267-
"[WARN] [Java Module Dependencies] javaModuleDependencies.moduleNameToGA.put(\"" + moduleName + "\", \"group:artifact\") mapping is missing.");
267+
"[WARN] [Java Module Dependencies] " + moduleName + "=group:artifact missing in " + getModulesProperties().get().getAsFile());
268268
return null;
269269
}
270270
});
@@ -325,6 +325,9 @@ private Map<String, Object> findGav(String ga, String moduleName) {
325325
Optional<VersionConstraint> version = catalog == null ? empty() : catalog.findVersion(moduleName.replace('_', '.'));
326326
Map<String, Object> gav = new HashMap<>();
327327
String[] gaSplit = ga.split(":");
328+
if (gaSplit.length < 2) {
329+
throw new RuntimeException("Invalid mapping: " + moduleName + "="+ ga);
330+
}
328331
gav.put(GAV.GROUP, gaSplit[0]);
329332
gav.put(GAV.ARTIFACT, gaSplit[1]);
330333
version.ifPresent(versionConstraint -> gav.put(GAV.VERSION, versionConstraint));

src/test/groovy/org/gradlex/javamodule/dependencies/test/WarningsTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ class WarningsTest extends Specification {
4747
when:
4848
def result = fail()
4949
then:
50-
result.output.contains('[WARN] [Java Module Dependencies] javaModuleDependencies.moduleNameToGA.put("commons.math3", "group:artifact") mapping is missing.\n')
50+
result.output.contains('[WARN] [Java Module Dependencies] commons.math3=group:artifact missing in')
5151
}
5252
}

0 commit comments

Comments
 (0)