Migrate build to shared convention plugins setup

Author: jjohannes

build.gradle.kts

@@ -1,50 +1,26 @@
-plugins {
-    id("groovy")
-    id("org.gradlex.internal.plugin-publish-conventions") version "0.6"
-}
-
-group = "org.gradlex"
-version = "1.7"
-
-tasks.withType<JavaCompile>().configureEach { options.release = 8 }
-
-dependencies {
-    testImplementation("org.spockframework:spock-core:2.3-groovy-4.0")
-    testImplementation("org.gradle.exemplar:samples-check:1.0.3")
-    testRuntimeOnly("org.junit.vintage:junit-vintage-engine")
-}
-
-pluginPublishConventions {
-    id("${project.group}.${project.name}")
-    implementationClass("org.gradlex.javamodule.testing.JavaModuleTestingPlugin")
-    displayName("Java Module Testing Gradle Plugin")
-    description("A plugin to test Java Modules (whitebox and blackbox) without the hassle.")
-    tags("gradlex", "java", "modularity", "jigsaw", "jpms", "testing")
-    gitHub("https://github.com/gradlex-org/java-module-testing")
-    developer {
-        id.set("jjohannes")
-        name.set("Jendrik Johannes")
-        email.set("[email protected]")
-    }
-}
-
-testing.suites.named<JvmTestSuite>("test") {
-    useJUnitJupiter()
-    listOf("7.4", "7.6.5", "8.0.2", "8.14.2").forEach { gradleVersionUnderTest ->
-        targets.register("test${gradleVersionUnderTest}") {
-            testTask {
-                group = LifecycleBasePlugin.VERIFICATION_GROUP
-                description = "Runs tests against Gradle $gradleVersionUnderTest"
-                systemProperty("gradleVersionUnderTest", gradleVersionUnderTest)
-                exclude("**/*SamplesTest.class") // Not yet cross-version ready
-            }
-        }
-    }
-    targets.all {
-        testTask {
-            maxParallelForks = 4
-            inputs.dir(layout.projectDirectory.dir("samples"))
-            inputs.dir("samples")
-        }
-    }
-}
+version = "1.7"
+
+publishingConventions {
+    pluginPortal("${project.group}.${project.name}") {
+        implementationClass("org.gradlex.javamodule.testing.JavaModuleTestingPlugin")
+        displayName("Java Module Testing Gradle Plugin")
+        description("A plugin to test Java Modules (whitebox and blackbox) without the hassle.")
+        tags("gradlex", "java", "modularity", "jigsaw", "jpms", "testing")
+    }
+    gitHub("https://github.com/gradlex-org/java-module-testing")
+    developer {
+        id.set("jjohannes")
+        name.set("Jendrik Johannes")
+        email.set("[email protected]")
+    }
+}
+
+testingConventions { testGradleVersions("7.4", "7.6.5", "8.0.2", "8.14.2") }
+
+// === the following custom configuration should be removed once tests are migrated to Java
+apply(plugin = "groovy")
+
+tasks.named<GroovyCompile>("compileTestGroovy") { targetCompatibility = "11" } // allow tests to run against 6.x
+
+dependencies { testImplementation("org.spockframework:spock-core:2.3-groovy-4.0") } //
+// ====================================================================================

gradle/checkstyle/checkstyle.xml

@@ -0,0 +1 @@
+toolchainVersion=17

gradle/checkstyle/header.txt

@@ -1,21 +1,3 @@
-plugins {
-    id("com.gradle.develocity") version "4.2.2"
-}
-
-dependencyResolutionManagement {
-    repositories.mavenCentral()
-}
+plugins { id("org.gradlex.internal-build-conventions") version "0.7" }
 
 rootProject.name = "java-module-testing"
-
-develocity {
-    buildScan {
-        val isCi = providers.environmentVariable("CI").getOrElse("false").toBoolean()
-        if (isCi) {
-            termsOfUseUrl = "https://gradle.com/help/legal-terms-of-use"
-            termsOfUseAgree = "yes"
-        } else {
-            publishing.onlyIf { false }
-        }
-    }
-}

gradle/gradle-daemon-jvm.properties

@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: Apache-2.0
+package org.gradlex.javamodule.testing.test.samples;
+
+import java.io.File;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import org.gradle.exemplar.model.Command;
+import org.gradle.exemplar.model.Sample;
+import org.gradle.exemplar.test.runner.SampleModifier;
+
+public class PluginBuildLocationSampleModifier implements SampleModifier {
+    @Override
+    public Sample modify(Sample sampleIn) {
+        Command cmd = sampleIn.getCommands().remove(0);
+        File pluginProjectDir = new File(".");
+        sampleIn.getCommands()
+                .add(new Command(
+                        new File(pluginProjectDir, "gradlew").getAbsolutePath(),
+                        cmd.getExecutionSubdirectory(),
+                        Stream.concat(
+                                        cmd.getArgs().stream(),
+                                        Stream.of(
+                                                "build",
+                                                "--warning-mode=all",
+                                                "-PpluginLocation=" + pluginProjectDir.getAbsolutePath()))
+                                .collect(Collectors.toList()),
+                        cmd.getFlags(),
+                        cmd.getExpectedOutput(),
+                        cmd.isExpectFailure(),
+                        true,
+                        cmd.isAllowDisorderedOutput(),
+                        cmd.getUserInputs()));
+        return sampleIn;
+    }
+}

settings.gradle.kts

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Apache-2.0
+package org.gradlex.javamodule.testing.test.samples;
+
+import org.gradle.exemplar.test.runner.SampleModifiers;
+import org.gradle.exemplar.test.runner.SamplesRoot;
+import org.gradle.exemplar.test.runner.SamplesRunner;
+import org.junit.runner.RunWith;
+
+@RunWith(SamplesRunner.class)
+@SamplesRoot("samples")
+@SampleModifiers(PluginBuildLocationSampleModifier.class)
+public class SamplesTest {}