Do not add capabilities to platform variants

[boris-petrov]

I updated to version 2.2 (from 2.1.2) and my build seems to hang with one CPU being busy at 100% with a number of errors like the following:

The dependency resolution engine wasn't able to find a version of module com.fasterxml.jackson.dataformat:jackson-dataformat-cbor which satisfied all requirements because the graph wasn't stable enough. The highest version was selected in order to stabilize selection.
Features available in a stable graph like version alignment are not guaranteed in this case.
The dependency resolution engine wasn't able to find a version of module com.fasterxml.jackson.dataformat:jackson-dataformat-yaml which satisfied all requirements because the graph wasn't stable enough. The highest version was selected in order to stabilize selection.
Features available in a stable graph like version alignment are not guaranteed in this case.

Any ideas why's that? I don't see anything in the changelog that could lead to such a change in behavior.

[jjohannes]

This is the only production code change in the release. Do you have these dependencies in your graph?

[boris-petrov]

Yes, I have net.java.dev.jna:jna. Removing it fixes the issue. Any ideas why? I had added it as a platform, perhaps that was problem?

[jjohannes]

Interesting. Can I ask why you added it as a platform? The original metadata does not seem to have a <dependencyManagement> block. Maybe we can create a minimal reproducer based on your use case.

I think there is an improvement we can do: Right now, we add the capabilities to all variants. But when the library only has pom metadata, it always has four "platform" variants. A dependency with only pom metadata can potentially be both: a library and a platform.

The platform variants only contain the <dependencyManagement> information and not the Jar. Thus they do not create a capability conflict. Consequential, we should not add the capability for these variants:

• platform-compile
• platform-runtime
• enforced-platform-runtime
• enforced-platform-compile

[boris-petrov]

Interesting. Can I ask why you added it as a platform?

I can't answer that question. 😄 I've forgotten why, perhaps it just worked and I left it like that. Sorry I can't be more helpful.

Let me know if you need any more information. Otherwise feel free to close the issue. Thanks for the help!

[jjohannes]

If we do not want to match all variants, we somehow need to filter.

But filtering by name is not a stable solution for the general patch DSL, where we do not know for certain how variants are named in the metadata of a specific component if it uses Gradle Metadata (related #238).