@@ -5110,7 +5110,7 @@ static const ggml_type other_types[] = {
51105110};
51115111
51125112// Test cases for evaluation: should try to cover edge cases while using small input sizes to keep the runtime low
5113- static std::vector<std::unique_ptr<test_case>> make_test_cases_eval (bool test_sgd = true ) {
5113+ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval () {
51145114 std::vector<std::unique_ptr<test_case>> test_cases;
51155115 std::default_random_engine rng (0 );
51165116
@@ -5912,8 +5912,7 @@ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval(bool test_sg
59125912 test_cases.emplace_back (new test_cross_entropy_loss_back (GGML_TYPE_F32, {30000 , 1 , 1 , 1 }));
59135913
59145914 test_cases.emplace_back (new test_opt_step_adamw (GGML_TYPE_F32, {10 , 5 , 4 , 3 }));
5915- if (test_sgd)
5916- test_cases.emplace_back (new test_opt_step_sgd (GGML_TYPE_F32, { 10 , 5 , 4 , 3 }));
5915+ test_cases.emplace_back (new test_opt_step_sgd (GGML_TYPE_F32, { 10 , 5 , 4 , 3 }));
59175916
59185917#if 0
59195918 // these tests are disabled to save execution time, sbut they can be handy for debugging
@@ -6051,10 +6050,6 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
60516050 }
60526051 };
60536052
6054- char const * name = ggml_backend_name (backend);
6055- bool const vulkan = strstr (name, " ulkan" );
6056- bool const sgd = !vulkan;
6057-
60586053 if (mode == MODE_TEST) {
60596054 auto test_cases = make_test_cases_eval ();
60606055 filter_test_cases (test_cases, params_filter);
@@ -6080,7 +6075,7 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
60806075 }
60816076
60826077 if (mode == MODE_GRAD) {
6083- auto test_cases = make_test_cases_eval (sgd );
6078+ auto test_cases = make_test_cases_eval ();
60846079 filter_test_cases (test_cases, params_filter);
60856080 size_t n_ok = 0 ;
60866081 for (auto & test : test_cases) {
0 commit comments