fix: Resolve compiler warnings and hints in PasBuild source

Add explicit string type casts for DOM API calls (UnicodeString/
AnsiString conversions), remove unused variables, and add
reintroduce to constructors that hide inherited signatures.

Author: graemeg

src/main/pascal/PasBuild.Command.ProcessResources.pas

@@ -30,7 +30,7 @@   TProcessResourcesCommand = class(TBuildCommand)
     function ApplyFiltering(const AContent: string): string;
     procedure CopyResources(const ASourceDir, ATargetDir: string);
   public
-    constructor Create(AConfig: TProjectConfig; AResourcesConfig: TResourcesConfig; const ATargetDir: string);
+    constructor Create(AConfig: TProjectConfig; AResourcesConfig: TResourcesConfig; const ATargetDir: string); reintroduce;
 
     function GetName: string; override;
     function Execute: Integer; override;

src/main/pascal/PasBuild.Command.ProcessTestResources.pas

@@ -30,7 +30,7 @@   TProcessTestResourcesCommand = class(TBuildCommand)
     function ApplyFiltering(const AContent: string): string;
     procedure CopyResources(const ASourceDir, ATargetDir: string);
   public
-    constructor Create(AConfig: TProjectConfig; AResourcesConfig: TResourcesConfig; const ATargetDir: string);
+    constructor Create(AConfig: TProjectConfig; AResourcesConfig: TResourcesConfig; const ATargetDir: string); reintroduce;
 
     function GetName: string; override;
     function Execute: Integer; override;

src/main/pascal/PasBuild.Config.pas

@@ -59,9 +59,9 @@ class function TConfigLoader.GetNodeText(AParent: TDOMNode; const ATagName: stri
   if not Assigned(AParent) then
     Exit;
 
-  Node := AParent.FindNode(ATagName);
+  Node := AParent.FindNode(UnicodeString(ATagName));
   if Assigned(Node) and Assigned(Node.FirstChild) then
-    Result := Trim(Node.TextContent);
+    Result := Trim(string(Node.TextContent));
 end;
 
 class procedure TConfigLoader.ParseDefines(AParent: TDOMNode; ADefines: TStringList);
@@ -83,7 +83,7 @@ class procedure TConfigLoader.ParseDefines(AParent: TDOMNode; ADefines: TStringL
     if (DefineNode.NodeType = ELEMENT_NODE) and (DefineNode.NodeName = 'define') then
     begin
       if Assigned(DefineNode.FirstChild) then
-        ADefines.Add(Trim(DefineNode.TextContent));
+        ADefines.Add(Trim(string(DefineNode.TextContent)));
     end;
   end;
 end;
@@ -107,7 +107,7 @@ class procedure TConfigLoader.ParseCompilerOptions(AParent: TDOMNode; AOptions:
     if (OptionNode.NodeType = ELEMENT_NODE) and (OptionNode.NodeName = 'option') then
     begin
       if Assigned(OptionNode.FirstChild) then
-        AOptions.Add(Trim(OptionNode.TextContent));
+        AOptions.Add(Trim(string(OptionNode.TextContent)));
     end;
   end;
 end;
@@ -123,7 +123,7 @@ class procedure TConfigLoader.ParseConditionalPaths(AParent: TDOMNode; const ATa
   if not Assigned(AParent) then
     Exit;
 
-  PathsNode := AParent.FindNode(ATagName);
+  PathsNode := AParent.FindNode(UnicodeString(ATagName));
   if not Assigned(PathsNode) then
     Exit;
 
@@ -135,7 +135,7 @@ class procedure TConfigLoader.ParseConditionalPaths(AParent: TDOMNode; const ATa
     begin
       if Assigned(PathNode.FirstChild) then
       begin
-        PathValue := Trim(PathNode.TextContent);
+        PathValue := Trim(string(PathNode.TextContent));
         if PathValue <> '' then
         begin
           // Get optional condition attribute
@@ -144,7 +144,7 @@ class procedure TConfigLoader.ParseConditionalPaths(AParent: TDOMNode; const ATa
           begin
             Element := TDOMElement(PathNode);
             if Element.HasAttribute('condition') then
-              Condition := Trim(Element.GetAttribute('condition'));
+              Condition := Trim(string(Element.GetAttribute('condition')));
           end;
 
           ConditionalPath := TConditionalPath.Create(PathValue, Condition);
@@ -240,7 +240,7 @@ class procedure TConfigLoader.ParseTestSection(ATestNode: TDOMNode; AConfig: TPr
       if (OptionNode.NodeType = ELEMENT_NODE) and (OptionNode.NodeName = 'option') then
       begin
         if Assigned(OptionNode.FirstChild) then
-          AConfig.TestConfig.FrameworkOptions.Add(Trim(OptionNode.TextContent));
+          AConfig.TestConfig.FrameworkOptions.Add(Trim(string(OptionNode.TextContent)));
       end;
     end;
   end;
@@ -278,7 +278,7 @@ class procedure TConfigLoader.ParseSourcePackageSection(ASourcePackageNode: TDOM
     begin
       if Assigned(IncludeNode.FirstChild) then
       begin
-        IncludeDir := Trim(IncludeNode.TextContent);
+        IncludeDir := Trim(string(IncludeNode.TextContent));
         if IncludeDir <> '' then
           AConfig.SourcePackageConfig.IncludeDirs.Add(IncludeDir);
       end;
@@ -303,7 +303,7 @@ class procedure TConfigLoader.ParseModules(AModulesNode: TDOMNode; AModuleList:
     begin
       if Assigned(ModuleNode.FirstChild) then
       begin
-        ModulePath := Trim(ModuleNode.TextContent);
+        ModulePath := Trim(string(ModuleNode.TextContent));
         if ModulePath <> '' then
           AModuleList.Add(ModulePath);
       end;

src/main/pascal/PasBuild.ModuleDiscovery.pas

@@ -72,7 +72,6 @@ class function TModuleDiscoverer.DiscoverModules(const AAggregatorPath: string):
   J: Integer;
   DependencyPath: string;
   AbsoluteDependencyPath: string;
-  DependencyModule: TModuleInfo;
   DependencyModuleInfo: TModuleInfo;
 begin
   Result := TModuleRegistry.Create;

src/main/pascal/PasBuild.Utils.pas

@@ -674,7 +674,7 @@ class function TUtils.CollectSourceFiles(const ABaseDir: string): TStringList;
 class function TUtils.CollectIncludeFiles(const ABaseDir: string): TStringList;
 var
   SearchRec: TSearchRec;
-  BasePath, FileName: string;
+  BasePath: string;
   SubDirs: TStringList;
   SubDir: string;
 begin